New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 22 days ago
Closed: Feb 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Sort fixed portion of encoding menu according to Chrome UI language

Reported by xlyuan@chromium.org, Feb 12 2009 Back to list

Issue description

See b/1137857.

Currently, we don't sort "Encoding" menu, we should sort the fixed portion
of the menu according to Chrome UI language.


 

Comment 1 by jnd@chromium.org, Feb 13 2009

It should be from b/1224433:-)

Comment 3 by bugdro...@gmail.com, Feb 20 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=10079 

------------------------------------------------------------------------
r10079 | jnd@chromium.org | 2009-02-19 21:17:28 -0800 (Thu, 19 Feb 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/l10n_util.h?r1=10079&r2=10078

I forgot to add #include <functional> to l10n_util.h for using binary_function

BUG= 7647 

Review URL: http://codereview.chromium.org/21533
------------------------------------------------------------------------

Comment 4 by xlyuan@chromium.org, Feb 26 2009

Status: Verified
Verified for English, Chinese, Japanese, French, German, Russian, Thai, overall, the 
sorting looks good. (Thai sorting is a little bit different than the result I 
generated by a tool, not sure if it is an issue, if it is, will file another issue 
for it, close this bug as fixed)

Verified on:
2.0.166.1  (Official Build 10303)

Comment 5 by jnd@chromium.org, Feb 26 2009

According to Jungshik's suggestion, We want to keep the order within a single 
encoding category. Also for same category which is defined in character_encoding.cc 
we want to keep the original defined order. So it's possible to be different than the 
result generated by a tool.
Labels: -I18N bulkmove Feature-I18N
See b/1137857.

Currently, we don't sort &quot;Encoding&quot; menu, we should sort the fixed portion
of the menu according to Chrome UI language.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-I18N Cr-UI-I18N
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 20 2013

Labels: -Cr-UI-I18N Cr-UI-Internationalization

Sign in to add a comment