New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

The Omnibox' KAV needs to respect the safeAreaLayoutGuide

Project Member Reported by jif@chromium.org, Sep 13 2017

Issue description

For the iPhone X.
 

Comment 1 by pkl@chromium.org, Sep 13 2017

Cc: justincohen@chromium.org

Comment 2 by pkl@chromium.org, Sep 13 2017

Labels: Hotlist-iOS11
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b472bbd660da7bbdeb87dad99f1b66e7539c107d

commit b472bbd660da7bbdeb87dad99f1b66e7539c107d
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Sep 13 15:30:45 2017

Have the toolbar's KAV respect the safeAreaLayoutGuide on iOS11.

Bug:  764692 
Change-Id: I3e2493f770e8218aa9a5eb0351dfc0db0612832d
Reviewed-on: https://chromium-review.googlesource.com/664809
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501638}
[modify] https://crrev.com/b472bbd660da7bbdeb87dad99f1b66e7539c107d/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm

Comment 4 by jif@chromium.org, Sep 13 2017

Labels: -Pri-3 Merge-Request-62 Pri-1

Comment 5 by cma...@chromium.org, Sep 13 2017

Labels: -Merge-Request-62 Merge-Approved-62
Merge approved upon verification of the fix on Trunk before merging and on branch 3202 after merging.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d5d839a1dd1a8d2be9be67769ed24bebdac7cb

commit 17d5d839a1dd1a8d2be9be67769ed24bebdac7cb
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Sep 13 18:33:15 2017

Revert "Have the toolbar's KAV respect the safeAreaLayoutGuide on iOS11."

This reverts commit b472bbd660da7bbdeb87dad99f1b66e7539c107d.

Reason for revert: Fix will need to be cherry-picked to M62.
I'd rather cherry-pick a single CL instead of a pair of CLs.

Original change's description:
> Have the toolbar's KAV respect the safeAreaLayoutGuide on iOS11.
> 
> Bug:  764692 
> Change-Id: I3e2493f770e8218aa9a5eb0351dfc0db0612832d
> Reviewed-on: https://chromium-review.googlesource.com/664809
> Commit-Queue: Jean-François Geyelin <jif@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501638}

TBR=jif@chromium.org,gambard@chromium.org

Change-Id: I46fa0684c2de2fb3298232c07165d7aa2362bc77
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  764692 
Reviewed-on: https://chromium-review.googlesource.com/665457
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501702}
[modify] https://crrev.com/17d5d839a1dd1a8d2be9be67769ed24bebdac7cb/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a371f7bb794ce9ded2c16556822620624d4032fc

commit a371f7bb794ce9ded2c16556822620624d4032fc
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Sep 13 20:27:24 2017

Reland "Have the toolbar's KAV respect the safeAreaLayoutGuide on iOS11"

Original CL ( https://chromium-review.googlesource.com/664809 ) had debugging
leftovers.

https://drive.google.com/open?id=0Bw-kA2pwDsU-a3BiUFB4Zl9tV3M
https://drive.google.com/open?id=0Bw-kA2pwDsU-bERYb1VrdjRTMm8

Bug:  764692 
Change-Id: I31026c24f8c0e7137950fe568bb831b813afc88d
Reviewed-on: https://chromium-review.googlesource.com/664891
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501737}
[modify] https://crrev.com/a371f7bb794ce9ded2c16556822620624d4032fc/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm

Comment 8 by jif@chromium.org, Sep 14 2017

Labels: Hotlist-iPhoneX

Comment 9 by cma...@chromium.org, Sep 14 2017

Are you still planning to merge this?

Comment 10 by jif@chromium.org, Sep 15 2017

Oh yes.
Only the reland ( a371f7bb794ce9ded2c16556822620624d4032fc ) needs to be cherry-picked.
Components: UI>Browser>Omnibox
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 18 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f808a21aa88678fe977986eac221cea4195a0988

commit f808a21aa88678fe977986eac221cea4195a0988
Author: Jean-François Geyelin <jif@chromium.org>
Date: Mon Sep 18 13:22:45 2017

Reland "Have the toolbar's KAV respect the safeAreaLayoutGuide on iOS11"

Original CL ( https://chromium-review.googlesource.com/664809 ) had debugging
leftovers.

https://drive.google.com/open?id=0Bw-kA2pwDsU-a3BiUFB4Zl9tV3M
https://drive.google.com/open?id=0Bw-kA2pwDsU-bERYb1VrdjRTMm8

Bug:  764692 
Change-Id: I31026c24f8c0e7137950fe568bb831b813afc88d
Reviewed-on: https://chromium-review.googlesource.com/664891
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501737}(cherry picked from commit a371f7bb794ce9ded2c16556822620624d4032fc)
Reviewed-on: https://chromium-review.googlesource.com/671003
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#283}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/f808a21aa88678fe977986eac221cea4195a0988/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15bb2b94e8860a36c64851ce0c7221df07cbc2b

commit d15bb2b94e8860a36c64851ce0c7221df07cbc2b
Author: Jean-François Geyelin <jif@chromium.org>
Date: Mon Sep 18 13:24:20 2017

Add SafeAreaLayoutGuideForView compatibility helper.

Helper to simplify autolayout code needing the
iOS11-only safeAreaLayoutGuide.

Bug:  764692 
Change-Id: I0ba706ba207c33425aeb7ceac7f179df46c89485
Reviewed-on: https://chromium-review.googlesource.com/667478
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502268}(cherry picked from commit 97455ea878d0a16b42c21605f3a24f135700cf04)
Reviewed-on: https://chromium-review.googlesource.com/671083
Cr-Commit-Position: refs/branch-heads/3202@{#284}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/d15bb2b94e8860a36c64851ce0c7221df07cbc2b/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.mm
[modify] https://crrev.com/d15bb2b94e8860a36c64851ce0c7221df07cbc2b/ios/chrome/browser/ui/util/BUILD.gn
[modify] https://crrev.com/d15bb2b94e8860a36c64851ce0c7221df07cbc2b/ios/chrome/browser/ui/util/constraints_ui_util.h
[modify] https://crrev.com/d15bb2b94e8860a36c64851ce0c7221df07cbc2b/ios/chrome/browser/ui/util/constraints_ui_util.mm
[add] https://crrev.com/d15bb2b94e8860a36c64851ce0c7221df07cbc2b/ios/chrome/browser/ui/util/constraints_ui_util_unittest.mm

Comment 15 by jif@chromium.org, Sep 18 2017

Status: Fixed (was: Started)
Fix has been merged to 62.

Sign in to add a comment