New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764666 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression:Chopped camera frame is seen in changePicture overlay of Minnie device

Project Member Reported by rkalavakuntla@chromium.org, Sep 13 2017

Issue description

Chrome Version:60.0.3112.114/9592.94.0 Stable-channel Minnie
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user ->Launch Chrome,Open chrome://md-settings/changePicture and Click to 'Take Photo'
(2)Rotate the screen(Ctrl+Shift+Reload)to 90/270 degrees and Observe(kindly refer video)

Actual:Chopped camera frame is seen
Expected:Instead,it shouldn't get chopped

This is a Non-Regression issue seen from M-55

Note:
1.Issue is not seen in Linux,Windows and other Chrome OS
2.Issue is also seen in latest dev M-63

@stevenjb: Please confirm the issue




 
Actual.webm
1.3 MB View Download
Expected.webm
1.1 MB View Download
Labels: -M-60 M-63
Cc: reve...@chromium.org
Labels: -M-63 M-64
Cc: steve...@chromium.org
Owner: reve...@chromium.org
Oops, I somehow assumed this this had been assigned to me as I'm the last to modify the camera code and created https://chromium-review.googlesource.com/c/chromium/src/+/697064 to fix it. I hope I was not duplicating work. Steven, feel free to re-assign this back to you and -1 the patch if you were planning to fix this some other way.
Nope, I try to be good about marking things I am actually working on as 'Started'.

I just didn't want to throw every 'change picture' bug your way, especially ones that predate your changes, but I am more than happy to have you fix this :) Thanks!

Feel free to assign bugs to me if you like. Sometimes it's obvious to me what's wrong as all the changes I've made to this code lately has made me very familiar with it. I'll just mark bugs as available if I don't have time to look at it.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c814ce7e142ef5b0c998e26b36b425c2495572

commit 46c814ce7e142ef5b0c998e26b36b425c2495572
Author: David Reveman <reveman@chromium.org>
Date: Tue Oct 03 18:45:00 2017

Change Picture: Center and scale camera video correctly.

Camera video preview was assuming 3:2 aspect ratio. This assumption
is wrong on a large range of devices in landscape mode and
completely breaks down in portrait mode where camera output on a
3:2 device becomes 2:3.

This updates the code for the camera preview so the video is always
centered and scaled to cover the preview area.

Bug:  764666 
Test: manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I244972106686a07dfc79263b5c2988839093f0ba
Reviewed-on: https://chromium-review.googlesource.com/697064
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506121}
[modify] https://crrev.com/46c814ce7e142ef5b0c998e26b36b425c2495572/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html

Status: Fixed (was: Assigned)

Sign in to add a comment