New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764665 link

Starred by 1 user
Status: Fixed
Owner:
█ emso@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
qyears...@chromium.org
█ emso@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Add recipe-based analyzer isolating files

Project Member Reported by emso@chromium.org, Sep 13 2017 
Add the GitFileIsolator analyzer isolating files for a patch set, taking tricium GIT_FILE_DETAILS data as input and producing tricium FILES data as output.

This should be a recipe-based analyzer reusing functionality in the recipe runtime and run via kitchen.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e3787991b92aaac0701d0449106475425993c184

commit e3787991b92aaac0701d0449106475425993c184
Author: Emma <emso@chromium.org>
Date: Wed Sep 20 19:46:16 2017

Adds support for non-result workers in the tracker.

The GitFileIsolator analyzer producing FILES data is an
example of an analyzer with a non-result worker.

Bug:764665
Change-Id: I3930b6bfdf3f2442b278ca3041d2100671cd8c7d
Reviewed-on: https://chromium-review.googlesource.com/671009
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/config.pb.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/reporter.pb.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/common/swarming.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/tracker.proto
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/driver.pb.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/devcfg/services/tricium-dev/service.cfg
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/tracker.pb.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/launcher.pb.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/driver/rpc_collect.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/common/isolate.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/devcfg/projects/infra/tricium-dev.cfg
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/appengine/tracker/rpc_worker_done_test.go
[modify] https://crrev.com/e3787991b92aaac0701d0449106475425993c184/go/src/infra/tricium/api/admin/v1/workflow.pb.go
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb

commit 74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb
Author: Emma <emso@chromium.org>
Date: Thu Sep 21 11:55:36 2017

Adds git file isolator analyzer

Bug:764665
Change-Id: I8f14b3e9df561995db32b8530d72e383c837c661
Reviewed-on: https://chromium-review.googlesource.com/668449
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/api/v1/data.pb.go
[add] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/analyzers/git-file-isolator/isolator.go
[add] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/analyzers/git-file-isolator/cipd.yaml
[add] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/analyzers/git-file-isolator/git-file-isolator.infra_testing
[modify] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/api/v1/pb.discovery.go
[add] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/analyzers/git-file-isolator/.gitignore
[add] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/analyzers/git-file-isolator/test/tricium/data/git_file_details.json
[modify] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/api/v1/data_helpers.go
[add] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/analyzers/git-file-isolator/README.md
[modify] https://crrev.com/74bef6abb93fdf7944ee3ecfd39dec9f6c65e8fb/go/src/infra/tricium/api/v1/data.proto

Comment 3 by emso@chromium.org, Sep 22 2017 

This analyzer has been added as a binary analyzer distributed via CIPD.

Comment 4 by emso@chromium.org, Sep 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment