New issue
Advanced search Search tips

Issue 764661 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Readonly text controls should show I-beam pointer when hovered

Reported by hu...@opera.com, Sep 13 2017

Issue description

Chrome Version: 61

What steps will reproduce the problem?
Hover an <input readonly>

What is the expected result?
I-beam is shown.

What happens instead?
No I-beam is shown.

Since <input readonly> allows selections it should hint this to the user by showing an I-beam when being hovered. 

Works in Firefox.
 

Comment 1 by hu...@vewd.com, Oct 4 2017

Owner: hu...@vewd.com
Status: Started (was: Available)
This user-facing problem was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/663217 .

Now we only need to add a test: https://chromium-review.googlesource.com/c/chromium/src/+/700454 .
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd79e17ec56bba732e6295877c7c9c896950271d

commit cd79e17ec56bba732e6295877c7c9c896950271d
Author: Hugo Holgersson <hugoh@vewd.com>
Date: Mon Oct 09 13:31:19 2017

Unit test fixup: Pass <input readonly>'s inner text to ShouldShowIBeamForNode()

ShouldShowIBeamForNode() returns false for nodes that aren't TextNode.

That's why we need pass the <input>'s inner text (the inner-editor's
child node) to test ShouldShowIBeamForNode() properly.

This CL can be seen as a fixup to:
https://chromium-review.googlesource.com/#/c/663217/ .

Bug:  764661 
Change-Id: I6fbc97841f29db33405e8cf6293614c3186111d0
Reviewed-on: https://chromium-review.googlesource.com/700454
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#507366}
[modify] https://crrev.com/cd79e17ec56bba732e6295877c7c9c896950271d/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/cd79e17ec56bba732e6295877c7c9c896950271d/third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Comment 3 by hu...@vewd.com, Oct 9 2017

Status: Fixed (was: Started)

Sign in to add a comment