Show Tricium progress in Gerrit |
||||||||||
Issue descriptionImplement a Tricium PolyGerrit plugin that shows Tricium progress in Gerrit. The start of a plugin has been added to https://chromium.googlesource.com/infra/gerrit-plugins/tricium
,
Sep 13 2017
Issue 638495 has been merged into this issue.
,
Sep 13 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/93885493dc5894090bca7e4d8826d22e56d765c7 commit 93885493dc5894090bca7e4d8826d22e56d765c7 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Oct 12 16:31:36 2017 Tricium plugin: Add status svg files and update tricium-view CSS The status images are copied from the buildbucket plugin, but for analyzer runs, there are currently only 4 supported states: pending, running, success, failure, no infra-failure or scheduled. Failure is a cross, success is a check-mark, and started is an ellipsis. The states "timed-out" and "canceled" may be supported in the future, but aren't currently supported. Bug: 764659 Change-Id: I26e7c15368d66745c70cdb0c0cca4c772c0055c6 Reviewed-on: https://chromium-review.googlesource.com/714357 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Emma Söderberg <emso@chromium.org> [add] https://crrev.com/93885493dc5894090bca7e4d8826d22e56d765c7/src/main/resources/static/images/started.svg [add] https://crrev.com/93885493dc5894090bca7e4d8826d22e56d765c7/src/main/resources/static/images/failure.svg [add] https://crrev.com/93885493dc5894090bca7e4d8826d22e56d765c7/src/main/resources/static/images/success.svg [modify] https://crrev.com/93885493dc5894090bca7e4d8826d22e56d765c7/src/main/resources/static/tricium-view.html
,
Oct 21 2017
,
Nov 1 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/e07895133913ddacd3bbc75fef63e5c9e4d7b87b commit e07895133913ddacd3bbc75fef63e5c9e4d7b87b Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Nov 03 22:25:59 2017 Tricium plugin: Add logic for making a pRPC request. Bug: 764659 Change-Id: Ibfcdc5e6d9873d1bd004139d6379b43a9be18b62 Reviewed-on: https://chromium-review.googlesource.com/746992 Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/e07895133913ddacd3bbc75fef63e5c9e4d7b87b/src/main/resources/static/tricium-view.js [modify] https://crrev.com/e07895133913ddacd3bbc75fef63e5c9e4d7b87b/test/tricium-client_test.html [modify] https://crrev.com/e07895133913ddacd3bbc75fef63e5c9e4d7b87b/src/main/resources/static/tricium-client.js [modify] https://crrev.com/e07895133913ddacd3bbc75fef63e5c9e4d7b87b/src/main/resources/static/tricium-view.html
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/313069f3733fc1bb7e31abfdb2daa45c500a5231 commit 313069f3733fc1bb7e31abfdb2daa45c500a5231 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Nov 15 16:20:26 2017 Tricium plugin: Stringify request body in pRPC requests The request body for a fetch request is a string, not an object. In this case we want a JSON blob. Bug: 764659 Change-Id: Ia277a1e4873dd29e19aa0894c58c9892c6a29f33 Reviewed-on: https://chromium-review.googlesource.com/770102 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/313069f3733fc1bb7e31abfdb2daa45c500a5231/src/main/resources/static/tricium-client.js
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/98863806f8f2d08fe7e2faec40cb232256c013ed commit 98863806f8f2d08fe7e2faec40cb232256c013ed Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Nov 16 22:15:12 2017 Tricium plugin: Style tricium-view to match buildbucket The main purpose of this CL is to change the style of the tricium-view element so that it will be roughly the same as the buildbucket UI, consisting of a header bar and below it a series of "analyzer result" boxes, one for each analyzer in the run. It is simpler than buildbucket, since there is only one section and there is only one box per analyzer name. Apart from changing style and minor display things, this CL also adds an example.html file that can be used to experiment with the element's appearance without starting a Gerrit instance. Bug: 764659 Change-Id: I178807d0ad08c99edb23475ca4e325d257417c84 Reviewed-on: https://chromium-review.googlesource.com/773504 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/98863806f8f2d08fe7e2faec40cb232256c013ed/src/main/resources/static/tricium-view.js [add] https://crrev.com/98863806f8f2d08fe7e2faec40cb232256c013ed/src/main/resources/static/example.html [modify] https://crrev.com/98863806f8f2d08fe7e2faec40cb232256c013ed/README.md [modify] https://crrev.com/98863806f8f2d08fe7e2faec40cb232256c013ed/src/main/resources/static/tricium-view.html
,
Nov 27 2017
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/848d97f0f95b21268207c60d35969631ae2f8c76 commit 848d97f0f95b21268207c60d35969631ae2f8c76 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Dec 08 15:48:25 2017 Tricium plugin: Hide UI if no Tricium host is configured When the Tricium plugin is first enabled on chromium-review.googlesource.com, we probably don't want to show anything for most reviews; we just want to show the plugin UI for projects that have a config for tricium. Bug: 764659 Change-Id: I00d801cf29fdf350bd9da94d59298590437c1c01 Reviewed-on: https://chromium-review.googlesource.com/816060 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/848d97f0f95b21268207c60d35969631ae2f8c76/src/main/resources/static/example.html [modify] https://crrev.com/848d97f0f95b21268207c60d35969631ae2f8c76/src/main/resources/static/tricium-view.html
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/8e9c53826441ffd7ff305f2bfd5aa47de5af4058 commit 8e9c53826441ffd7ff305f2bfd5aa47de5af4058 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Dec 11 15:35:24 2017 Change Tricium to load config from project.config In the intial version, the Tricium plugin would load config from the plugin-specific file tricium.config in the refs/meta/config branch for a project. However, the Tricium config is relatively simple so it could also go in project.config. Getting config from project.config simplifies the plugin by removing the need for GetConfig.java and potentially making it possible to transition to a HTML-based plugin with no Java. Also in this CL: - Rename baseUrl to triciumHost - Change getConfig to use Plugin.restApi().get() - Add fake plugin object in example.html - Allow overridding gerrit host for local testing Bug: 764659 Change-Id: I7492b53c13654153d5e9b469cf5dc4ec2d701389 Reviewed-on: https://chromium-review.googlesource.com/817523 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/8e9c53826441ffd7ff305f2bfd5aa47de5af4058/src/main/resources/static/tricium-view.html [modify] https://crrev.com/8e9c53826441ffd7ff305f2bfd5aa47de5af4058/src/main/java/com/googlesource/chromium/plugins/tricium/TriciumModule.java [modify] https://crrev.com/8e9c53826441ffd7ff305f2bfd5aa47de5af4058/src/main/resources/static/example.html [modify] https://crrev.com/8e9c53826441ffd7ff305f2bfd5aa47de5af4058/src/main/resources/static/tricium-view.js [delete] https://crrev.com/848d97f0f95b21268207c60d35969631ae2f8c76/src/main/java/com/googlesource/chromium/plugins/tricium/GetConfig.java [modify] https://crrev.com/8e9c53826441ffd7ff305f2bfd5aa47de5af4058/README.md [modify] https://crrev.com/8e9c53826441ffd7ff305f2bfd5aa47de5af4058/src/main/resources/static/tricium-client.js
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/5c37eac48599a4aa77c85ee36017c11156455c32 commit 5c37eac48599a4aa77c85ee36017c11156455c32 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Dec 13 16:34:49 2017 Tricium plugin: Follow-up fix to enable tests and example After a couple of recent changes, including the deployment of a new tricium server that includes gerrit host as a field in the gerrit consumer details, the tricium plugin example.html didn't work anymore. This gets it back to a working state. This change includes: - Fix a mistake in reload() - Log a warning and bail if the element is made without initializing attributes, which may happen in tests and in example.html - Update change/patchset to one where there's recent workflow run results in tricium-dev Bug: 764659 Change-Id: I2609b0427414970985ffe0840fdc9c2b8474a5b3 Reviewed-on: https://chromium-review.googlesource.com/823226 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/5c37eac48599a4aa77c85ee36017c11156455c32/src/main/resources/static/example.html [modify] https://crrev.com/5c37eac48599a4aa77c85ee36017c11156455c32/src/main/resources/static/tricium-view.js
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb commit 5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Dec 15 19:22:21 2017 Tricium plugin: convert to html-based plugin In this CL: - Remove Java and BUILD file. - Add tricum.html file which loads and installs plugin element. - Add script to run with prod data. - Update script to run with local Gerrit test site. - Update tests and README file. Bug: 764659 Change-Id: I79fb68f7244adaf17b39b626552aab7a730b48cc Reviewed-on: https://chromium-review.googlesource.com/827555 Reviewed-by: Emma Söderberg <emso@chromium.org> [delete] https://crrev.com/5c37eac48599a4aa77c85ee36017c11156455c32/src/main/resources/static/tricium.js [rename] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/test/example.html [delete] https://crrev.com/5c37eac48599a4aa77c85ee36017c11156455c32/reload-gerrit.sh [rename] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/resources/static/tricium-client.html [delete] https://crrev.com/5c37eac48599a4aa77c85ee36017c11156455c32/BUILD [rename] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/resources/static/tricium-view.js [modify] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/test/tricium-view_test.html [add] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/run-gerrit-testsite.sh [rename] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/resources/static/tricium-client.js [modify] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/test/tricium-client_test.html [add] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/run-server.sh [add] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/resources/static/tricium.html [delete] https://crrev.com/5c37eac48599a4aa77c85ee36017c11156455c32/src/main/java/com/googlesource/chromium/plugins/tricium/TriciumModule.java [modify] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/README.md [rename] https://crrev.com/5d01ca2821cd1790bf15c4c93be7a0fb7894bdfb/resources/static/tricium-view.html
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/dac767c0fdeeb0658d9d066e7442ac4930977b67 commit dac767c0fdeeb0658d9d066e7442ac4930977b67 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Dec 21 16:57:57 2017 Update README and add script for running with prod data. This CL essentially re-does some of the useful parts of https://crrev.com/c/827555 and https://crrev.com/c/817523, which had to be reverted because it turns out we can't (yet) change the plugin to be html-based. In this CL: - Move and update example.html - Rename baseUrl to triciumHost - Improve scripts, update README - Add a script for running with prod data Bug: 764659 Change-Id: I7efae125357ad3b5f4d5071b97dc4993c4cb0c6e Reviewed-on: https://chromium-review.googlesource.com/836733 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/dac767c0fdeeb0658d9d066e7442ac4930977b67/src/main/resources/static/tricium-client.js [delete] https://crrev.com/d223972d9bfb0b695c9a7e2ac001482822175401/reload-gerrit.sh [modify] https://crrev.com/dac767c0fdeeb0658d9d066e7442ac4930977b67/src/main/resources/static/tricium-view.js [add] https://crrev.com/dac767c0fdeeb0658d9d066e7442ac4930977b67/run-with-testsite.sh [add] https://crrev.com/dac767c0fdeeb0658d9d066e7442ac4930977b67/run-with-prod-data.sh [rename] https://crrev.com/dac767c0fdeeb0658d9d066e7442ac4930977b67/test/example.html [modify] https://crrev.com/dac767c0fdeeb0658d9d066e7442ac4930977b67/README.md
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/542cab649fbcb7cd9968847caaaf96cd32d1c574 commit 542cab649fbcb7cd9968847caaaf96cd32d1c574 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Dec 22 17:01:56 2017 Tricium plugin: Simplify _getOAuthConfig by using restApi For all fetching from Gerrit itself we can use the restApi object. This change simplifies a method by using restApi, similar to a change in the buildbucket plugin: https://crrev.com/c/786136. Bug: 764659 Change-Id: I8db8ce7e3c7eed13adc401d86ed1ac36546ea149 Reviewed-on: https://chromium-review.googlesource.com/840608 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/542cab649fbcb7cd9968847caaaf96cd32d1c574/src/main/resources/static/tricium-client.js
,
Dec 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/de098849009021dfc5e129b019be742b0c71eb4d commit de098849009021dfc5e129b019be742b0c71eb4d Author: Quinten Yearsley <qyearsley@chromium.org> Date: Sat Dec 30 18:57:37 2017 Fix tricium-client unit test; add now-required property. The unit tests were failing silently since I changed the Tricium plugin to abort and log when triciumHost is not configured. This fixes a minor error in the unit tests. Bug: 764659 Change-Id: I21f4833ac2cc06934556bfe4133153f43d2471c9 Reviewed-on: https://chromium-review.googlesource.com/843149 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/de098849009021dfc5e129b019be742b0c71eb4d/test/tricium-client_test.html
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/5b1e38bc960cfe16e05514edea1f365a3c7635b5 commit 5b1e38bc960cfe16e05514edea1f365a3c7635b5 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Jan 05 16:48:26 2018 Tricium plugin: Trim "canary-" when on a canary host. Reason: For testing the latest version of the plugin, it's convenient to use the canary host. However, the host string sent in the Progress request should still be the non-canary host string. Bug: 764659 Change-Id: I7aab40de1f4c9fb999e92cefc8d46785279af3f7 Reviewed-on: https://chromium-review.googlesource.com/851053 Reviewed-by: Emma Soederberg <emso@google.com> Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/5b1e38bc960cfe16e05514edea1f365a3c7635b5/src/main/resources/static/tricium-client.js [modify] https://crrev.com/5b1e38bc960cfe16e05514edea1f365a3c7635b5/test/example.html
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/0e41a0c94bc311cd6a7dc40584e58d2a0543e7b5 commit 0e41a0c94bc311cd6a7dc40584e58d2a0543e7b5 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Jan 11 17:05:00 2018 Tricium plugin: Change style to be closer to buildbucket Specifically, for the buildbucket plugin there is no border on the left and right of the header for the tryjobs section, and there is no border below the tryjob blocks. This makes it so there should only be a top and bottom border around the header for the section. Bug: 764659 Change-Id: I9d0cde59e23052e1455088813381efa439e592a2 Reviewed-on: https://chromium-review.googlesource.com/860725 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/0e41a0c94bc311cd6a7dc40584e58d2a0543e7b5/src/main/resources/static/tricium-view.html
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/8cfbf9a0ad20cc90f138b84ddae89cf5533b83ed commit 8cfbf9a0ad20cc90f138b84ddae89cf5533b83ed Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Jan 11 17:05:16 2018 Tricium plugin: Show "No analyzers" in case of error Currently, The text in the UI that shows the title of the section is set when the _analyzerResults property changes. If an error occurs in the request to tricium, it is never updated, so the UI remains blank. This change makes it so before a successful request is made "No Analyzers" is shown (with no update time). If an error occurs, no update is made to the UI, but a message is logged in the console. Note, it's still the case that if there's no tricium config for a project, no UI should be shown at all. Bug: 764659 Change-Id: I3f573b8be0eaca732921dd67e6feb45e43c9384e Reviewed-on: https://chromium-review.googlesource.com/860724 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/8cfbf9a0ad20cc90f138b84ddae89cf5533b83ed/src/main/resources/static/tricium-view.js
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/74c40831e1be715b104afd72ad200867fff7f4d4 commit 74c40831e1be715b104afd72ad200867fff7f4d4 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Jan 11 17:10:21 2018 Tricium plugin: rename variable, remove unused variable This change includes a couple of minor changes that shouldn't affect behavior at all: remove _email and rename the variable allAnalyzers. Also minor reformatting. Bug: 764659 Change-Id: I59786bf49d58ec127c3840d601192d81929901f9 Reviewed-on: https://chromium-review.googlesource.com/860744 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/74c40831e1be715b104afd72ad200867fff7f4d4/src/main/resources/static/tricium-view.js
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/8059c8748a394d67e406884e5f29dc0fd4560a75 commit 8059c8748a394d67e406884e5f29dc0fd4560a75 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Jan 12 18:05:17 2018 Tricium plugin: Update analyzer -> function This change updates usage of the term analyzer in the Tricium plugin. Specifically: CSS class "analyzer" -> "function" property "_analyzerResults" -> "results" method "_updateAnalyzers" -> "_update" Enum object "AnalyzerState" -> "FunctionState" UI text "Analyzers" -> "Tricium Results" Also, this prepares the plugin for schema changes in https://chromium-review.googlesource.com/c/infra/infra/+/861097. After this change, the plugin should be able to accept a response with "analyzerProgress" or "functionProgress", and with "analyzer" or "name". Bug: 764659 Change-Id: Iae93d30f7a5729367ae88f9df8b9f73a8f21193f Reviewed-on: https://chromium-review.googlesource.com/862200 Reviewed-by: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/src/main/resources/static/tricium-client.js [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/src/main/resources/static/tricium-view.js [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/test/tricium-client_test.html [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/test/tricium-view_test.html [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/test/example.html [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/README.md [modify] https://crrev.com/8059c8748a394d67e406884e5f29dc0fd4560a75/src/main/resources/static/tricium-view.html
,
Jan 26 2018
I just went through and played with the demo a bit and I have some design questions: 1) How does it handle changing the currently-viewed patchset? The buildbucket plugin shows which patchsets it is currently rendering results for. Updating the display when the patchset changes requires some polymer observers (see https://canary-chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/878926). 2) It doesn't seem to visually distinguish between analyzers that had findings and those that had no findings. Is it planned to do so? What's the color (+accessible colorblind) plan for doing so? 3) How does the tricium Progress API decide what jobs to return? When I view https://chromium-review.googlesource.com/c/playground/gerrit-tricium/demo/+/883968/ and open the network inspector, the request to the Progress api specifies patchset 4. But the messages on that change seem to indicate that tricium only ran when patchset 3 was the latest patchset. What's the logic here for returning/displaying patchset-specific analyzer progress?
,
Jan 26 2018
,
Jan 27 2018
,
Jan 27 2018
,
Jan 27 2018
Thanks for going through it, excellent feedback! 1 and 3) Currently, 2henever a request for progress updates is made, the plugin sends a request with the given patchset. However, currently the service ignores the patchset part and returns results for the latest patchset for the issue. Changes to make: a. Include patchset number in Tricium progress display to make it clear which patchset the results are for (should ideally always be currently displayed patchset). b. Include patchset number in mapping in Tricium ( crbug.com/806532 ) so that results for a particular patchset are returned. 2) Great point, it would be useful to visually distinguish and the plugin already has the required information to do this, so it shouldn't be a complicated change. Filed crbug.com/806533 . I'd like to hold out on announcing the demo until I address these issues.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/0e840af8da55ecf107c294c75eb2caf9d4aa5d0f commit 0e840af8da55ecf107c294c75eb2caf9d4aa5d0f Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Jan 29 23:48:02 2018 Show patchset number in Tricium plugin UI. In this CL: Add a method which returns a string to display in the UI showing the patchset number, and add an observer method for the `revision` property which causes the results to be refreshed. Bug: 806532 , 764659 Change-Id: I40ef12afda0f920c407a3b2b6a9641450e28e83a Reviewed-on: https://chromium-review.googlesource.com/892023 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/0e840af8da55ecf107c294c75eb2caf9d4aa5d0f/test/tricium-view_test.html [modify] https://crrev.com/0e840af8da55ecf107c294c75eb2caf9d4aa5d0f/test/example.html [modify] https://crrev.com/0e840af8da55ecf107c294c75eb2caf9d4aa5d0f/src/main/resources/static/tricium-view.html [modify] https://crrev.com/0e840af8da55ecf107c294c75eb2caf9d4aa5d0f/test/index.html [modify] https://crrev.com/0e840af8da55ecf107c294c75eb2caf9d4aa5d0f/src/main/resources/static/tricium-view.js
,
Jan 30 2018
Now waiting for the latest changes to be rolled and later deployed to prod Gerrit
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/85cc2288f40d63620df10af4cb3102ad3710ddbc commit 85cc2288f40d63620df10af4cb3102ad3710ddbc Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Jan 31 18:02:11 2018 Update run-with-prod-data.sh to use the name tricium This is a script that is similar to the script added in the buildbucket plugin repo in https://crrev.com/c/857688. This change just changes the script in tricium to use the name tricium, now that tricium is enabled on Chromium Gerrit. Bug: 764659 Change-Id: I67b095fdb016537a9dab49b41ff14370a2811ec6 Reviewed-on: https://chromium-review.googlesource.com/889420 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/85cc2288f40d63620df10af4cb3102ad3710ddbc/run-with-prod-data.sh
,
Feb 2 2018
The progress plugin is now shown in Gerrit. Example: https://canary-chromium-review.googlesource.com/c/playground/gerrit-tricium/demo/+/899863 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by emso@chromium.org
, Sep 13 2017