New issue
Advanced search Search tips

Issue 764656 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

AudioInputController doesn't balance calls to UserInputMonitor

Project Member Reported by maxmorin@chromium.org, Sep 13 2017

Issue description

AudioInputController unconditionally calls UserInputMonitor::DisableKeyPressMonitoring when closing, but only calls EnableKeyPressMonitoring when Record is called. This leads to a messed-up reference count in UserInputMonitor if we close a stream without starting it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03421a1f6e4dfe3eb3d51ea1432ecd25ff116d14

commit 03421a1f6e4dfe3eb3d51ea1432ecd25ff116d14
Author: Max Morin <maxmorin@chromium.org>
Date: Wed Sep 13 12:17:22 2017

Disable keyboard monitoring only if it's enabled.

AudioInputController unconditionally calls
UserInputMonitor::DisableKeyPressMonitoring when closing, but only calls
EnableKeyPressMonitoring when Record is called. This leads to a
messed-up reference count in UserInputMonitor if we close a stream
without first starting it.

Bug:  764656 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id85c5c2d26d2745588d8c6cc7c4555adddb9c2f2
Reviewed-on: https://chromium-review.googlesource.com/664577
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501598}
[modify] https://crrev.com/03421a1f6e4dfe3eb3d51ea1432ecd25ff116d14/media/audio/audio_input_controller.cc
[modify] https://crrev.com/03421a1f6e4dfe3eb3d51ea1432ecd25ff116d14/media/audio/audio_input_controller_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment