Chrome PDF Search is not executed in background
Reported by
ilariopi...@gmail.com,
Sep 13 2017
|
|||||||||
Issue descriptionChrome Version : 61.0.3163.79 OS Version: Ubuntu 16.04 What steps will reproduce the problem? 1. Open a long pdf 2. Start a research 3. Try to navigate over found result while the research is still pending What is the expected result? The research should be done in background and the user can navigate over already found results What happens instead of that? The research is done foreground and the user can't navigate over results until the research ends Attaching a video of old behavior of chrome 58.0.3029.11 Why this feature changed? UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36
,
Sep 14 2017
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome stable version #61.0.3163.79 and latest canary #63.0.3214.0. Bisect Information: ===================== Good build: 60.0.3080.0 Revision(466837) Bad Build : 60.0.3081.0 Revision(467177) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/bbc102ac1bbea1031b7f8c5ad62ceb04b84dd301..feafc2de2c3e515247b5f45ab9ac9a4139b6cd46 From the above change log suspecting below change Review URL: https://codereview.chromium.org/2836973002 paulmeyer@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Oct 17 2017
This seems to be caused by problems in the internal find algorithm in the PDF find plugin, likely in pdfium_engine.cc: https://cs.chromium.org/chromium/src/pdf/pdfium/pdfium_engine.cc?rcl=c320900e1f204c1b3cc038dbffbf6bc851f72d9a&l=2179 For some reason, the browser is not receiving an active find match until the search completes. Without this first active match, find-next requests cannot be handled (and are thus queued until the first active match is reported).
,
Oct 17 2017
Issue 749825 has been merged into this issue.
,
Oct 17 2017
paulmeyer: Thanks for looking. This sounds like a PDF Viewer bug, and this has been annoying me, so I will take it.
,
Nov 7 2017
,
Feb 8 2018
*ping* Just wanted to check if this is still on anyone's radar? It's been broken and reported for over half a year now ( issue 749825 ), and it really makes working with large technical manuals a pain. Can we assign a target milestone for the fix?
,
Feb 9 2018
This affects me too. I've been reading Intel processor manuals recently. I looked it this briefly but couldn't quickly fix it. Then I went off to deal with some other bug and never got back around to this.
,
Mar 7 2018
Comment 3 said the browser is not receiving an active find match. The active find match is triggered by NotifySelectedFindResultChanged() calls, and r467124 moved them all into PDFiumEngine::SelectFindResult(). So I feel like we need to undo some of the PDFiumEngine changes there.
,
Apr 16 2018
https://chromium-review.googlesource.com/1013748
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3ea2d2b78f0108debbf6ba56d1b702b63571349 commit c3ea2d2b78f0108debbf6ba56d1b702b63571349 Author: Lei Zhang <thestig@chromium.org> Date: Thu Apr 26 00:22:23 2018 PDF: Fix find text behavior. Highlight the first search result immediately after finding it while the search continues onwards. Instead of waiting for all the search results to return before highlighting the first search result. BUG= 764635 Change-Id: I445ffb88527bd592fc5a51d499ea90d752a88918 Reviewed-on: https://chromium-review.googlesource.com/1013748 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#553843} [modify] https://crrev.com/c3ea2d2b78f0108debbf6ba56d1b702b63571349/pdf/pdfium/findtext_unittest.cc [modify] https://crrev.com/c3ea2d2b78f0108debbf6ba56d1b702b63571349/pdf/pdfium/pdfium_engine.cc [modify] https://crrev.com/c3ea2d2b78f0108debbf6ba56d1b702b63571349/pdf/pdfium/pdfium_engine.h
,
Apr 26 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ligim...@chromium.org
, Sep 13 2017