New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764635 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome PDF Search is not executed in background

Reported by ilariopi...@gmail.com, Sep 13 2017

Issue description

Chrome Version       : 61.0.3163.79
OS Version: Ubuntu 16.04

What steps will reproduce the problem?
1. Open a long pdf
2. Start a research
3. Try to navigate over found result while the research is still pending

What is the expected result?
The research should be done in background and the user can navigate over already found results

What happens instead of that?
The research is done foreground and the user can't navigate over results until the research ends

Attaching a video of old behavior of chrome 58.0.3029.11

Why this feature changed?

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36
 
58.0.3029.110_background.mp4
781 KB View Download
Labels: Needs-Triage-M61
Components: Internals>Plugins>PDF UI>Browser>FindInPage
Labels: -Type-Bug -Pri-3 hasbisect-per-revision M-63 OS-Mac OS-Windows Pri-1 Type-Bug-Regression
Owner: paulmeyer@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Ubuntu 14.04 and Mac 10.12.6 using chrome stable version #61.0.3163.79 and latest canary #63.0.3214.0.

Bisect Information:
=====================
Good build: 60.0.3080.0	 Revision(466837)
Bad Build : 60.0.3081.0	 Revision(467177)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/bbc102ac1bbea1031b7f8c5ad62ceb04b84dd301..feafc2de2c3e515247b5f45ab9ac9a4139b6cd46

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2836973002

paulmeyer@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!
Owner: wjmaclean@chromium.org
Status: Untriaged (was: Assigned)
This seems to be caused by problems in the internal find algorithm in the PDF find plugin, likely in pdfium_engine.cc: https://cs.chromium.org/chromium/src/pdf/pdfium/pdfium_engine.cc?rcl=c320900e1f204c1b3cc038dbffbf6bc851f72d9a&l=2179

For some reason, the browser is not receiving an active find match until the search completes. Without this first active match, find-next requests cannot be handled (and are thus queued until the first active match is reported).
Cc: thestig@chromium.org hnakashima@chromium.org paulmeyer@chromium.org dsinclair@chromium.org
 Issue 749825  has been merged into this issue.
Cc: wjmaclean@chromium.org
Owner: thestig@chromium.org
paulmeyer: Thanks for looking. This sounds like a PDF Viewer bug, and this has been annoying me, so I will take it.
Status: Assigned (was: Untriaged)
*ping*

Just wanted to check if this is still on anyone's radar? It's been broken and reported for over half a year now ( issue 749825 ), and it really makes working with large technical manuals a pain. Can we assign a target milestone for the fix?
This affects me too. I've been reading Intel processor manuals recently. I looked it this briefly but couldn't quickly fix it. Then I went off to deal with some other bug and never got back around to this.
Cc: nick@chromium.org
Comment 3 said the browser is not receiving an active find match. The active find match is triggered by NotifySelectedFindResultChanged() calls, and r467124 moved them all into PDFiumEngine::SelectFindResult(). So I feel like we need to undo some of the PDFiumEngine changes there.
Labels: -M-63 -Needs-Triage-M61 M-68
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/1013748
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3ea2d2b78f0108debbf6ba56d1b702b63571349

commit c3ea2d2b78f0108debbf6ba56d1b702b63571349
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Apr 26 00:22:23 2018

PDF: Fix find text behavior.

Highlight the first search result immediately after finding it while the
search continues onwards. Instead of waiting for all the search results
to return before highlighting the first search result.

BUG= 764635 

Change-Id: I445ffb88527bd592fc5a51d499ea90d752a88918
Reviewed-on: https://chromium-review.googlesource.com/1013748
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553843}
[modify] https://crrev.com/c3ea2d2b78f0108debbf6ba56d1b702b63571349/pdf/pdfium/findtext_unittest.cc
[modify] https://crrev.com/c3ea2d2b78f0108debbf6ba56d1b702b63571349/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/c3ea2d2b78f0108debbf6ba56d1b702b63571349/pdf/pdfium/pdfium_engine.h

Status: Fixed (was: Started)

Sign in to add a comment