New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764631 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Name of 'firmware_key' Generated by HWID Database Builder is Without Keyword - premp / mp

Project Member Reported by marcochen@chromium.org, Sep 13 2017

Issue description

In process of HWID verification, [1] would check the name of firmware_key component should be with _mp in PVT and later stage.

On the other hand, HWID database builder is recommend to generate HWID database. But refer to [2], for non-dev key the name will be "firmware_keys_non_dev" therefore this automatically generated result can't pass HWID verification.

[1] https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/hwid/v3/common.py#368
[2] https://chromium.googlesource.com/chromiumos/platform/factory/+/master/py/hwid/v3/builder.py#117
 
Cc: pyeh@chromium.org
Cc: chromeos-factory-eng@google.com
Owner: yhong@chromium.org
Status: Assigned (was: Untriaged)
Not sure what needs to be done - temporarily assign to yhong.
Step to reproduce:

  1. signer key is changed to MP version so firmware is signed by MP key now.
  2. partner tries to update HWID by calling `hwid update-database` with MP key in probing result.
  3. the auto updated HWID will contain a new firmware key called "firmware_keys_non_dev_1".
  4. Then this new HWID will cause `hwid_verify` failed because the key name is not with '_mp' in PVT phage.

Issue:
  1. step 3 generated "firmware_keys_non_dev_1" but it should be "firmware_keys_mp"

  2. Or step 4 should have more good way to check mp key not just relied on key name.

Sign in to add a comment