New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Participants' hotlists:
Cr8er


Sign in to add a comment

Show remark to login instead of error label when one is not logged in

Project Member Reported by hablich@chromium.org, Sep 13 2017

Issue description

Current situation:

- When one is not logged in
- When one is looking at a commit/<hash>
- Error labels are shown in the bottom left corner (403)

New situation:

- When one is not logged in
- When one is looking at a commit/<hash>
- A remark is shown at the bottom of the "Performance" and "Clusterfuzz" boxes with the text "Please login to see more information."
- Error labels in the bottom left corner of the screen are NOT shown anymore.
 
Owner: adolimpio@google.com
Status: Started (was: Available)
I think putting the remark on the second header works better, I feel like putting it at the bottom it becomes visually as interesting as another roll. Example: https://screenshot.googleplex.com/XWsRPD5OiVo wdyt?
Hmmm, might even be better because in that case the second header block
never appears/disappears depending on the logged-in state.
hmm, not really.. it will still be hidden when loading the data in case something goes wrong we don't want to show just a header to nothing. But yeah that's the general idea

Comment 4 by odeedee@google.com, Sep 14 2017

I think a toast is fine though we can change the way the toast works to 'dissappear' when the user logs in. If it is done by the way it is in the screenshot above, then it would also have to be done for ClusterFuzz data as well which would start looking too repetitive. 
Just to keep everyone on the same page, I strongly prefer the solution currently staged here: https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/450772 (screenshot: https://screenshot.googleplex.com/qj6LyzF1vsp)

Hints via UI and not toasts, as toasts are visually distracting and will fire continuously for folks who can't (or don't want to) log in, which is suboptimal IMO.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/4de0006cc0976072309c231494694623eb99eeae

commit 4de0006cc0976072309c231494694623eb99eeae
Author: Andrea D'Olimpio <adolimpio@google.com>
Date: Thu Sep 14 18:00:58 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/a82fd63c63f9da6180f0e95744752563295e779c

commit a82fd63c63f9da6180f0e95744752563295e779c
Author: odeedee <odeedee@google.com>
Date: Tue Sep 19 08:11:41 2017

Status: Fixed (was: Started)

Sign in to add a comment