Show remark to login instead of error label when one is not logged in |
||
Issue descriptionCurrent situation: - When one is not logged in - When one is looking at a commit/<hash> - Error labels are shown in the bottom left corner (403) New situation: - When one is not logged in - When one is looking at a commit/<hash> - A remark is shown at the bottom of the "Performance" and "Clusterfuzz" boxes with the text "Please login to see more information." - Error labels in the bottom left corner of the screen are NOT shown anymore.
,
Sep 13 2017
Hmmm, might even be better because in that case the second header block never appears/disappears depending on the logged-in state.
,
Sep 13 2017
hmm, not really.. it will still be hidden when loading the data in case something goes wrong we don't want to show just a header to nothing. But yeah that's the general idea
,
Sep 14 2017
I think a toast is fine though we can change the way the toast works to 'dissappear' when the user logs in. If it is done by the way it is in the screenshot above, then it would also have to be done for ClusterFuzz data as well which would start looking too repetitive.
,
Sep 14 2017
Just to keep everyone on the same page, I strongly prefer the solution currently staged here: https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/450772 (screenshot: https://screenshot.googleplex.com/qj6LyzF1vsp) Hints via UI and not toasts, as toasts are visually distracting and will fire continuously for folks who can't (or don't want to) log in, which is suboptimal IMO.
,
Sep 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/4de0006cc0976072309c231494694623eb99eeae commit 4de0006cc0976072309c231494694623eb99eeae Author: Andrea D'Olimpio <adolimpio@google.com> Date: Thu Sep 14 18:00:58 2017
,
Sep 19 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/a82fd63c63f9da6180f0e95744752563295e779c commit a82fd63c63f9da6180f0e95744752563295e779c Author: odeedee <odeedee@google.com> Date: Tue Sep 19 08:11:41 2017
,
Sep 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by adolimpio@google.com
, Sep 13 2017Status: Started (was: Available)