New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764606 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

CHECK failure: previous_buffers_timestamp <= buffer->GetDecodeTimestamp() in webm_cluster_parse

Project Member Reported by ClusterFuzz, Sep 13 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5156604919152640

Fuzzer: libFuzzer_mediasource_WEBM_VP9_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  previous_buffers_timestamp <= buffer->GetDecodeTimestamp() in webm_cluster_parse
  SignalHandler
  media::WebMClusterParser::Track::QueueBuffer
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=497057:497112

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5156604919152640

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Labels: Test-Predator-Wrong CF-NeedsTriage M-63
Unable to find the possible suspect using Predator, CL and Code Search.
Could some one please look into the issue.

Thank You.
Cc: msrchandra@chromium.org kkaluri@chromium.org
Cc: dalecur...@chromium.org wolenetz@chromium.org
Labels: -CF-NeedsTriage
Owner: chcunningham@chromium.org
Status: Assigned (was: Untriaged)
Using Code Search for the file, "webm_cluster_parser.cc" assigning to the concern owner who might be related.

@chcunningham -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Components: Internals>Media>Source
Labels: -Pri-1 Pri-2
Very interesting CHECK that's hit. I don't think security nor PTS/DTS compliance related; moving to P2 and leaving on chcunningham@'s plate. Feel free to reassign if you need, Chris.
See also bug 271794.
Project Member

Comment 6 by ClusterFuzz, Oct 1 2017

Components: Internals>Media
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Components: -Internals>Media
We will not apply the less-specific component label anymore.
Some of these didn't have any media labels so I saw them for the first time :)
Cc: chcunningham@chromium.org
Owner: tguilbert@chromium.org
cc+tguilbert

Chris, I'm reassigning this to Thomas (along with suspected duplicate  bug 765627 .)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ea9bee45009ccb9b5f4bdf5c86d43e8644f2556

commit 7ea9bee45009ccb9b5f4bdf5c86d43e8644f2556
Author: Thomas Guilbert <tguilbert@chromium.org>
Date: Wed Oct 04 03:38:29 2017

Fix int64 overflow in WebmClusterParser

If the value of |cluster_timecode_| and |timecode_multiplier_|
is big enough, we can end up with a value that does not fit in
an int64_t. This in turn means that all buffers will have kNoTimestamp
as a timestamp, which causes some CHECKs to fail later on.

Bug:  764606 ,  765627 
Change-Id: Ia11b19606a05c412390a597ae5a4ae5ccf2dab3c
Reviewed-on: https://chromium-review.googlesource.com/699522
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506294}
[modify] https://crrev.com/7ea9bee45009ccb9b5f4bdf5c86d43e8644f2556/media/formats/webm/webm_cluster_parser.cc

Project Member

Comment 11 by ClusterFuzz, Oct 4 2017

ClusterFuzz has detected this issue as fixed in range 506279:506298.

Detailed report: https://clusterfuzz.com/testcase?key=5156604919152640

Fuzzer: libFuzzer_mediasource_WEBM_VP9_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  previous_buffers_timestamp <= buffer->GetDecodeTimestamp() in webm_cluster_parse
  SignalHandler
  media::WebMClusterParser::Track::QueueBuffer
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=497057:497112
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=506279:506298

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5156604919152640

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Oct 4 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5156604919152640 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment