New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764595 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task



Sign in to add a comment

Make ServiceWorkerVersion::StopWorker() take OnceClosure

Project Member Reported by yukiy@google.com, Sep 13 2017

Issue description

Current ServiceWorkerVersion::StopWorker() takes StatusCallback as args, but this method always runs it with SERVICE_WORKER_OK.
To simplify this, change it to OnceClosure.
 
i like turtles]

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd

commit 0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd
Author: Yuki Yamada <yukiy@google.com>
Date: Fri Sep 15 02:15:23 2017

Make ServiceWorkerVersion::StopWorker() take OnceClosure

This CL changes the argument of ServiceWorkerVersion::StopWorker().
It took StatusCallback but just always returned SERVICE_WORKER_OK.
To simplify this, change it to OnceClosure.

Bug:  764595 
Change-Id: Ib74ff2a13ebdad382f0df667a3f4b542108f15a3
Reviewed-on: https://chromium-review.googlesource.com/664520
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#502132}
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_context_core.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_context_wrapper.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_internals_ui.h
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_registration.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/0982ddb4d4f612cf5078dd2b1ac835142b5bfbbd/content/browser/service_worker/service_worker_version_unittest.cc

Comment 3 by yukiy@google.com, Sep 22 2017

Status: Fixed (was: Started)

Sign in to add a comment