bluetoothAdapterHIDReports passes under certain fault conditions |
|||||
Issue descriptionTried CL:639850 with CL:663788 but without CL:664419. This probably shouldn't happen. Relevant logs: 22:57:39 INFO | autoserv| <class 'socket.error'>([Errno 111] Connection refused) 22:57:39 INFO | autoserv| Retrying in 1.405212 seconds... 22:57:41 INFO | autoserv| XMLRPC server started successfully. 22:57:49 INFO | autoserv| device type: LE_MOUSE 22:57:50 INFO | autoserv| device name: Adafruit Bluefruit LE 22:57:50 INFO | autoserv| address: C0:03:01:81:34:7E 22:57:50 INFO | autoserv| pin: None 22:57:50 INFO | autoserv| class of service: None 22:57:50 INFO | autoserv| class of device: None 22:57:51 INFO | autoserv| device type: MOUSE 22:57:51 INFO | autoserv| authentication mode: SSP_JUST_WORK 22:57:51 INFO | autoserv| serial port: /dev/ttyUSB0 22:57:51 INFO | autoserv| 22:57:51 INFO | autoserv| [*** passed: test_reset_on_adapter] 22:57:51 INFO | autoserv| [*** passed: test_pairable] 22:57:56 INFO | autoserv| test_discover_device: 'BluetoothHIDFacadeRemoteAdapter' object has no attribute 'set_discovery_filter' 22:57:56 INFO | autoserv| [*** passed: test_discover_device] 22:58:03 INFO | autoserv| [*** passed: test_pairing] 22:58:08 INFO | autoserv| [*** passed: test_connection_by_adapter] 22:58:09 INFO | autoserv| test_mouse_left_click: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:09 INFO | autoserv| [*** passed: test_mouse_left_click] 22:58:10 INFO | autoserv| test_mouse_right_click: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:10 INFO | autoserv| [*** passed: test_mouse_right_click] 22:58:11 INFO | autoserv| test_mouse_move_in_x: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:11 INFO | autoserv| [*** passed: test_mouse_move_in_x] 22:58:12 INFO | autoserv| test_mouse_move_in_y: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:12 INFO | autoserv| [*** passed: test_mouse_move_in_y] 22:58:14 INFO | autoserv| test_mouse_move_in_xy: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:14 INFO | autoserv| [*** passed: test_mouse_move_in_xy] 22:58:15 INFO | autoserv| test_mouse_scroll_down: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:15 INFO | autoserv| [*** passed: test_mouse_scroll_down] 22:58:16 INFO | autoserv| test_mouse_scroll_up: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:16 INFO | autoserv| [*** passed: test_mouse_scroll_up] 22:58:17 INFO | autoserv| test_mouse_click_and_drag: <Fault 1: "<type 'exceptions.NotImplementedError'>:Not implemented"> 22:58:17 INFO | autoserv| [*** passed: test_mouse_click_and_drag] 22:58:19 INFO | autoserv| [*** passed: test_disconnection_by_adapter] 22:58:20 INFO | autoserv| [*** passed: test_remove_pairing] 22:58:20 INFO | autoserv| === (pass = 1, fail = 0) / total 1 === 22:58:20 INFO | autoserv|
,
Sep 13 2017
,
Sep 13 2017
Thanks. I think this may be partially an issue in my setup, and so I'm investigating.
,
Sep 14 2017
It turns out this is definitely a test-side bug, and almost certainly not part of my changes. I also noticed that this test would pass even when the menus and new tab didn't open, because it would usually activeate a Google Doodle on the new tab page that had sound and interaction instead. It seems like this second part of the bug is that the InputEventRecorder thing doesn't seem effectively check that the input matched what we wanted to get, and that we don't check the browser does something specific because of our input. That second part would tie this test to UI, so it might make sense to have a version with and a version without. What do you think?
,
Sep 20 2017
,
Oct 27 2017
@Joseph, this is the issue I mentioned before. Let's fix this soon!
,
Nov 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/116f62917266b9c1befd96589b3fb91880778c3a commit 116f62917266b9c1befd96589b3fb91880778c3a Author: Joseph Hwang <josephsih@chromium.org> Date: Sun Nov 05 04:49:15 2017 bluetooth: set legal_falsy_values=[] by default to fix faulty test pass When a test_xxxx in bluetooth_adapter_tests.py fails, it returns False. However, due to legal_falsy_values=[0], the test would appear to pass even when it fails. Let's set legal_falsy_values=[] by default to fix the issue. BUG= chromium:764593 TEST=Observe if a faulty test does fail. Change-Id: I4e03209069c0a686f838261711310e58bb822335 Reviewed-on: https://chromium-review.googlesource.com/752785 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Ruchi Jahagirdar <rjahagir@chromium.org> [modify] https://crrev.com/116f62917266b9c1befd96589b3fb91880778c3a/server/cros/bluetooth/bluetooth_adapter_tests.py
,
Nov 5 2017
Hi Ruchi, could you help verify if the issue is resolved? Thanks!
,
Nov 8 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by alent@google.com
, Sep 13 2017One more log showing that failures happen, but the tests pass anyway: 14:11:32 INFO | autoserv| XMLRPC server started successfully. 14:11:32 INFO | autoserv| Start Chrome with default arguments and extra browser args None... 14:12:04 INFO | autoserv| Installing autotest on 10.10.10.1 14:12:04 INFO | autoserv| Using installation dir /usr/local/autotest 14:12:04 INFO | autoserv| Could not install autotest using the packaging system: No repos to install an autotest client from. Trying other methods 14:12:04 INFO | autoserv| Installation of autotest completed from /build/veyron_minnie/usr/local/build/autotest/client/ 14:12:04 INFO | autoserv| Installing updated global_config.ini. 14:12:04 INFO | autoserv| Waiting 60 seconds for XMLRPC server to start. 14:12:04 INFO | autoserv| <class 'socket.error'>([Errno 111] Connection refused) 14:12:04 INFO | autoserv| Retrying in 0.770072 seconds... 14:12:05 INFO | autoserv| XMLRPC server started successfully. 14:12:18 INFO | autoserv| device type: MOUSE 14:12:18 INFO | autoserv| device name: RNBT-9E9B 14:12:19 INFO | autoserv| address: 00:06:66:7C:9E:9B 14:12:19 INFO | autoserv| pin: 0000 14:12:19 INFO | autoserv| class of service: 0x0000 14:12:19 INFO | autoserv| class of device: 0x0580 14:12:20 INFO | autoserv| device type: MOUSE 14:12:20 INFO | autoserv| authentication mode: PIN_CODE 14:12:20 INFO | autoserv| serial port: /dev/ttyUSB0 14:12:20 INFO | autoserv| 14:12:21 INFO | autoserv| [*** passed: test_reset_on_adapter] 14:12:21 INFO | autoserv| [*** passed: test_pairable] 14:12:26 INFO | autoserv| test_discover_device: 'BluetoothHIDFacadeRemoteAdapter' object has no attribute 'set_discovery_filter' 14:12:26 INFO | autoserv| [*** passed: test_discover_device] 14:12:31 INFO | autoserv| [*** passed: test_pairing] 14:12:36 INFO | autoserv| [*** passed: test_connection_by_adapter] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_left_click: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_left_click] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_right_click: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_right_click] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_move_in_x: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_move_in_x] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_move_in_y: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_move_in_y] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_move_in_xy: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_move_in_xy] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_scroll_down: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_scroll_down] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_scroll_up: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_scroll_up] 14:12:36 INFO | autoserv| Failed RPC 'input.initialize_input_recorder'(('RNBT-9E9B',), {}) with status [<type 'exceptions.Exception'>]. 14:12:36 INFO | autoserv| test_mouse_click_and_drag: RPC error: input.initialize_input_recorder 14:12:36 INFO | autoserv| Traceback (most recent call last): 14:12:36 INFO | autoserv| File "./multimedia_xmlrpc_server.py", line 92, in _dispatch 14:12:36 INFO | autoserv| return func(*params) 14:12:36 INFO | autoserv| File "/usr/local/autotest/cros/multimedia/input_facade_native.py", line 34, in initialize_input_recorder 14:12:36 INFO | autoserv| self.recorder = input_event_recorder.InputEventRecorder(device_name) 14:12:36 INFO | autoserv| File "/usr/local/autotest/bin/input/input_event_recorder.py", line 157, in __init__ 14:12:36 INFO | autoserv| raise InputEventRecorderError(err_msg) 14:12:36 INFO | autoserv| InputEventRecorderError: Failed to find the device node of RNBT-9E9B 14:12:36 INFO | autoserv| 14:12:36 INFO | autoserv| [*** passed: test_mouse_click_and_drag] 14:12:36 INFO | autoserv| [*** passed: test_disconnection_by_adapter] 14:12:36 INFO | autoserv| [*** passed: test_remove_pairing] 14:12:36 INFO | autoserv| === (pass = 1, fail = 0) / total 1 ===