New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764584 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 767680
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Lock screen pods not visible after opening lid, cannot unlock device

Project Member Reported by jamescook@chromium.org, Sep 13 2017

Issue description

Google Chrome	61.0.3163.80 (Official Build) beta (64-bit)
Platform	9765.53.0 (Official Build) beta-channel samus

Corp chromebook with "show lock screen when waking from sleep" enabled by policy.

Twice in the last few weeks I've closed the lid, done something else for a while, opened the lid, and seen the screen below. The status area is visible and works, but the login pods are not visible. All I can do is sign out.

I think once I was able to sign in by blindly typing my password, but I'm not 100% sure.

I vaguely recall a similar problem from ~6 years ago where there was some kind of ordering problem with the lock screen or wallpaper layers/containers. I wonder if there's a race where the lock screen doesn't get properly reparented.

Sorry to assign a bug with no repro, but it seems pretty bad when it happens.

 
Screenshot 2017-09-12 at 4.52.02 PM.png
693 KB View Download
Cc: omrilio@chromium.org
I have also experienced this on samus.
Feedback report for missing login screen UI: 
http://feedback/#/Report/73123158740

I was able to type by password, press enter, and login without the fields being visible.

Other times, I notice that the login screen take a while to render after I lock my device.  I use the lock screen short cut and see a black screen for a few seconds until the ui renders.
Cc: alemate@chromium.org
alemate@, is this related to the issue you mentioned yesterday?
Cc: warx@chromium.org
If not I suspect this is related to the lock screen animation changes by warx@.

Comment 5 by warx@chromium.org, Sep 14 2017

I am not sure how this could happen. On m61, tablet power button and suspend (lid closed in this case) will do immediate animation for hiding non lock screen containers and shelf. Start from m62, post lock animation for the above two cases are also immediate.

It looks like in this case, lock screen containers (showing up in post lock animation) are not brought up?
Cc: abodenha@chromium.org derat@chromium.org
Labels: ReleaseBlock-Stable
+derat, abodenha. +Release-block as it seems pretty bad and more than one person is seeing it. abodenha, feel free to remove if you disagree.

I just saw this again. I left my Pixel with the lid open and went away for a while. When I came back the screen was dark. I tapped shift to wake the machine. It came on with status area visible, wifi icon animating (attempting to reacquire I presume), and no login pods.

I was able to unlock the screen by typing my password blindly.

Feedback http://feedback/#/Report/73196604348

Could there be a difference between lid-close/open sleep vs. lid-open timeout sleep?

One other thought: Is it possible that some part of screen lock involves chrome sending a mojo message to ash, which then races with some other part of the lock/sleep process that either uses posted tasks or talks to dbus?

Chrome logs[1] seem fine, but there is a display reconfiguration. I'm not sure if that's typical procedure - I'll check tomorrow.

I'm assuming you were able to login by blindly typing your password?

1: https://paste.googleplex.com/4753384867364864
There were a lot of these messages in the logs as well (outside of just the lock screen section):

  [23106:23106:0914/175112.584668:WARNING:render_frame_host_impl.cc(2602)] OnDidStopLoading was called twice.

If you were not able to login via keyboard I could imagine login loading being stopped which would result in the blank UI - but since you could login I assume it finished successfully.
There recently was an issue like this (see issue 764190).
So if there are errors like:

:ERROR:gl_image_native_pixmap.cc(240)] Failed to flush rendering

it's it.
Unfortunately I don't see any log messages along those lines
Cc: zalcorn@chromium.org
I believe this was due to a Chrome bug which was fixed already.
Alemate@ was looking into it a few days ago. 

See #10 - #11.

Comment 14 by r...@chromium.org, Sep 15 2017

Cc: r...@chromium.org
There are some CONSOLE:ERROR messages in the logs which I believe are harmless, but I've uploaded [1] to fix the setOverlayColors one. Maybe 99% of the time the error message is harmless but 1% it causes this failure?

If that doesn't fix the issue then I think it is unrelated to login and a failure of some other component.

1: https://chromium-review.googlesource.com/c/chromium/src/+/669397
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c2e2f0e0dfe002eb0a1325c100ffbe2dd0de21d

commit 9c2e2f0e0dfe002eb0a1325c100ffbe2dd0de21d
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Sep 15 21:12:34 2017

cros: Defer setOverlayColors call as login/lock may not be loaded yet.

Bug:  764584 
Change-Id: I359240427c6be20a2576142a7caf8cc12d897edc
Reviewed-on: https://chromium-review.googlesource.com/669397
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502373}
[modify] https://crrev.com/9c2e2f0e0dfe002eb0a1325c100ffbe2dd0de21d/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Labels: Merge-Request-61 Merge-Request-62
Project Member

Comment 18 by sheriffbot@chromium.org, Sep 16 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 19 by ketakid@google.com, Sep 18 2017

Labels: -Merge-Request-61 -Merge-Review-62 Merge-Approved-62 Merge-Approved-61
Approving merge to M61 and M62. Please merge and validate on M62 prior to merge on M61.
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 18 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e2ea1b05706bd91ed6d902ebb4541891d86ed3

commit a3e2ea1b05706bd91ed6d902ebb4541891d86ed3
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Sep 18 18:04:36 2017

cros: Defer setOverlayColors call as login/lock may not be loaded yet.

TBR=jdufault@google.com

(cherry picked from commit 9c2e2f0e0dfe002eb0a1325c100ffbe2dd0de21d)

Bug:  764584 
Change-Id: I359240427c6be20a2576142a7caf8cc12d897edc
Reviewed-on: https://chromium-review.googlesource.com/669397
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502373}
Reviewed-on: https://chromium-review.googlesource.com/671450
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#296}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/a3e2ea1b05706bd91ed6d902ebb4541891d86ed3/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Project Member

Comment 21 by sheriffbot@chromium.org, Sep 21 2017

Cc: ketakid@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 21 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/569555e5ec7275c46473559f0a11a141d7668d5b

commit 569555e5ec7275c46473559f0a11a141d7668d5b
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Sep 21 19:04:00 2017

cros: Defer setOverlayColors call as login/lock may not be loaded yet.

TBR=jdufault@google.com

(cherry picked from commit 9c2e2f0e0dfe002eb0a1325c100ffbe2dd0de21d)

Bug:  764584 
Change-Id: I359240427c6be20a2576142a7caf8cc12d897edc
Reviewed-on: https://chromium-review.googlesource.com/669397
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502373}
Reviewed-on: https://chromium-review.googlesource.com/677475
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1257}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/569555e5ec7275c46473559f0a11a141d7668d5b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

I suspect this is a duplicate of or related to  issue 767680 .
Cc: jdufault@chromium.org
Owner: marc...@chromium.org
This also seems like another case of  issue 758820  (busted GPU rasterization)
Mergedinto: 767680
Status: Duplicate (was: Assigned)

Sign in to add a comment