clang-format produced code that (choose all that apply):
- Doesn't match Chromium style
- Doesn't match blink style
X Riles my finely honed stylistic dander
X No sane human would ever choose
*Note* this is Java code, specific to Java lambda expressions.
Here's the code before formatting:
Callback<AwSafeBrowsingResponse> callback =
response -> ThreadUtils.runOnUiThread(
() -> nativeTakeSafeBrowsingAction(mNativeContentsClientBridge,
response.action(), response.reporting(), requestId));
Here's the code after formatting:
Callback<AwSafeBrowsingResponse> callback = response
-> ThreadUtils.runOnUiThread(
()
-> nativeTakeSafeBrowsingAction(mNativeContentsClientBridge,
response.action(), response.reporting(), requestId));
Here's how it ought to look:
Same as "before formatting."
Code review link for full files/context:
This doesn't prevent uploading, but the formatting looks ridiculous. Let me know if this is WAI.
Comment 1 by ntfschr@chromium.org
, Sep 13 2017