clang-format produced code that (choose all that apply):
X Doesn't match Chromium style
- Doesn't match blink style
- Riles my finely honed stylistic dander
X No sane human would ever choose
*Note* this is Java code, specific to Java lambda expressions.
Here's the code before formatting:
getUserOptInPreference.invoke(null, appContext,
(Callback<Boolean>) optin -> setSafeBrowsingUserOptIn(
optin == null ? false : optin));
Here's the code after formatting:
getUserOptInPreference.invoke(null, appContext,
(Callback<Boolean>)
optin -> setSafeBrowsingUserOptIn(optin == null ? false : optin));
Here's how it ought to look:
Same as "before formatting", or anything else that complies with `git cl presubmit`.
Code review link for full files/context:
After running `git cl presubmit`, I get output like:
android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java:45: 'lambda arguments' has incorrect indentation level 28, expected level should be one of the following: 16, 20.
Not sure if this is a bug with `git cl presubmit` or `git cl format`.
Comment 1 by ntfschr@chromium.org
, Sep 13 2017