New issue
Advanced search Search tips

Issue 764578 link

Starred by 1 user
Status: Fixed
Owner:
thegreenfrog@chromium.org
Closed: Jun 2018
Cc:
eugene...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

☂ CollectionViewController -loadModel should be called from -viewDidLoad, not the initializer

Project Member Reported by pkl@chromium.org, Sep 13 2017 
In several subclasses of CollectionViewController, -loadModel is called from the initializer. This is incorrect. Avoid calling other instance methods during initialization.

This is an umbrella bug to cover all cases where -loadModel is called from initializer instead of from -viewDidLoad.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38aead97ad4950ec591895124fef31b47361c489

commit 38aead97ad4950ec591895124fef31b47361c489
Author: Peter K. Lee <pkl@chromium.org>
Date: Thu Sep 21 16:10:28 2017

Annotate calls to -loadModel from initializer with TODO

Initializer should not call instance methods.

Bug:  764578 
Change-Id: Ideba5fac5df83bc1d22c1b3f3d77b0508e179cab
Reviewed-on: https://chromium-review.googlesource.com/676685
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503459}
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/contextual_search/settings/contextual_search_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/history/history_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/time_range_selector_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
[modify] https://crrev.com/38aead97ad4950ec591895124fef31b47361c489/ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/17c2ac816b608a911fafc774330bcbdf6723938c

commit 17c2ac816b608a911fafc774330bcbdf6723938c
Author: Peter K. Lee <pkl@google.com>
Date: Thu Sep 21 16:38:32 2017

Comment 3 by thegreenfrog@chromium.org, May 18 2018

Owner: thegreenfrog@chromium.org
https://bugs.chromium.org/p/chromium/issues/detail?id=805203 will fix this.

Comment 4 by thegreenfrog@chromium.org, Jun 7 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment