Fix BackdropForSplitScreenTest for mash. |
|||
Issue descriptionThis fails in mash after introducing hidden titlebars. This is because immersive mode in mash creates a mash widget whose parent is also default_container(), so it messes up with the asserts and indexes of this test.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5814c192bc690e6e83f3f55abc52b45a644482f3 commit 5814c192bc690e6e83f3f55abc52b45a644482f3 Author: Sammie Quon <sammiequon@google.com> Date: Thu Sep 28 22:57:26 2017 cros: Reenable BackdropForSplitScreenTest for mash. Previously this was disabled because a change made immersive mode the default for windows in tablet mode. This creates an extra widget whose parent is also default_container(), which messed up some of the indexes used in this test. This cl allows this test to run in mash again. Test: WorkspaceLayoutManagerBackdropTest.BackdropForSplitScreenTest Bug: 764577 Change-Id: Ic36b6252ad543843ab0d71060605674426cf7437 Reviewed-on: https://chromium-review.googlesource.com/688799 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#505201} [modify] https://crrev.com/5814c192bc690e6e83f3f55abc52b45a644482f3/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/5814c192bc690e6e83f3f55abc52b45a644482f3/testing/buildbot/filters/ash_unittests_mash.filter
,
Oct 8 2017
,
Feb 26 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xiy...@chromium.org
, Sep 15 2017Labels: Proj-Mustash-Mash OS-iOS