Currently we disable V8 context snapshot feature ( Issue 617892 ) on some environment because of library dependencies. If we resolve the dependencies, we can enable it again.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5bd96752dd573f5b8d66e628633e158b5d6d87e commit a5bd96752dd573f5b8d66e628633e158b5d6d87e Author: Hitoshi Yoshida <peria@chromium.org> Date: Sun Oct 15 10:11:26 2017 Prepare to replace snapshot_blob.bin with v8_context_snapshot.bin Now all information in snapshot_blob.bin is included in v8_context_snapshot.bin. This CL makes V8 initialization workable with v8_context_snapshot.bin It keeps current speed of launching V8 environment in workers. Bug: 764576 Change-Id: I676dc4305105bfe9c8b71bd73f8c31da53c2ff77 Reviewed-on: https://chromium-review.googlesource.com/714738 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#508957} [modify] https://crrev.com/a5bd96752dd573f5b8d66e628633e158b5d6d87e/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp [modify] https://crrev.com/a5bd96752dd573f5b8d66e628633e158b5d6d87e/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp [modify] https://crrev.com/a5bd96752dd573f5b8d66e628633e158b5d6d87e/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/408412e0d8a40101065482312fe60937496c4dea commit 408412e0d8a40101065482312fe60937496c4dea Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Oct 16 00:52:32 2017 Revert "Prepare to replace snapshot_blob.bin with v8_context_snapshot.bin" This reverts commit a5bd96752dd573f5b8d66e628633e158b5d6d87e. Reason for revert: Speculative revert for Cast Audio Linux breakage. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/5340 Original change's description: > Prepare to replace snapshot_blob.bin with v8_context_snapshot.bin > > Now all information in snapshot_blob.bin is included in v8_context_snapshot.bin. > This CL makes V8 initialization workable with v8_context_snapshot.bin > It keeps current speed of launching V8 environment in workers. > > > Bug: 764576 > Change-Id: I676dc4305105bfe9c8b71bd73f8c31da53c2ff77 > Reviewed-on: https://chromium-review.googlesource.com/714738 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508957} TBR=falken@chromium.org,peria@chromium.org,rmcilroy@chromium.org,nhiroki@chromium.org Change-Id: Ica1f1d1cae967abf076f48188669bf66b0fe619a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764576 Reviewed-on: https://chromium-review.googlesource.com/720417 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#508966} [modify] https://crrev.com/408412e0d8a40101065482312fe60937496c4dea/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp [modify] https://crrev.com/408412e0d8a40101065482312fe60937496c4dea/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp [modify] https://crrev.com/408412e0d8a40101065482312fe60937496c4dea/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a31cce294b183f03bb893f9527aa666594173739 commit a31cce294b183f03bb893f9527aa666594173739 Author: Hitoshi Yoshida <peria@chromium.org> Date: Tue Nov 21 04:03:30 2017 gin: Make gin/ remember external reference table Isolate initialization and snapshot are binded internally, and we need a reference table if we want to create an Isolate from v8_context_snapshot.bin even if no Context objects on the isolate will be created with Context::FromSnapshot. Hence we should handle snapshot files and external reference tables together in gin/. Bug: 764576 Change-Id: I5b6c7019b6ddd9a7f19c03d7c6b8d3ed559fa54c Reviewed-on: https://chromium-review.googlesource.com/778741 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#518102} [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/gin/isolate_holder.cc [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/gin/public/isolate_holder.h [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/third_party/WebKit/Source/bindings/core/v8/V8ContextSnapshot.cpp [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/third_party/WebKit/Source/bindings/core/v8/V8ContextSnapshot.h [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp [modify] https://crrev.com/a31cce294b183f03bb893f9527aa666594173739/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba9c2f0f30fd46eecfb63a9eb7f3a71dfae9ea60 commit ba9c2f0f30fd46eecfb63a9eb7f3a71dfae9ea60 Author: Hitoshi Yoshida <peria@chromium.org> Date: Mon Nov 27 03:11:46 2017 gin: Hide V8 context snapshot behind a build flag We had V8 context snapshot in C++ code regardless V8 settings, but it introduced some complex errors. This CL disables usages of V8 context snapshot if a GN flag "v8_use_external_startup_data" is not true, because V8 context snapshot depends on what is built with the flag. Bug: 764576 Change-Id: If9b1cc497a6f6122f213b83ed2f9746d9af8bb62 Reviewed-on: https://chromium-review.googlesource.com/788631 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#519208} [modify] https://crrev.com/ba9c2f0f30fd46eecfb63a9eb7f3a71dfae9ea60/content/app/content_main_runner.cc [modify] https://crrev.com/ba9c2f0f30fd46eecfb63a9eb7f3a71dfae9ea60/gin/v8_initializer.cc [modify] https://crrev.com/ba9c2f0f30fd46eecfb63a9eb7f3a71dfae9ea60/gin/v8_initializer.h [modify] https://crrev.com/ba9c2f0f30fd46eecfb63a9eb7f3a71dfae9ea60/tools/v8_context_snapshot/v8_context_snapshot.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/162404a5c0b14470cb2a0f32a8857d64ece4266e commit 162404a5c0b14470cb2a0f32a8857d64ece4266e Author: Hitoshi Yoshida <peria@chromium.org> Date: Wed Nov 29 02:12:28 2017 bindings: Change behavior of snapshot with ifdef We changed dynamically if we use a snapshot or not, but for some platforms, they cannot use it statically. This CL makes it strict to usable a snapshot or not, and hence some unit tests do not try to use non-existing snapshots. Bug: 764576 Change-Id: I4dbd013314ece6b97694e7ed4f0d84a59da75843 Reviewed-on: https://chromium-review.googlesource.com/795330 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#519964} [modify] https://crrev.com/162404a5c0b14470cb2a0f32a8857d64ece4266e/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp [modify] https://crrev.com/162404a5c0b14470cb2a0f32a8857d64ece4266e/third_party/WebKit/Source/core/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2dddf21ab7194245aec3888663abe04ad73b12b commit b2dddf21ab7194245aec3888663abe04ad73b12b Author: Hitoshi Yoshida <peria@chromium.org> Date: Wed Nov 29 02:58:29 2017 content: Load V8 context snapshot in content/ Makes unit tests under context/ load V8 context snapshot. This change makes it possible to remove a fall-back routine to use V8's default snapshot file in those tests. Bug: 764576 Change-Id: I2b71ed8264f904a3267e0ff5d8328769e5bc2910 Reviewed-on: https://chromium-review.googlesource.com/795332 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#519979} [modify] https://crrev.com/b2dddf21ab7194245aec3888663abe04ad73b12b/content/public/test/content_test_suite_base.cc [modify] https://crrev.com/b2dddf21ab7194245aec3888663abe04ad73b12b/content/test/BUILD.gn [modify] https://crrev.com/b2dddf21ab7194245aec3888663abe04ad73b12b/content/test/test_blink_web_unit_test_support.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae5d02013e0e22300beb5ec52a268c4deb9a1f5f commit ae5d02013e0e22300beb5ec52a268c4deb9a1f5f Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Dec 07 00:54:48 2017 media: Make media/ work with v8_context_snapshot.bin We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin. This CL makes media/ code to load v8_context_snapshot.bin to work with it. Bug: 789964 , 764576 Change-Id: Idfa5ad0d1407f364430170f485e854413ed8d9f0 Reviewed-on: https://chromium-review.googlesource.com/810326 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#522282} [modify] https://crrev.com/ae5d02013e0e22300beb5ec52a268c4deb9a1f5f/media/blink/BUILD.gn [modify] https://crrev.com/ae5d02013e0e22300beb5ec52a268c4deb9a1f5f/media/blink/run_all_unittests.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d4cc43f5b8dac02b92e1d03ebdff925be31a5b commit e7d4cc43f5b8dac02b92e1d03ebdff925be31a5b Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Dec 07 23:31:24 2017 services: Make services/ work with v8_context_snapshot.bin We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin. This CL makes services/ code to load v8_context_snapshot.bin to work with it. Bug: 789964 , 764576 Change-Id: I13da27dea66210e6b68424fbd7b9baeb8a94452e Reviewed-on: https://chromium-review.googlesource.com/810349 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#522611} [modify] https://crrev.com/e7d4cc43f5b8dac02b92e1d03ebdff925be31a5b/services/data_decoder/BUILD.gn [modify] https://crrev.com/e7d4cc43f5b8dac02b92e1d03ebdff925be31a5b/services/data_decoder/image_decoder_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f07e903f08d16bf8cdf7fac86ae50f4d9b2d7177 commit f07e903f08d16bf8cdf7fac86ae50f4d9b2d7177 Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Dec 08 00:41:18 2017 net: Make net/ work with v8_context_snapshot.bin We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin. This CL makes net/ code to load v8_context_snapshot.bin to work with it. Bug: 789964 , 764576 Change-Id: Ifcbe58d632dd76fd4bcc02182044d1e111f4267a Reviewed-on: https://chromium-review.googlesource.com/810347 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#522648} [modify] https://crrev.com/f07e903f08d16bf8cdf7fac86ae50f4d9b2d7177/net/BUILD.gn [modify] https://crrev.com/f07e903f08d16bf8cdf7fac86ae50f4d9b2d7177/net/proxy/proxy_resolver_v8.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/231de835ae50977881282c8c7fbbc2a93388d4b6 commit 231de835ae50977881282c8c7fbbc2a93388d4b6 Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Dec 08 01:06:33 2017 gin: Set V8 context snapshot as a default snapshot Thanks to the change in V8 to make external reference table optional, we can always use v8_context_snapshot.bin on platforms where it is avaiable. This CL sets the file as the default snapshot blob, and removes setting snapshot in Isolate::CreateParam. Bug: 764576, 789964 Change-Id: I16654eef810efcd0103e9a29659f4616c61f790b Reviewed-on: https://chromium-review.googlesource.com/802654 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522662} [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/BUILD.gn [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/isolate_holder.cc [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/public/isolate_holder.h [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/shell/gin_main.cc [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/shell_runner_unittest.cc [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/test/file_runner.cc [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/test/v8_test.cc [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/gin/v8_initializer.cc [modify] https://crrev.com/231de835ae50977881282c8c7fbbc2a93388d4b6/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
Note: yzshen@ found that https://chromium-review.googlesource.com/802654 caused Issue 793480 .
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e7eb050792f146187cafb4e3122a1f4d99f5ee3 commit 1e7eb050792f146187cafb4e3122a1f4d99f5ee3 Author: Robert Liao <robliao@chromium.org> Date: Fri Dec 15 00:30:05 2017 Revert "gin: Set V8 context snapshot as a default snapshot" This reverts commit 231de835ae50977881282c8c7fbbc2a93388d4b6. Reason for revert: This change seems to break per-build bisects on Windows. Command run: python bisect_builds.py -o -a win64 -g 64.0.3282.24 -b 65.0.3294.0 -p S:\src\bisect\profile --use-local-cache Result: You are probably looking for a change made after 522661 (known good), but no later than 522662 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/bf8135d0bce64496b872062a07b427ddff825ec5..231de835ae50977881282c8c7fbbc2a93388d4b6 Original change's description: > gin: Set V8 context snapshot as a default snapshot > > Thanks to the change in V8 to make external reference table optional, > we can always use v8_context_snapshot.bin on platforms where it is > avaiable. > > This CL sets the file as the default snapshot blob, and removes > setting snapshot in Isolate::CreateParam. > > > Bug: 764576, 789964 > Change-Id: I16654eef810efcd0103e9a29659f4616c61f790b > Reviewed-on: https://chromium-review.googlesource.com/802654 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522662} TBR=peria@chromium.org,rmcilroy@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 764576, 789964 Change-Id: Ibe8ddd99b86fd00c2c2586645350401896c49084 Reviewed-on: https://chromium-review.googlesource.com/827705 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#524261} [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/BUILD.gn [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/isolate_holder.cc [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/public/isolate_holder.h [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/shell/gin_main.cc [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/shell_runner_unittest.cc [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/test/v8_test.cc [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/gin/v8_initializer.cc [modify] https://crrev.com/1e7eb050792f146187cafb4e3122a1f4d99f5ee3/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f84dd03781e2df91f343e3474a65e05edd3f7ac7 commit f84dd03781e2df91f343e3474a65e05edd3f7ac7 Author: Hitoshi Yoshida <peria@chromium.org> Date: Wed Dec 20 08:03:17 2017 Revert "net: Make net/ work with v8_context_snapshot.bin" This reverts commit f07e903f08d16bf8cdf7fac86ae50f4d9b2d7177. Reason for revert: This CL makes net/ depend on Blink, and it makes build time of net/ very long. Original change's description: > net: Make net/ work with v8_context_snapshot.bin > > We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin. > This CL makes net/ code to load v8_context_snapshot.bin to work with it. > > Bug: 789964 , 764576 > Change-Id: Ifcbe58d632dd76fd4bcc02182044d1e111f4267a > Reviewed-on: https://chromium-review.googlesource.com/810347 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522648} TBR=peria@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789964 , 764576, 794234 Change-Id: I1e92c339914a6e2b1f33d280e4b41207213688b9 Reviewed-on: https://chromium-review.googlesource.com/836247 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#525286} [modify] https://crrev.com/f84dd03781e2df91f343e3474a65e05edd3f7ac7/net/BUILD.gn [modify] https://crrev.com/f84dd03781e2df91f343e3474a65e05edd3f7ac7/net/proxy/proxy_resolver_v8.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d963b389afe33d3b40f96ab47ee8ec81fa4daca5 commit d963b389afe33d3b40f96ab47ee8ec81fa4daca5 Author: Hitoshi Yoshida <peria@chromium.org> Date: Wed Jan 24 05:49:16 2018 cleanup: clean up v8_context_snapshot.gni V8 context snapshot feature is enabled on complex conditions. This CL make the flag clear what can be opt-in/opt-out and what can't be controlled. Bug: 764576, 794838 Change-Id: Ie531a5fa689bfed5b6c02906124ba68bd503411b Reviewed-on: https://chromium-review.googlesource.com/882624 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#531447} [modify] https://crrev.com/d963b389afe33d3b40f96ab47ee8ec81fa4daca5/tools/v8_context_snapshot/v8_context_snapshot.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89ddfed197042f2134d9c9df79f187ab90c1a579 commit 89ddfed197042f2134d9c9df79f187ab90c1a579 Author: Hitoshi Yoshida <peria@chromium.org> Date: Wed Jan 24 16:17:38 2018 Clean-up: GN files cleanup under chrome/ Removes redundant descriptions about v8_context_snapshot from GN files under chrome/ Bug: 764576 Change-Id: Ie4879e6f9509ec5d37331b5a4690ccae8fc19f3f Reviewed-on: https://chromium-review.googlesource.com/882782 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#531544} [modify] https://crrev.com/89ddfed197042f2134d9c9df79f187ab90c1a579/chrome/BUILD.gn [modify] https://crrev.com/89ddfed197042f2134d9c9df79f187ab90c1a579/chrome/installer/mini_installer/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b821ff139a2b962d444eb1fd162407650fc2a45c commit b821ff139a2b962d444eb1fd162407650fc2a45c Author: Scott Graham <scottmg@chromium.org> Date: Tue Jan 30 19:29:02 2018 fuchsia: Disable use_v8_context_snapshot Causing extra long compiles, and is currently of limited utility on Fuchsia. We might want to investigate the runtime performance delta for this feature once more complex JS is running on Fuchsia. Bug: 764576, 807320 Change-Id: Iefee81a7e9078b42b68766f6891bbed2233a6599 Reviewed-on: https://chromium-review.googlesource.com/893427 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#532989} [modify] https://crrev.com/b821ff139a2b962d444eb1fd162407650fc2a45c/tools/v8_context_snapshot/v8_context_snapshot.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da05d1e22427781b54d53ccc1d85a65b3c6ef714 commit da05d1e22427781b54d53ccc1d85a65b3c6ef714 Author: Hitoshi Yoshida <peria@chromium.org> Date: Tue Feb 06 07:49:07 2018 bindings: Flip defalut settings of V8ContextSnapshot We ran a Finch experiment to measure the impact to create V8 contexts from snapshot, and we got a good result from it. And we sent "Intent to ship"[1] and got no objections for a week. Now it's time to enable it by default. [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/llHBIsHBb8M Bug: 764576, 760875 Change-Id: I14d0658bcaf50e74b020b101ae3d221f28248ece Reviewed-on: https://chromium-review.googlesource.com/903523 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#534654} [modify] https://crrev.com/da05d1e22427781b54d53ccc1d85a65b3c6ef714/content/child/runtime_features.cc [modify] https://crrev.com/da05d1e22427781b54d53ccc1d85a65b3c6ef714/content/public/common/content_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31b8b4658644400222e359db415fb241c511ab76 commit 31b8b4658644400222e359db415fb241c511ab76 Author: Hitoshi Yoshida <peria@chromium.org> Date: Tue Feb 27 22:13:48 2018 bindings: Prepare V8ContextSnapshot on Android This CL makes it possible to create and use V8 context snapshot files on Android, if a developer puts "use_v8_context_snapshot=true" The V8 context snapshot feature is currently supported and enabled on Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment showed 20% reduction of time to create V8 contexts. On local Android machine, this feature shows 50% time recution. Beside it, in order to enable the feature on cross-build platforms like Android, we have to build Blink twice. So this CL does not flip the flag |use_v8_context_snapshot|. FYI, some numbers with the feature are written in the next CL; https://chromium-review.googlesource.com/c/chromium/src/+/923623 TBR=rockot Bug: 764576 Change-Id: I7ee8a26d350b65b196854fc9209a52fb607b580d Reviewed-on: https://chromium-review.googlesource.com/923683 Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#539558} [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/android_webview/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/android_webview/lib/aw_main_delegate.cc [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/android_webview/test/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/android_webview/tools/apk_merger.py [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/chrome/android/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/chrome/browser/about_flags.cc [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/chrome/test/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/components/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/content/public/app/mojo/content_utility_manifest.json [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/content/public/app/mojo/context_snapshot_manifest.json [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/content/public/app/mojo/snapshot_blob_manifest.json [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/content/shell/android/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/content/test/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/gin/v8_initializer.cc [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/gin/v8_initializer.h [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/media/blink/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/services/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/tools/v8_context_snapshot/BUILD.gn [modify] https://crrev.com/31b8b4658644400222e359db415fb241c511ab76/url/features.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e86e465cd0a4d927252886088c27c4b77d9dc1c9 commit e86e465cd0a4d927252886088c27c4b77d9dc1c9 Author: Eric Stevenson <estevenson@chromium.org> Date: Wed Feb 28 19:59:20 2018 Revert "bindings: Prepare V8ContextSnapshot on Android" This reverts commit 31b8b4658644400222e359db415fb241c511ab76. Reason for revert: Breaks downstream apk merging (https://crbug.com/817288) Original change's description: > bindings: Prepare V8ContextSnapshot on Android > > This CL makes it possible to create and use V8 context snapshot > files on Android, if a developer puts "use_v8_context_snapshot=true" > > The V8 context snapshot feature is currently supported and enabled on > Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment > showed 20% reduction of time to create V8 contexts. > On local Android machine, this feature shows 50% time recution. > > Beside it, in order to enable the feature on cross-build platforms > like Android, we have to build Blink twice. > So this CL does not flip the flag |use_v8_context_snapshot|. > > FYI, some numbers with the feature are written in the next CL; > https://chromium-review.googlesource.com/c/chromium/src/+/923623 > > > TBR=rockot > > Bug: 764576 > Change-Id: I7ee8a26d350b65b196854fc9209a52fb607b580d > Reviewed-on: https://chromium-review.googlesource.com/923683 > Reviewed-by: Cait Phillips <caitkp@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539558} TBR=michaelbai@chromium.org,caitkp@chromium.org,peria@chromium.org,kinuko@chromium.org,xhwang@chromium.org,nyquist@chromium.org,rmcilroy@chromium.org,rockot@chromium.org,haraken@chromium.org,mkwst@chromium.org Change-Id: Ifc644f2fdffbbdad3607e6eb0e867f283e80ff68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764576, 817288 Reviewed-on: https://chromium-review.googlesource.com/941387 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#539937} [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/android_webview/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/android_webview/lib/aw_main_delegate.cc [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/android_webview/test/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/android_webview/tools/apk_merger.py [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/chrome/android/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/chrome/browser/about_flags.cc [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/chrome/test/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/components/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/content/public/app/mojo/content_utility_manifest.json [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/content/public/app/mojo/context_snapshot_manifest.json [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/content/public/app/mojo/snapshot_blob_manifest.json [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/content/shell/android/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/content/test/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/gin/v8_initializer.cc [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/gin/v8_initializer.h [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/media/blink/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/services/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/tools/v8_context_snapshot/BUILD.gn [modify] https://crrev.com/e86e465cd0a4d927252886088c27c4b77d9dc1c9/url/features.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06697237ecca497cbb720e9a7687d4285ef58d25 commit 06697237ecca497cbb720e9a7687d4285ef58d25 Author: Hitoshi Yoshida <peria@chromium.org> Date: Mon Mar 05 04:09:15 2018 Reland: bindings: Prepare V8ContextSnapshot on Android REASON OF RELAND: The issue was out of Chromium repository, and run on only Chrome official build. Hence I revert the chagne in merger.py, not to check v8_context_snapshot.bin. Original CL is https://chromium-review.googlesource.com/c/chromium/src/+/923683 This CL makes it possible to create and use V8 context snapshot files on Android, if a developer puts "use_v8_context_snapshot=true" The V8 context snapshot feature is currently supported and enabled on Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment showed 20% reduction of time to create V8 contexts. On local Android machine, this feature shows 50% time recution. Beside it, in order to enable the feature on cross-build platforms like Android, we have to build Blink twice. So this CL does not flip the flag |use_v8_context_snapshot|. FYI, some numbers with the feature are written in the next CL; https://chromium-review.googlesource.com/c/chromium/src/+/923623 TBR=caitkp,kuniko,nyquist,rockot,haraken,mkwst Bug: 764576, 817288 Change-Id: Id819aa2d4762e04bd7a9b4f700603d89ee0fe5dd Reviewed-on: https://chromium-review.googlesource.com/945248 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#540780} [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/android_webview/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/android_webview/lib/aw_main_delegate.cc [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/android_webview/test/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/chrome/android/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/chrome/browser/about_flags.cc [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/chrome/test/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/components/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/content/public/app/mojo/content_utility_manifest.json [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/content/public/app/mojo/context_snapshot_manifest.json [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/content/public/app/mojo/snapshot_blob_manifest.json [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/content/shell/android/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/content/test/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/gin/v8_initializer.cc [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/gin/v8_initializer.h [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/media/blink/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/services/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/tools/v8_context_snapshot/BUILD.gn [modify] https://crrev.com/06697237ecca497cbb720e9a7687d4285ef58d25/url/features.gni
Comment 1 by peria@chromium.org
, Sep 13 2017