New issue
Advanced search Search tips

Issue 764574 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

If captive portal detection ping returns ERR_PROXY_CERTIFICATE_INVALID, suggest the user to try again in incognito or guest mode

Project Member Reported by mea...@chromium.org, Sep 13 2017

Issue description

ERR_PROXY_CERTIFICATE_INVALID on a captive portal ping is likely to happen when the user is using a proxy with SSL support, and is behind a captive portal.

This is why BeyondCorp breaks captive portal detection: It sets a proxy and the captive portal ping results in ERR_PROXY_CERTIFICATE_INVALID, which then gets ignored by CaptivePortalDetector.

I'm thinking we should let the user know that they might be able to login if they disable the proxy. For example, on an SSL interstitial, we can tell them to try logging in incognito (assuming the proxy is set by an extension, which we might be able to detect) or in guest mode.

mmenke: As the owner of captive portal detection, wdyt about this?
 

Comment 1 by mmenke@chromium.org, Sep 13 2017

How often are proxies set only in non-incognito by extensions?  Sounds like a niche use case to me - I assume more corporations that set mandatory proxies set them to be mandatory in incognito, too (Also...logging into what in incognito?  If you aren't using a proxy in incognito, what is there to log into?)

Comment 2 by mmenke@chromium.org, Sep 13 2017

Components: -Internals>Network Internals>Network>Certificate Internals>Network>Proxy
Punting this out of the Internals>Network queue.

Comment 3 by mea...@chromium.org, Sep 13 2017

> If you aren't using a proxy in incognito, what is there to log into?)

Login to the captive portal.

I don't have any data about extensions setting proxies in non-incognito, but at least BeyondCorp does it. It is niche, but currently it seems to be preventing our corp machines from detecting portals so at least it'll help with that.

Comment 4 by mmenke@chromium.org, Sep 13 2017

Oh, right, logging into the portal.  Anyhow, unless there's evidence this is a common enterprise use case, not a fan of adding logic for it.
Components: -Internals>Network>Certificate
Bumping this out of the Certificate queue. This is about how Chrome code responds to invalid certificates, more than about suggesting we change how we validate those certificates / that we accept them.
Curious: Are proxies that support HTTPS-to-the-proxy common? I'd never seen one until joined Google. 

Comment 7 by mmenke@chromium.org, Sep 19 2017

rsleevi:  Late response, but aren't the certificate error interstitials
(Which live in chrome/ssl, I think?) considered part of the certificate
component?

Comment 8 by mea...@chromium.org, Sep 19 2017

Also late response:

Comment #4: The logic for this will be in the interstitials code where we have custom logic for different scenarios including bad clock, captive portals, mitm softwares etc. The only change on the captive portal side is to pass the net error in CaptivePortalDetector::Results. Would you be okay with adding that?

UMA says that this error is pretty rare, but I suspect there is a bias there: In the cases where this error would happen (behind a captive portal), UMA wouldn't be able to report the error.

Comment 9 by vakh@chromium.org, Sep 26 2017

Owner: mea...@chromium.org
Status: Assigned (was: Untriaged)
meacer@ -- Assigning this to you since you know where the fix will go, if needed.
-Enamel Sheriff

Re #c8:
> UMA wouldn't be able to report the error.
Only as long as the machine is always behind a captive portal, no?
Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment