nytimes story seems to be broken |
||||
Issue descriptionsystem_health.memory_desktop failing on 6 builders Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf - Mac Pro 10.11 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Pro%2010.11%20Perf - Mac Retina Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf - Win 10 High-DPI Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf - Win 10 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf - Win 7 Nvidia GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf v8.runtimestats.browsing_desktop failing on 6 builders Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf - Win 10 High-DPI Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf - Win 10 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf - Win 7 ATI GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf - Win 7 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf - Win 8 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf Looks like nytimes story is failing on most of these platforms. I'm not sure if I should disable or not; can someone take a look? Some example tasks https://chromium-swarm.appspot.com/task?id=388f6f26de2c1910&refresh=10&show_raw=1 https://chromium-swarm.appspot.com/task?id=388d3b819a6a2a10&refresh=10&show_raw=1 https://chromium-swarm.appspot.com/task?id=388f3e9843ae8210&refresh=10&show_raw=1
,
Sep 13 2017
First failure range: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf/builds/1343 I will kick off a bisect.
,
Sep 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8968611409252857376
,
Sep 13 2017
=== BISECT JOB RESULTS === NO Test failure found Bisect Details Configuration: winx64_10_perf_bisect Benchmark : system_health.memory_desktop Metric : memory:chrome:all_processes:dump_count:background_avg/browse_news/browse_news_nytimes Revision Exit Code N chromium@500826 1 +- N/A 20 good chromium@500848 1 +- N/A 20 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.nytimes system_health.memory_desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8968611409252857376 For feedback, file a bug with component Speed>Bisection
,
Sep 13 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8968563616263661776
,
Sep 13 2017
The link in #4 (great to have this now!) shows even earlier failures. Kicked off a bisect with a larger range.
,
Sep 13 2017
=== BISECT JOB RESULTS === NO Test failure found Bisect Details Configuration: winx64_10_perf_bisect Benchmark : system_health.memory_desktop Metric : memory:chrome:all_processes:dump_count_avg/browse_news/browse_news_cnn Revision Exit Code N chromium@500300 0 +- N/A 20 good chromium@500826 0 +- N/A 20 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.cnn system_health.memory_desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8968563616263661776 For feedback, file a bug with component Speed>Bisection
,
Sep 14 2017
Dave: can we try to use pinpoint to bisect this failure?
,
Sep 14 2017
Sure, it would make a good test case for functional bisect. Can you kick one off from the dashboard for MacBook Air? (MacBook Pro is a little swamped right now.)
,
Sep 19 2017
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1493463fb80000
,
Sep 19 2017
Manually kicked off a Pinpoint job. Hopefully I got the parameters right!
,
Sep 19 2017
📍 Pinpoint job completed. https://pinpoint-dot-chromeperf.appspot.com/job/1493463fb80000
,
Sep 19 2017
I'm going to double the repeat count to 24.
,
Sep 19 2017
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12909a77b80000
,
Sep 19 2017
📍 Pinpoint job completed. https://pinpoint-dot-chromeperf.appspot.com/job/12909a77b80000 Use a real HTMLVideoElement and Document/Frame in TextTrackListTest By japhet@chromium.org · Fri Sep 08 01:16:05 2017 chromium@8fd1b3cda0a769d3d2273bd246995c70f90535b0
,
Sep 19 2017
japhet@ the bisect found your CL in #16 as the culprit for the flakiness in nytimes test. The crash stack in #1 include TaskRunnerHelper & your CL also touches third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp, so the bisect is likely to be correct. Please take a look as this as it can cause actual Chrome crash to the user.
,
Sep 19 2017
Is this still happening on trunk? That crash stack was a top crasher for a while, but I thought I had resolved it in https://chromium-review.googlesource.com/c/chromium/src/+/663880
,
Sep 19 2017
You may be right, most of the recent run are green: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=system_health.common_desktop%2Fbrowse%3Anews%3Anytimes&testType=system_health.common_desktop
,
Sep 19 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, Sep 13 2017