Split lines in SmokeTests; allow and ignore comment lines. |
||||
Issue descriptionCurrently, the SmokeTests file contents are read as one big string, and a test is considered to be in SmokeTests if the test name appears in the file as a substring... This might potentially lead to some unexpected consequences, e.g. if a/b/c/foo/bar.html is in the file, then b/c/foo/bar.html and foo/bar.html are also considered to be in the file, even if they don't have their own line. https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py?l=934 I would expect the behavior to look at separate lines, and allow comments. Something like: tests = {line.strip() for line in contents.splitlines() if not line.lstrip().startswith('#')} # test is in SmokeTests if it's in this tests set.
,
Sep 13 2017
CL: https://chromium-review.googlesource.com/c/chromium/src/+/665350
,
Sep 13 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6315c77889427fffb84dea412dddc39e6e69b017 commit 6315c77889427fffb84dea412dddc39e6e69b017 Author: Matt Wolenetz <wolenetz@chromium.org> Date: Wed Sep 13 23:10:12 2017 SmokeTests: Allow comments and require Tools OWNERS to review changes To help prevent accidental SmokeTests coverage regressions like that fixed in bug 763528 , this change allows '#' prefixed comments in SmokeTests, and also makes changes to SmokeTests require Tools OWNERS review. BUG= 764556 , 763528 Change-Id: I612fb2b67fbe9f0a99107c1079b79a4b61338944 Reviewed-on: https://chromium-review.googlesource.com/665350 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501783} [modify] https://crrev.com/6315c77889427fffb84dea412dddc39e6e69b017/third_party/WebKit/LayoutTests/OWNERS [modify] https://crrev.com/6315c77889427fffb84dea412dddc39e6e69b017/third_party/WebKit/LayoutTests/SmokeTests [modify] https://crrev.com/6315c77889427fffb84dea412dddc39e6e69b017/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
,
Sep 14 2017
#4 should fix this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by wolenetz@chromium.org
, Sep 13 2017Owner: wolenetz@chromium.org
Status: Started (was: Available)