New issue
Advanced search Search tips

Issue 764538 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: 2020-01-16
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autogenerate the Copyright Year

Project Member Reported by robliao@chromium.org, Sep 12 2017

Issue description

See  http://crbug.com/764528  for the currently manual process.

We should probably just grab the year from the build time and apply it to the BRANDING file.
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 13

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Infra>Client>Chrome
Cc: dpranke@chromium.org jbudorick@chromium.org
Status: Available (was: Untriaged)
Marking as available; this is low priority, but kinda belongs on our team. We might get to it at some point.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b782de4c453ea804ecdebcdb20002f54f05714ad

commit b782de4c453ea804ecdebcdb20002f54f05714ad
Author: Robert Liao <robliao@chromium.org>
Date: Mon Sep 17 23:07:38 2018

Update Chromium Copyright to 2018

BUG= 764528 ,764538
TBR=oshima@chromium.org
Similar change, different year.

Change-Id: I14edf5c4263a1f4e92eb11828a46805946f69d17
Reviewed-on: https://chromium-review.googlesource.com/1228882
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591863}
[modify] https://crrev.com/b782de4c453ea804ecdebcdb20002f54f05714ad/chrome/app/theme/chromium/BRANDING

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/theme/google_chrome/+/67d992906b772ea5663432205b7d732107ae1a92

commit 67d992906b772ea5663432205b7d732107ae1a92
Author: Robert Liao <robliao@google.com>
Date: Mon Sep 17 21:53:23 2018

NextAction: 2019-01-16
Setting next action to 1/16/2019 for a manual update in the event this bug isn't closed yet.
The NextAction date has arrived: 2019-01-16
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/theme/google_chrome/+/214955bb370ca266415e3f33d7ff0ef7829edf31

commit 214955bb370ca266415e3f33d7ff0ef7829edf31
Author: Robert Liao <robliao@google.com>
Date: Thu Jan 17 00:52:16 2019

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4e5cdafcb7a398b7b161f0a50dbfb5335be78de

commit c4e5cdafcb7a398b7b161f0a50dbfb5335be78de
Author: Robert Liao <robliao@chromium.org>
Date: Thu Jan 17 02:54:45 2019

Update Chromium Copyright to 2019

BUG= 764528 ,764538
TBR=oshima@chromium.org
Similar change, different year.

Change-Id: I370214153fabddfb1f8a8ccbba4513c3f5c97a31
Reviewed-on: https://chromium-review.googlesource.com/c/1416974
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623539}
[modify] https://crrev.com/c4e5cdafcb7a398b7b161f0a50dbfb5335be78de/chrome/app/theme/chromium/BRANDING

Comment 11 by robliao@chromium.org, Jan 17 (6 days ago)

NextAction: 2020-01-16
Setting next action to 1/16/2020 for a manual update in the event this bug isn't closed yet.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/416a311cf664528865ba8e0e16bfd5fefa5252e3

commit 416a311cf664528865ba8e0e16bfd5fefa5252e3
Author: Robert Liao <robliao@chromium.org>
Date: Thu Jan 17 19:36:01 2019

Remove Old Scripts That Directly or Indirectly Reference the BRANDING File

BUG=764538

Change-Id: I43b81a04dae4a137a9376916924ceebc14475859
Reviewed-on: https://chromium-review.googlesource.com/c/1416835
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623797}
[delete] https://crrev.com/d472e1cf167ba3df10a7f25f701f739bb041eedb/build/branding_value.sh
[delete] https://crrev.com/d472e1cf167ba3df10a7f25f701f739bb041eedb/chrome/tools/build/mac/build_app_dmg

Sign in to add a comment