expand disjoint_timer_query Adreno blacklist |
|||||||||
Issue descriptionThis is a followup to issue 750306 "glGetQueryObject(GL_QUERY_RESULT_AVAILABLE) blocks unexpectedly" . The workaround was to blacklist disjoint timer queries for Adreno 530 specifically. However, according to Qualcomm in b/64534470 this problem can happen on "all A4x (or newer) chips". Since this primarily seems to cause slowdown for WebVR on Daydream-ready devices, it should be sufficient to cover those GPUs specifically instead of blacklisting for all Adreno 4xx/5xx. Currently, all Daydream-ready devices use either Adreno 530 or 540. (Or Mali which is a separate driver and not covered by this blacklist.) FYI, Adreno 3.* and 4.* are already blacklisted due to other pre-existing driver issues: { "id": 112, "cr_bugs": [477514], "description": "EXT_disjoint_timer_query fails after 2 queries on adreno 3xx in lollypop", "os": { "type": "android", "version": { "op": ">=", "value": "5.0.0" } }, "gl_vendor": "Qualcomm.*", "gl_renderer": "Adreno \\(TM\\) 3.*", "features": [ "disable_timestamp_queries" ] }, { "id": 113, "cr_bugs": [477514], "description": "EXT_disjoint_timer_query fails after 256 queries on adreno 4xx", "os": { "type": "android" }, "gl_renderer": "Adreno \\(TM\\) 4.*", "disabled_extensions": [ "GL_EXT_disjoint_timer_query" ] },
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfcd205695a30d57bbea2cd97aba08853f0b0a00 commit dfcd205695a30d57bbea2cd97aba08853f0b0a00 Author: Klaus Weidner <klausw@chromium.org> Date: Wed Sep 13 00:02:11 2017 Add Adreno 540 to disjoint_timer_query blacklist According to Qualcomm the unexpected blocking issue likely affects "all A4x (or newer) chips", though the specific effect only seems to be noticeable for WebVR on Daydream-ready devices which are currently limited to Adreno 530 and 540. BUG= 750306 , 764526 R=kbr Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifb95ed9a59f58fb7b4a3c91e3745f5def6b51d21 Reviewed-on: https://chromium-review.googlesource.com/662903 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501463} [modify] https://crrev.com/dfcd205695a30d57bbea2cd97aba08853f0b0a00/gpu/config/gpu_driver_bug_list.json
,
Sep 14 2017
Klaus, as you've already committed against this bug, assigning to you and marking "Started". You have this as a P3, but tagged as M-62. Which of those is false?
,
Sep 14 2017
cjgrant@, thanks for the reminder. Changed to P2 since it would be good to have this in M62 - it improves the WebVR experience for affected sites and should be a low-risk change (it expands the already implemented blacklist to another GPU), so I'm requesting a merge.
,
Sep 14 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 15 2017
Approved for M62 branch 3202.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3a68de4bf635187625dcbb7e3691f24e33ca491 commit a3a68de4bf635187625dcbb7e3691f24e33ca491 Author: Klaus Weidner <klausw@chromium.org> Date: Fri Sep 15 20:43:45 2017 Add Adreno 540 to disjoint_timer_query blacklist According to Qualcomm the unexpected blocking issue likely affects "all A4x (or newer) chips", though the specific effect only seems to be noticeable for WebVR on Daydream-ready devices which are currently limited to Adreno 530 and 540. (cherry picked from commit dfcd205695a30d57bbea2cd97aba08853f0b0a00) BUG= 750306 , 764526 R=kbr Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifb95ed9a59f58fb7b4a3c91e3745f5def6b51d21 Reviewed-on: https://chromium-review.googlesource.com/662903 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501463} Reviewed-on: https://chromium-review.googlesource.com/669528 Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#260} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a3a68de4bf635187625dcbb7e3691f24e33ca491/gpu/config/gpu_driver_bug_list.json
,
Sep 15 2017
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e152ac2a485d8e9782b88e4d0c96246e20bceb8e commit e152ac2a485d8e9782b88e4d0c96246e20bceb8e Author: Peng Huang <penghuang@chromium.org> Date: Wed Jan 31 17:21:11 2018 Disable GL_EXT_disjoint_timer_query for Nexus5 and Nexus7v2 Disable GL_EXT_disjoint_timer_query for Nexus5 and Nexus7v2, because glGetQueryObject(GL_QUERY_RESULT_AVAILABLE) blocks unexpectedly. Bug: 750306 , 764526 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I752d51c05c26203a759b6c2ded961a84a90cc4cd Reviewed-on: https://chromium-review.googlesource.com/895246 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533307} [modify] https://crrev.com/e152ac2a485d8e9782b88e4d0c96246e20bceb8e/gpu/config/gpu_driver_bug_list.json
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03d9c2d401e533a51b61543d85ed7c80273bff2d commit 03d9c2d401e533a51b61543d85ed7c80273bff2d Author: Klaus Weidner <klausw@chromium.org> Date: Thu Mar 01 22:26:58 2018 Update Adreno GL_EXT_disjoint_timer blacklists The "glGetQueryObject(GL_QUERY_RESULT_AVAILABLE) blocks unexpectedly on Adreno" issue is fixed in Android 8.1, un-blacklist it on that version. According to Qualcomm, the issue affected Adreno 4xx and newer, and penghuang@ also saw it on Adreno 3xx on Android K (4.x). The extension is separately blacklisted by entry id=112 for Adreno 3xx, but only on Android 5.0 and up, so it seems cleanest to apply the blacklist to all of Adreno 3xx/4xx/5xx for the blocking issue. For consistency, also disable GL_EXT_disjoint_timer_query_webgl2 for the pre-existing Adreno blacklist entries. If the underlying calls are broken, this is expected to affect both variants. BUG= 477514 , 750306 , 764526 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iace887cb6e168d691329ff5aaf29634e509ab5c0 Reviewed-on: https://chromium-review.googlesource.com/941549 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#540307} [modify] https://crrev.com/03d9c2d401e533a51b61543d85ed7c80273bff2d/gpu/config/gpu_driver_bug_list.json
,
Mar 1 2018
,
Jul 4
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by klausw@chromium.org
, Sep 12 2017