New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764525 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
█ robhogan@chromium.org
dgro...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTable::TopSection(), BottomSection() sometimes return incorrect value

Project Member Reported by wangxianzhu@chromium.org, Sep 12 2017 
They may return wrong result if the table contains out-of-order thead, tbody and tfoot.

For example, for the following case:
<table>
  <tbody id="tbody"><td>body</td></tbody>
  <thead id="thead"></thead>
</table>
the functions return the following object:
  TopSection(): thead  (as expected)
  BottomSection(): thead  (expected: tbody)
  TopNonEmptySection(): tbody (as expected)
  BottomNonEmptySection(): nullptr (expected: tbody)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c14979722d3761c5449f3ef9f68bd2fee4f82a0

commit 9c14979722d3761c5449f3ef9f68bd2fee4f82a0
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Sep 18 21:38:53 2017

LayoutTable::BottomSection() should return the last rendered table section

Bug:  764525 
Change-Id: I5b784dbd64c96269bca19d12f71c138bd13a32b4
Reviewed-on: https://chromium-review.googlesource.com/670339
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#502681}
[modify] https://crrev.com/9c14979722d3761c5449f3ef9f68bd2fee4f82a0/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/9c14979722d3761c5449f3ef9f68bd2fee4f82a0/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b104b5737c134b4e34a0510109e939b472555f79

commit b104b5737c134b4e34a0510109e939b472555f79
Author: Robert Hogan <robhogan@gmail.com>
Date: Wed Sep 20 06:25:16 2017

Remove unnecessary check and replace with a DCHECK

Follow-up to https://chromium-review.googlesource.com/670339

Bug:  764525 
Change-Id: I66effd1c4e138541719a9071599151c8707334d1
Reviewed-on: https://chromium-review.googlesource.com/673444
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#503070}
[modify] https://crrev.com/b104b5737c134b4e34a0510109e939b472555f79/third_party/WebKit/Source/core/layout/LayoutTable.cpp

Comment 3 by robho...@gmail.com, Sep 26 2017

Status: Fixed (was: Available)
►

Sign in to add a comment