New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764523 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

smoothness.desktop_tough_pinch_zoom_cases failing on 9 builders

Project Member Reported by martiniss@chromium.org, Sep 12 2017

Issue description

https://chromium-swarm.appspot.com/task?id=388f6dfe75c34f10&refresh=10&show_raw=1 is an example task. 

(INFO) 2017-09-12 08:51:41,062 cloud_storage.Insert:377  Uploading c:\b\s\w\itcvknfn\tmpfq9m_u\reports\a380e78e-feea-43f0-a3c7-97d34d9ebb26.dmp to gs://chrome-telemetry-output/minidump-2017-09-12_08-51-41-850397.dmp

is in the output, so it's crashing and there's a minidump. ericrk@ can you take a look?
Cc: rnep...@chromium.org
Actually, I think rnephew might have done this with his CL https://chromium-review.googlesource.com/c/chromium/src/+/617364. Not exactly sure, but it does show up in the first run I can find where it fails.https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf/builds/1091
I just found  bug 762165 . I think this is a separate issue, but I'm not sure exactly.
Yep, looks like it was me. It was only set to run on Mac before, and that CL made it run on everything but mobile.

So, we have two paths forward. One is making it a 'mac only' benchmark by setting SUPPORTED_PLATFORMS = story.expectations.ALL_MAC

or we can just disable it as a failing test on all failing platforms. Since it says 'desktop_tough_pinch_zoom_cases' I'm guessing we dont want it to be a just mac test so path 2?

I'll defer to the benchmark owner (ericrc@) for which path we should go down. (I can actually do it, just need to know which one).
CL going with option #2 up at:
  https://chromium-review.googlesource.com/c/chromium/src/+/665167
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77e0ab61b674038afc9d52606a0aee08fc44f54f

commit 77e0ab61b674038afc9d52606a0aee08fc44f54f
Author: rnephew <rnephew@chromium.org>
Date: Wed Sep 13 20:07:06 2017

[Telemetry] Disable failing smoothness.desktop_tough_pinch_zoom benchmark on windows and linux

Bug:  764523 
Change-Id: I2348d57806be378155c60bd6ff28a0d957918428
Reviewed-on: https://chromium-review.googlesource.com/665167
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#501727}
[modify] https://crrev.com/77e0ab61b674038afc9d52606a0aee08fc44f54f/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/77e0ab61b674038afc9d52606a0aee08fc44f54f/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/77e0ab61b674038afc9d52606a0aee08fc44f54f/tools/perf/benchmarks/smoothness.py

Status: Fixed (was: Available)
Owner: rnep...@chromium.org

Sign in to add a comment