New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764486 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 763253
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mash: All touch input is broken

Project Member Reported by jamescook@chromium.org, Sep 12 2017

Issue description

ToT chrome on link.

Touch doesn’t work at all, in window captions, browser UI, or in-page UI, with chrome --mash.

chrome --mus works fine.

erg, thinks this used to work, so something regressed.

Any ideas? Maybe touch screen just isn't enabled, or events are getting eaten, or coordinate system problems?

Any volunteers to look at this? If not, I can look in a day or two.

 

Comment 1 by sadrul@chromium.org, Sep 13 2017

I am able to use touch correctly with --touch-devices + my mouse on my workstation. So this is probably either the device not getting detected, or not being associated correctly with the right display.
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
I'll take a look.

Touch works at the login screen, but not after sign-in. Does that sound familiar at all? Maybe some pref/setting getting applied that turns it off?

Cc: warx@chromium.org derat@chromium.org
Mergedinto: 763253
Status: Duplicate (was: Started)
I suspect this regressed with some recent changes to how touch screens are enabled wrt the PowerButtonController. In particular I think maybe https://chromium-review.googlesource.com/640551 is related. See  issue 759846 .

In particular, ash::ShellDelegateMus::SetTouchscreenEnabled() is not implemented, and I think that enabling the touch screen is now dependent on ash power controller initialization.

The good news is that warx@ has a CL out for review that eliminates that ShellDelegate method and it fixes the problem.

https://chromium-review.googlesource.com/c/chromium/src/+/662657

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1400a36711fe2f8d473a13121fb7498dec412b0

commit f1400a36711fe2f8d473a13121fb7498dec412b0
Author: Qiang Xu <warx@chromium.org>
Date: Thu Sep 14 02:28:30 2017

mash: remove ToggleTouchpad, Get{Set}TouchscreenEnabled from
ShellDelegate

Changes:
- Create ash::TouchDevicesController to host the removed methods from
ShellDelegate and they talk to ui::InputDeviceControllerClient.
- Move kTouchpadEnabled and kTouchscreenEnabled prefs from chrome to ash.
- Add test coverage for user profile kTouchpadEnabled and
kTouchscreenEnabled. They are triggered by debug accelerator. The
touchscreen global enabled source is already tested in
TabletPowerButtonControllerTest.

Bug:  763253 ,  764486 
Test: device test and added test coverage.
Change-Id: Ic2149132fea3107f2eac217163b166545da5d1c9
Reviewed-on: https://chromium-review.googlesource.com/662657
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501846}
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/BUILD.gn
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/public/cpp/ash_pref_names.h
[delete] https://crrev.com/b9df3441dc4c014462b6d0a29d2ade02abdc9a83/ash/public/cpp/touchscreen_enabled_source.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/session/session_controller.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/session/session_controller.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/shell.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/shell.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/shell_delegate.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/system/power/power_button_display_controller.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/system/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/test_shell_delegate.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/test_shell_delegate.h
[add] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/touch/touch_devices_controller.cc
[add] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/touch/touch_devices_controller.h
[add] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/ash/touch/touch_devices_controller_unittest.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/browser/chromeos/system/input_device_settings.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/browser/chromeos/system/input_device_settings.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/common/pref_names.cc
[modify] https://crrev.com/f1400a36711fe2f8d473a13121fb7498dec412b0/chrome/common/pref_names.h

Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment