New issue
Advanced search Search tips

Issue 764480 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a central place for External Clear Key (ECK) related information

Project Member Reported by xhw...@chromium.org, Sep 12 2017

Issue description

External Clear Key key system is used for testing, and related code spreads in a lot of different places in the code base. However, we don't have a central place to hold information related to ECK (similar to widevine_cdm_common.h). As such, there are some duplicate code and hacks.

For example, we have 8 places defining the ECK key system string [1].

For another example, we have kClearKeyCdmLibraryName defined in cdm_paths.h, which seems hacky [2].

We should add a central place for ECK related information to solve this problem.

[1] https://cs.chromium.org/search/?q=org.chromium.externalclearkey&sq=package:chromium&type=cs

[2] https://cs.chromium.org/search/?q=kClearKeyCdmLibraryName&sq=package:chromium&type=cs
 

Comment 1 by xhw...@chromium.org, Oct 10 2017

Labels: M-64

Comment 2 by xhw...@chromium.org, Nov 14 2017

After talking with jrummell@ offline, moving forward we should make a distinction between "external clear key" and "clear key cdm".

External Clear Key is a special key system (org.chromium.externalclearkey), used for testing. It can be supported by different CDMs on different platforms:
- Desktop: supported by Clear Key CDM.
- Others: supported by running AesDecryptor in a remote process, using MojoCdm.

Clear Key CDM is a library CDM implementation supporting External Clear Key key system on desktop Chrome.

With that, this bug tracks the work to have central places for both the ECK key sytem, and Clear Key CDM.

Comment 3 by xhw...@chromium.org, Nov 14 2017

Labels: -M-64 M-65

Comment 4 by xhw...@chromium.org, Nov 28 2017

Cc: -jrumm...@chromium.org xhw...@chromium.org
Labels: -Pri-3 Pri-2
Owner: jrumm...@chromium.org
Assign to jrummell@ for load balance. Thanks!
Labels: -M-65 M-68
Labels: -Pri-2 -M-68 Hotlist-GoodFirstBug Pri-3
Lowering priority since this is just a code cleanup.

Sign in to add a comment