Issue metadata
Sign in to add a comment
|
Network service: Need to check whether plugin handlers are available for stealing a navigation |
||||||||||||||||||||||
Issue descriptionIn NetworkUrlLoaderNetworkService, we check if the navigation is a download. But Plugin can also intercept the navigation, and it should do that before download does.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1f6f05666d826e2a3755a73fb45902f84c0b9aa commit f1f6f05666d826e2a3755a73fb45902f84c0b9aa Author: Kinuko Yasuda <kinuko@chromium.org> Date: Mon Oct 02 10:03:17 2017 [2nd shot] Suppress NavigationControllerBrowserTest.BackSameDocumentAfterBlockedSubframe on Mojo Linux Looks like crbug.com/764474 . This also redo https://chromium-review.googlesource.com/c/chromium/src/+/694764 as the suppression list was wrong :( TBR=creis@chromium.org NOTRY=true Bug: 764474 Change-Id: I4b181dda7e606b948fd81c6fad5af1085c377c15 Reviewed-on: https://chromium-review.googlesource.com/695361 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#505566} [modify] https://crrev.com/f1f6f05666d826e2a3755a73fb45902f84c0b9aa/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/f1f6f05666d826e2a3755a73fb45902f84c0b9aa/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Oct 2 2017
Quick update: I split issue 770621 back out, since it looks like a different issue than this one.
,
Oct 3 2017
creis@- ah ok, thanks for the follow-up, Chris!
,
Oct 3 2017
Meh- sorry I meant to say Charie. Anyways thanks for the follow-up!
,
Apr 16 2018
,
Apr 18 2018
I was incorrect and this isn't a duplicate.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ebdff864072165fd1f91e0d6c8e081791a85dad commit 3ebdff864072165fd1f91e0d6c8e081791a85dad Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Apr 23 18:57:21 2018 Fix network service loading path not checking if a mime type is handled by a plugin. Bug: 764474 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4b0997299e4780e2f1c20849fe6aa9d10bf81839 Reviewed-on: https://chromium-review.googlesource.com/1013401 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#552775} [modify] https://crrev.com/3ebdff864072165fd1f91e0d6c8e081791a85dad/content/browser/loader/navigation_loader_util.cc [modify] https://crrev.com/3ebdff864072165fd1f91e0d6c8e081791a85dad/content/browser/loader/navigation_loader_util.h [modify] https://crrev.com/3ebdff864072165fd1f91e0d6c8e081791a85dad/content/browser/loader/navigation_url_loader_network_service.cc [modify] https://crrev.com/3ebdff864072165fd1f91e0d6c8e081791a85dad/content/browser/loader/navigation_url_loader_network_service_unittest.cc [modify] https://crrev.com/3ebdff864072165fd1f91e0d6c8e081791a85dad/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Apr 25 2018
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cf99c8bfb8fbc1945a9717bfd6f6f09fc56aee8 commit 5cf99c8bfb8fbc1945a9717bfd6f6f09fc56aee8 Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Apr 26 00:46:05 2018 Enable plugin layout tests that now pass with the network service after r552775. Bug: 764474 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5816500cce7477784e948636e5f5f8a5b48c1062 Reviewed-on: https://chromium-review.googlesource.com/1028976 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553854} [modify] https://crrev.com/5cf99c8bfb8fbc1945a9717bfd6f6f09fc56aee8/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kinuko@chromium.org
, Oct 2 2017