Introduce jar_include_patterns in addition to jar_excluded_patterns |
|||||
Issue descriptionContext: GVR library enabled dynamical java loading for some java classes. This means we no longer need to include a lot of class files in classes.jar file. gn current has jar_exclude_patterns to skip a list of classes from a jar. This works for our use case. But it is tedious to list all classes that we want to exclude. It would be easier if we could instead specify the class files that we want to keep in a jar.
,
Mar 1 2018
Going to switch to this as part of SDK roll
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec commit 9b0bf72c7e1391f124af4e7a34a810673d5fa0ec Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 01 22:41:52 2018 Update GVR to 1.130.0 Results of diagnose_bloat: StaticInitializersCount -2 count count MonochromePublic.apk_Breakdown (-19,164 bytes) -84 bytes Native resources (no l10n) size -2,301 bytes Zip Overhead +87 bytes Non-compiled Android resources size -12,400 bytes Native code size -4 bytes Package metadata size -5,806 bytes Java code size +1,344 bytes Compiled Android resources size MonochromePublic.apk_Specifics -34,572 bytes normalized apk size -12,400 bytes main lib size -15,408 bytes main dex size Bug: 785118, 764446 Change-Id: I645134b61ef818a547a4eae239c067758d06fcf4 Reviewed-on: https://chromium-review.googlesource.com/943942 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#540320} [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/DEPS [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/chrome/android/static_initializers.gni [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/third_party/gvr-android-sdk/BUILD.gn [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/third_party/gvr-android-sdk/README.chromium [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/third_party/gvr-android-sdk/gvr_api_jni.h [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/third_party/gvr-android-sdk/gvr_common_java.info [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/third_party/gvr-android-sdk/libgvr_shim_static_arm.a.sha1 [modify] https://crrev.com/9b0bf72c7e1391f124af4e7a34a810673d5fa0ec/third_party/gvr-android-sdk/libgvr_shim_static_arm64.a.sha1
,
Mar 1 2018
,
Mar 2 2018
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4 commit 5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4 Author: Michael Thiessen <mthiesse@chromium.org> Date: Tue Mar 13 14:36:38 2018 Update GVR to 1.130.0 Results of diagnose_bloat: StaticInitializersCount -2 count count MonochromePublic.apk_Breakdown (-19,164 bytes) -84 bytes Native resources (no l10n) size -2,301 bytes Zip Overhead +87 bytes Non-compiled Android resources size -12,400 bytes Native code size -4 bytes Package metadata size -5,806 bytes Java code size +1,344 bytes Compiled Android resources size MonochromePublic.apk_Specifics -34,572 bytes normalized apk size -12,400 bytes main lib size -15,408 bytes main dex size TBR=mthiesse@chromium.org (cherry picked from commit 9b0bf72c7e1391f124af4e7a34a810673d5fa0ec) Bug: 785118, 764446 Change-Id: I645134b61ef818a547a4eae239c067758d06fcf4 Reviewed-on: https://chromium-review.googlesource.com/943942 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540320} Reviewed-on: https://chromium-review.googlesource.com/960562 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#194} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/DEPS [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/chrome/android/static_initializers.gni [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/third_party/gvr-android-sdk/BUILD.gn [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/third_party/gvr-android-sdk/README.chromium [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/third_party/gvr-android-sdk/gvr_api_jni.h [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/third_party/gvr-android-sdk/gvr_common_java.info [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/third_party/gvr-android-sdk/libgvr_shim_static_arm.a.sha1 [modify] https://crrev.com/5c6204e1ac6866a33b1ea5c9c1b067c695a62fb4/third_party/gvr-android-sdk/libgvr_shim_static_arm64.a.sha1 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 21 2018