viz: Printing FrameSinkId labels makes FrameSinkId valid again. |
|||
Issue descriptionThis line in SurfaceManager::SurfaceReferencesToStringImpl() inserts the FrameSinkId back into the map, which means the FrameSinkId is valid again. auto& label = valid_frame_sink_labels_[surface_id.frame_sink_id()]; If there is a Surface belonging to an invalidated FrameSinkId that hasn't been destroyed yet then the FrameSinkId will be registered again.
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76378d54c37806e7be47c0f1ecc04a4c8fa27960 commit 76378d54c37806e7be47c0f1ecc04a4c8fa27960 Author: Alex Zhang <staraz@chromium.org> Date: Thu Sep 14 17:03:21 2017 Use map::find() to Look Up For Label Using map::[] to look up with a surface with invalid FrameSinkId that hasn't been destroyed will make the FrameSinkId valid again. Use find() instead of [] to avoid inserting the FrameSinkId back into the map. Bug: 764444 Change-Id: Iaccf00c4e15f8bbc32712a13d98ce471c08dd600 Reviewed-on: https://chromium-review.googlesource.com/664839 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#501970} [modify] https://crrev.com/76378d54c37806e7be47c0f1ecc04a4c8fa27960/components/viz/service/surfaces/surface_manager.cc [modify] https://crrev.com/76378d54c37806e7be47c0f1ecc04a4c8fa27960/components/viz/service/surfaces/surface_manager.h
,
Sep 14 2017
,
Nov 8 2017
Migrating from Internals>Viz to Internals>Services>Viz. |
|||
►
Sign in to add a comment |
|||
Comment 1 by staraz@google.com
, Sep 13 2017