Typing an accent mark with physical keyboard on Android applies it to a whole series of characters |
|||||||
Issue descriptionEvery version after https://chromium.googlesource.com/chromium/src/+/c8a5f86ac17908905756c36a9d4ff87439401994 affected OS: Android What steps will reproduce the problem? (1) Set up a Pixel C keyboard iwth "Spanish (US) Google Keyboard" as the layout (2) Go to editpad.org (3) Hit the ' key and then type a string of a's What is the expected result? Only the first a has an accent mark What happens instead? All a's have accent marks Bisects to https://chromium.googlesource.com/chromium/src/+/c8a5f86ac17908905756c36a9d4ff87439401994 "Allow some InputConnection methods to be called on UI thread"
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7daa5e5c9f19d8fe7f545607d90e656e83ddc3b8 commit 7daa5e5c9f19d8fe7f545607d90e656e83ddc3b8 Author: Ryan Landay <rlanday@chromium.org> Date: Wed Sep 13 20:39:23 2017 Properly clear pending accent marks after keyboard events on Android In https://codereview.chromium.org/2299913003, a call to ThreadInputConnection#commitText(), which clears the pending accent character, was changed to ImeAdapter#sendCompositionToNative(), which does not. The fix is to clear the pending accent character after calling sendCompositionToNative(). Bug: 764443 Change-Id: I2703968d87b25d0c59a7b1210796aa2775a5a7f2 Reviewed-on: https://chromium-review.googlesource.com/663672 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#501742} [modify] https://crrev.com/7daa5e5c9f19d8fe7f545607d90e656e83ddc3b8/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java [modify] https://crrev.com/7daa5e5c9f19d8fe7f545607d90e656e83ddc3b8/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
,
Sep 13 2017
,
Sep 22 2017
customer needs this fixed in stable, installing canary on all customer devices as a workaround until 63 hits stable is not an acceptable option for them. Please merge down to beta/stable.
,
Sep 22 2017
,
Sep 22 2017
Definitely not getting an M61 merge, so rejecting that. I am not taking an M62 merge just because one customer that waited over 2 months to provide us feedback related to the issue is escalating this. If you can provide rationale outside of this, then I'm happy to discuss further.
,
Sep 22 2017
Not a stable blocker either.
,
Oct 5 2017
Will be fixed in M63. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rlanday@chromium.org
, Sep 12 2017