All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=764430

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d719c4883dd86a3505ef56e3a58d574bc734f9eed02821b2e17f73fc5f977e94


Bot(s) for this bug's original alert(s):

Android Builder

It looks like all of the growth comes from SkSL::transitions. That symbol accounts for 123953 bytes, and the rest of the change was actually a net decrease in size.

It's not clear to me whether or not this increase was expected. 88 KB is a large jump - is there any way we can decrease this? Any possibility of storing this data compressed and loading it when needed?

ethannicholas@ - please have a look and either:

  1. Close as “Won't Fix” with a short justification, or
  2. Land a revert / fix-up.

Deleted: diff_results.txt 44.8 KB

diff_results.txt 44.8 KB View Download

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/906126eedc792f12935145a9a2f13eea1d1cd86d

commit 906126eedc792f12935145a9a2f13eea1d1cd86d
Author: Ethan Nicholas <ethannicholas@google.com>
Date: Wed Sep 20 13:52:13 2017

Reduced size of SkSL lexer tables

The SkSL lexer tables contain duplicate rows, as many characters have the same
transitions (for instance, every lexer rule treats all digits [0-9] the
same way, so that means ten rows with identical transitions). This change
collapses such duplicate rows.

Bug:  764430 
Change-Id: I83040692f847e3aff8069fddbe975a007f4b383c
Reviewed-on: https://skia-review.googlesource.com/48263
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/lex/DFAState.h
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/lex/LexUtil.h
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/lex/NFAtoDFA.h
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/lex/DFA.h
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/lex/NFA.cpp
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/SkSLLayoutLexer.cpp
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/lex/Main.cpp
[modify] https://crrev.com/906126eedc792f12935145a9a2f13eea1d1cd86d/src/sksl/SkSLLexer.cpp

The roll with this commit (and only one other) shrank chrome by 77kb.

https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev= 503166

Thanks for the fix!