New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764429 link

Starred by 1 user
Status: Fixed
Owner:
vakh@chromium.org
Closed: Oct 2017
Cc:
█ bensanders@google.com
█ awoz@chromium.org
█ dacton@google.com
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 764406



Sign in to add a comment

Implement backoff for PVer4 update timeouts

Project Member Reported by vakh@chromium.org, Sep 12 2017 
For detailed context, see: https://bugs.chromium.org/p/chromium/issues/detail?id=764406

The timeout duration has been increased from 30 seconds to 15 minutes. ( Issue 763589 )
If the client still can't download an update in that time, there's little hope that the download will complete if retried soon so we should implement a backoff for such clients.

Use case: multiple computers on a slow network connection, all trying to download the updates at the same time without randomized backoff.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57132327314bebd22f4ce66ddbfe21c5d1a59a1a

commit 57132327314bebd22f4ce66ddbfe21c5d1a59a1a
Author: Varun Khaneja <vakh@chromium.org>
Date: Wed Sep 13 23:31:54 2017

PVer4: Implement backoff for timeouts

If the client is timing out even after the 15 minute timeout interval,
it's a good indication that they are on a slow shared network connection
so it's best to implement backoff to allow all machines on the network
to download the update successfully.

The backoff gets reset as soon as an update downloads successfully.

Bug:  764429 
Change-Id: I7df1e9519696122ae6b096d594eea0a1a241410f
TBR: lpz (since it is a minor change)
Reviewed-on: https://chromium-review.googlesource.com/666177
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501799}
[modify] https://crrev.com/57132327314bebd22f4ce66ddbfe21c5d1a59a1a/components/safe_browsing_db/v4_update_protocol_manager.cc
[modify] https://crrev.com/57132327314bebd22f4ce66ddbfe21c5d1a59a1a/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc

Comment 2 by vakh@chromium.org, Oct 16 2017

Status: Fixed (was: Started)
►

Sign in to add a comment