Opening stylus tools on when running CrOS on Linux causes crash |
|||||
Issue descriptionOpening stylus tools on when running CrOS on Linux causes crash Commenting out [1] fixes the issue (but this is not the right fix, as it breaks spec). 1: https://cs.chromium.org/chromium/src/ash/system/palette/palette_tray.cc?l=464&rcl=3fc7721d2246e06744c759c28be200f7f657ac17
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ea8144eceaa03731b0cbc96562ef9e45fad12a1 commit 8ea8144eceaa03731b0cbc96562ef9e45fad12a1 Author: Jacob Dufault <jdufault@google.com> Date: Tue Sep 12 22:42:56 2017 Account for margins when updating mask layer in TrayBubbleView. Bug: 764428 Change-Id: I051fc470ae57a15c6250aa14657239467852578f Reviewed-on: https://chromium-review.googlesource.com/663422 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#501431} [modify] https://crrev.com/8ea8144eceaa03731b0cbc96562ef9e45fad12a1/ui/views/bubble/tray_bubble_view.cc
,
Sep 12 2017
,
Sep 12 2017
,
Jan 22 2018
,
Jan 23 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36e326fda533471a7b4431ab2d57dea3b3dc20b2 commit 36e326fda533471a7b4431ab2d57dea3b3dc20b2 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 00:33:35 2018 Fix TrayBubbleView mask layer DCHECK. A mask layer should always have the same bounds as its parent's. TrayBubbleView sets a mask layer to layer()->parent(), but used the bounds of layer() for its mask layer. It caused DCHECK. Previously, https://crrev.com/c/663422 tried to fix this by using GetBubbleBounds(), but it still doesn't return the correct bounds in some cases e.g. |corner_radius| and |has_shadow| = false are set. TEST=TrayEventFilterTest BUG= 847104 , 764428 Change-Id: I677a0df7fc5342e7f722c97c30fc0b87f25b23f4 Reviewed-on: https://chromium-review.googlesource.com/1084530 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564738} [modify] https://crrev.com/36e326fda533471a7b4431ab2d57dea3b3dc20b2/ui/views/bubble/tray_bubble_view.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jdufault@chromium.org
, Sep 12 2017