New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764425 link

Starred by 3 users

CVE-2017-1000251: CrOS: Security: Blueborne vulnerabilities in bluetooth stacks

Project Member Reported by xz...@google.com, Sep 12 2017

Issue description

Armis Lab found few security vulnerabilities in bluetooth stacks as described in https://drive.google.com/file/d/0B7tynhulKyCYamp0Q3FoamJ1TFk/view

Need to determine which ChromeOS devices are affected.
 
White paper for this can be found here:

https://drive.google.com/file/d/0B7tynhulKyCYamp0Q3FoamJ1TFk/view

Comment 2 by xz...@google.com, Sep 12 2017

Description: Show this description

Comment 3 by xz...@google.com, Sep 12 2017

Description: Show this description
Cc: groeck@chromium.org snanda@chromium.org dmitrygr@google.com
Components: OS>Kernel
Status: Untriaged (was: Unconfirmed)
The paper references kernel bugs, specifically CVE-2017-1000251. I have a hard time finding information on that. groeck@ are you aware of any patches for this? Android probably has patched this already...

snanda, dmitrygr: Who's owning bluetooth in Chrome OS these days? Can you help route to somebody to work through the writeup (see comment #1) and see whether any of the vulnerabilities listed there are present in Chrome OS userspace?
Labels: Security_Severity-Critical Security_Impact-Stable
Setting severity-high and impact-stable for now - might downgrade this if it turns out there are significant hurdles/restrictions to get remote code execution via this.
Cc: -chromeos-security-core@google.com ejcaruso@chromium.org
Labels: -OS-Linux
Dropping OS=Linux since we're not on the hook to maintain the BT stack for Chrome/Linux.

Comment 8 by groeck@chromium.org, Sep 12 2017

Upstream commit e860d2c904d1 ("Bluetooth: Properly check L2CAP config option output buffer length")



Comment 9 by groeck@chromium.org, Sep 12 2017

Owner: groeck@chromium.org
Status: Started (was: Untriaged)
Labels: M-61
Cc: keta...@chromium.org bhthompson@chromium.org josa...@chromium.org
Adding release folks FYI. This is a pretty urgent security bug which we should push a fix for rather sooner than later.
This has missed the Dev we are doing today, but if we can land this into 61 today we can make the Dev on Thursday.

If we are super confident in this, we are doing a 60 stable tomorrow for other reasons, but I am thinking that might be to aggressive. On the other hand if we miss the 60 tomorrow, it might not get to stable until October 5th for 61.
Correction, the '61 beta' on Thursday.
Labels: Merge-Request-61
Needs to get approval first. Feel free to update tags if this should go into M-60, otherwise I'll target M-61.

Summary: CVE-2017-1000251: CrOS: Security: Blueborne vulnerabilities in bluetooth stacks (was: Security: Blueborne vulnerabilities in bluetooth stacks)
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 12 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-62 Merge-Approved-61
Consider it approved for 61 and 62. 

We can hold on 60 for now.
Note: The blueborne paper lists a couple more vulnerabilities. I've broken out bugs for the ones potentially relevant to Chrome OS. Specifically:

Linux Bluetooth stack (BlueZ) information Leak vulnerability - CVE-2017-1000250 ->  issue 764477 

SSP -> ejcaruso@ investigating, see  issue 764485 

BNEP / PAN (CVE-2017-0783 & CVE-2017-8628) -> network profiles are disabled in Chrome OS bluez build config per https://chromium-review.googlesource.com/c/chromiumos/third_party/bluez/+/424916 and https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/424873
The only POC code we have had for this so far is tailored for Android (Nexus 5 in particular), but details can be found here:  

https://b.corp.google.com/issues/37500386#comment31
Cc: mcchou@chromium.org
In case necessary here are all associated Android bugs:

CVE-2017-0781 (b/63146105)
Critical, remote code execution
Android specific vulnerability that could enable an attacker to obtain remote code execution as a privileged process over Bluetooth with no user interaction.


CVE-2017-0782 (b/63146237)
Critical, remote code execution
Android specific vulnerability that could enable an attacker to obtain remote code execution as a privileged process over Bluetooth with no user interaction.


CVE-2017-0783 (b/63145701)
High, information disclosure
Bluetooth spec deficiency (with PAN) that could enable a remote attacker to man-in-the-middle.


CVE-2017-0785 (b/63146698)
Moderate, information disclosure
Information leak with the SDP server - Armis does not even mention this in their disclosure.
SSP looks to be a non-issue for us.
Project Member

Comment 24 by bugdroid1@chromium.org, Sep 12 2017

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/517fccbf5a6873c8bdb95c9ca8239b5a038e96a3

commit 517fccbf5a6873c8bdb95c9ca8239b5a038e96a3
Author: Ben Seri <ben@armis.com>
Date: Tue Sep 12 23:17:09 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663523

[modify] https://crrev.com/517fccbf5a6873c8bdb95c9ca8239b5a038e96a3/net/bluetooth/l2cap_core.c

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 12 2017

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/43f8ce46aebec0ab641d2e5f43db4bd5c0abee40

commit 43f8ce46aebec0ab641d2e5f43db4bd5c0abee40
Author: Ben Seri <ben@armis.com>
Date: Tue Sep 12 23:17:10 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663522

[modify] https://crrev.com/43f8ce46aebec0ab641d2e5f43db4bd5c0abee40/net/bluetooth/l2cap_core.c

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 12 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e2b42958590d1d86388a7a09716d133947ef3228

commit e2b42958590d1d86388a7a09716d133947ef3228
Author: Ben Seri <ben@armis.com>
Date: Tue Sep 12 23:17:08 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663611
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/e2b42958590d1d86388a7a09716d133947ef3228/net/bluetooth/l2cap_core.c

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 12 2017

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d7a82d1e7965abb479895b7de880a034a9eccde3

commit d7a82d1e7965abb479895b7de880a034a9eccde3
Author: Ben Seri <ben@armis.com>
Date: Tue Sep 12 23:17:06 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663520

[modify] https://crrev.com/d7a82d1e7965abb479895b7de880a034a9eccde3/net/bluetooth/l2cap_core.c

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4713077c684160bdbf776cf5783cd12e97d46f30

commit 4713077c684160bdbf776cf5783cd12e97d46f30
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:24 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664047

[modify] https://crrev.com/4713077c684160bdbf776cf5783cd12e97d46f30/net/bluetooth/l2cap_core.c

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R62-9901.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/69b864ea8eb14235d2a8523958ee7684520bbc2d

commit 69b864ea8eb14235d2a8523958ee7684520bbc2d
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:29 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664045

[modify] https://crrev.com/69b864ea8eb14235d2a8523958ee7684520bbc2d/net/bluetooth/l2cap_core.c

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ad2186d7f1abbae1e7aaa4b50ee3206eee6bc6b1

commit ad2186d7f1abbae1e7aaa4b50ee3206eee6bc6b1
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:33 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664049

[modify] https://crrev.com/ad2186d7f1abbae1e7aaa4b50ee3206eee6bc6b1/net/bluetooth/l2cap_core.c

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R61-9765.B-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f5d6ebffc54e22a1323265edd1463ff48c396ac3

commit f5d6ebffc54e22a1323265edd1463ff48c396ac3
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:37 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663829

[modify] https://crrev.com/f5d6ebffc54e22a1323265edd1463ff48c396ac3/net/bluetooth/l2cap_core.c

Project Member

Comment 32 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R62-9901.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/11455e6dc31cc4ad4cd2495f9f859ed5fb5ae98c

commit 11455e6dc31cc4ad4cd2495f9f859ed5fb5ae98c
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:41 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664046

[modify] https://crrev.com/11455e6dc31cc4ad4cd2495f9f859ed5fb5ae98c/net/bluetooth/l2cap_core.c

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R62-9901.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f78b16efdc37a96a8ad559f86c0eebea0ec2d046

commit f78b16efdc37a96a8ad559f86c0eebea0ec2d046
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:45 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664048

[modify] https://crrev.com/f78b16efdc37a96a8ad559f86c0eebea0ec2d046/net/bluetooth/l2cap_core.c

Project Member

Comment 34 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R62-9901.B-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5e9513605e979b3ad09d01184292820b434d9205

commit 5e9513605e979b3ad09d01184292820b434d9205
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:19:49 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663830

[modify] https://crrev.com/5e9513605e979b3ad09d01184292820b434d9205/net/bluetooth/l2cap_core.c

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5adaf887034b87f6cf973427da7dfc870db3ab0a

commit 5adaf887034b87f6cf973427da7dfc870db3ab0a
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:21:58 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663831

[modify] https://crrev.com/5adaf887034b87f6cf973427da7dfc870db3ab0a/net/bluetooth/l2cap_core.c

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R62-9901.B-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3e94b6fa16c6a962b1dbe4aef8a74ee25b745bf7

commit 3e94b6fa16c6a962b1dbe4aef8a74ee25b745bf7
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:22:02 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664050

[modify] https://crrev.com/3e94b6fa16c6a962b1dbe4aef8a74ee25b745bf7/net/bluetooth/l2cap_core.c

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/db4b5667401fc444ae46388fef9c21d6e5abc75a

commit db4b5667401fc444ae46388fef9c21d6e5abc75a
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 02:22:05 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/664051

[modify] https://crrev.com/db4b5667401fc444ae46388fef9c21d6e5abc75a/net/bluetooth/l2cap_core.c

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/566a7b6d3b99b154c5a48b3fcd4a5100a6c0a4c1

commit 566a7b6d3b99b154c5a48b3fcd4a5100a6c0a4c1
Author: Ben Seri <ben@armis.com>
Date: Wed Sep 13 04:37:10 2017

UPSTREAM: Bluetooth: Properly check L2CAP config option output buffer length

Validate the output buffer length for L2CAP config requests and responses
to avoid overflowing the stack buffer used for building the option blocks.

BUG= chromium:764425 
TEST=Build and run

Change-Id: I62362e78a73e7f14c10b6cbbefc6b44ce6bdbcc8
Cc: stable@vger.kernel.org
Signed-off-by: Ben Seri <ben@armis.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit e860d2c904d1)
Reviewed-on: https://chromium-review.googlesource.com/663521

[modify] https://crrev.com/566a7b6d3b99b154c5a48b3fcd4a5100a6c0a4c1/net/bluetooth/l2cap_core.c

Labels: -Merge-Approved-61 -Merge-Approved-62
Status: Fixed (was: Started)
Project Member

Comment 40 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-61 Merge-Request-60 M-60
Putting this on Josafat's radar for an M60 respin.
Cc: kevinhayes@chromium.org
Project Member

Comment 43 by sheriffbot@chromium.org, Sep 20 2017

Labels: -M-60 M-61
Cc: kevinhayes@google.com
 Issue 769669  has been merged into this issue.
Project Member

Comment 46 by sheriffbot@chromium.org, Oct 18 2017

Labels: -M-61 M-62
Project Member

Comment 47 by sheriffbot@chromium.org, Dec 7 2017

Labels: -M-62 M-63
Project Member

Comment 48 by sheriffbot@chromium.org, Dec 20 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 49 by sheriffbot@chromium.org, Jan 25 2018

Labels: -M-63 M-64
Project Member

Comment 50 by sheriffbot@chromium.org, Mar 7 2018

Labels: -M-64 M-65
Project Member

Comment 51 by sheriffbot@chromium.org, Apr 19 2018

Labels: -M-65 M-66
Project Member

Comment 52 by sheriffbot@chromium.org, May 30 2018

Labels: -M-66 M-67
Project Member

Comment 53 by sheriffbot@chromium.org, Jul 25

Labels: -M-67 Target-68 M-68
Project Member

Comment 54 by sheriffbot@chromium.org, Jul 28

Labels: -Pri-1 Pri-0
Project Member

Comment 55 by sheriffbot@chromium.org, Sep 5

Labels: -M-68 M-69 Target-69
Project Member

Comment 56 by sheriffbot@chromium.org, Oct 17

Labels: -M-69 Target-70 M-70
Project Member

Comment 57 by sheriffbot@chromium.org, Dec 5

Labels: -M-70 Target-71 M-71
Labels: -Merge-Request-60 -Target-71
Labels: -Target-68 -Target-69 -Target-70 -M-71 M-61

Sign in to add a comment