Get sql_unittests up on Fuchsia |
|||
Issue descriptionIn getting content_unittests going, we exposed some problems in sql/sqlite. It'd be useful to know if the sql fixes are working correctly, so we should make sql_unittests a prerequiste to content_unittests.
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/502836c8529be236cdeec5be6715d20e1b5abe4d commit 502836c8529be236cdeec5be6715d20e1b5abe4d Author: Scott Graham <scottmg@chromium.org> Date: Thu Sep 14 23:26:23 2017 fuchsia: Disable sqlite tests that require shm in vfs Dot-file locking (which we're currently using on Fuchsia) specifies "version 1" of VFS. This doesn't include SHM functions, so disable the mmap-requiring tests. Bug: 764423 Change-Id: I2bb24f4130bebdb3371aca4ee4169dd573d9cbb1 Reviewed-on: https://chromium-review.googlesource.com/665301 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#502096} [modify] https://crrev.com/502836c8529be236cdeec5be6715d20e1b5abe4d/sql/sqlite_features_unittest.cc [modify] https://crrev.com/502836c8529be236cdeec5be6715d20e1b5abe4d/testing/buildbot/chromium.fyi.json
,
Sep 15 2017
On the (fyi) waterfall now.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47ed2c3f20ad6dc135cba6fa7296c2b78622ee15 commit 47ed2c3f20ad6dc135cba6fa7296c2b78622ee15 Author: Scott Graham <scottmg@chromium.org> Date: Fri Sep 15 02:17:07 2017 Remove references to MOJO_APPTEST_IMPL in sql/ Noticed while porting sql_unittests to Fuchsia. Seems to be dead code. Bug: 764423 Change-Id: Ibe238f3674a3b7fbcf9dfd4e98d23052f6161e12 Reviewed-on: https://chromium-review.googlesource.com/665349 Reviewed-by: Elliot Glaysher <erg@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#502134} [modify] https://crrev.com/47ed2c3f20ad6dc135cba6fa7296c2b78622ee15/sql/BUILD.gn [modify] https://crrev.com/47ed2c3f20ad6dc135cba6fa7296c2b78622ee15/sql/connection_unittest.cc [delete] https://crrev.com/86bc62c9debaf42c81cf69c48b58420fa3dfd04e/sql/correct_sql_test_base.h [modify] https://crrev.com/47ed2c3f20ad6dc135cba6fa7296c2b78622ee15/sql/sqlite_features_unittest.cc [modify] https://crrev.com/47ed2c3f20ad6dc135cba6fa7296c2b78622ee15/sql/statement_unittest.cc [modify] https://crrev.com/47ed2c3f20ad6dc135cba6fa7296c2b78622ee15/sql/transaction_unittest.cc
,
Sep 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 13 2017