New issue
Advanced search Search tips

Issue 764423 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 882906
issue 754861



Sign in to add a comment

Get sql_unittests up on Fuchsia

Project Member Reported by scottmg@chromium.org, Sep 12 2017

Issue description

In getting content_unittests going, we exposed some problems in sql/sqlite. It'd be useful to know if the sql fixes are working correctly, so we should make sql_unittests a prerequiste to content_unittests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ee54827e51012631c50bb15647dad8c910f078

commit 57ee54827e51012631c50bb15647dad8c910f078
Author: Scott Graham <scottmg@chromium.org>
Date: Wed Sep 13 06:37:56 2017

fuchsia: Get sql_unittests compiling

Only compile, 83/83 fail at the moment.

Bug:  764423 
Change-Id: Ia49a9b5e119c84de651484938357ede133c56dda
Reviewed-on: https://chromium-review.googlesource.com/663603
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501556}
[modify] https://crrev.com/57ee54827e51012631c50bb15647dad8c910f078/sql/connection_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/502836c8529be236cdeec5be6715d20e1b5abe4d

commit 502836c8529be236cdeec5be6715d20e1b5abe4d
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Sep 14 23:26:23 2017

fuchsia: Disable sqlite tests that require shm in vfs

Dot-file locking (which we're currently using on Fuchsia) specifies
"version 1" of VFS. This doesn't include SHM functions, so disable the
mmap-requiring tests.

Bug:  764423 
Change-Id: I2bb24f4130bebdb3371aca4ee4169dd573d9cbb1
Reviewed-on: https://chromium-review.googlesource.com/665301
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502096}
[modify] https://crrev.com/502836c8529be236cdeec5be6715d20e1b5abe4d/sql/sqlite_features_unittest.cc
[modify] https://crrev.com/502836c8529be236cdeec5be6715d20e1b5abe4d/testing/buildbot/chromium.fyi.json

Status: Fixed (was: Started)
On the (fyi) waterfall now.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017

Blocking: 882906

Sign in to add a comment