New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764419 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 752547



Sign in to add a comment

Clean up the style and format of chrome://interventions-internals

Project Member Reported by ryansturm@chromium.org, Sep 12 2017

Issue description

chrome://interventions should be styled better with CSS so users can read it more easily. The format of the page should be readable as well.
 
Blocking: 752547
Status: Started (was: Assigned)

Comment 3 by bengr@chromium.org, Oct 31 2017

Summary: Clean up the style and format of chrome://interventions-internals (was: Clean up the style and format of chrome://interventions)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1674b045a82b34407efbb9b3e9ed2e1d4c2ee42

commit e1674b045a82b34407efbb9b3e9ed2e1d4c2ee42
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Nov 01 00:41:57 2017

Fix the layout of chrome://interventions-internals.

The tab navigation bar is now stretch across the page The table also
fit to the device width, and the "URL" column in the "Logs" tab is now
scrollable to make it nicer for longer hostnames on mobile

Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3MlA2bnNYNUhfdVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3RXQ3clFLRFBtaVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3THd0Q3JVcm44c00

Bug:  764419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieba316275f2acfa60dea480be701995c68fb2f7a
Reviewed-on: https://chromium-review.googlesource.com/747865
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513026}
[modify] https://crrev.com/e1674b045a82b34407efbb9b3e9ed2e1d4c2ee42/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/e1674b045a82b34407efbb9b3e9ed2e1d4c2ee42/chrome/browser/resources/interventions_internals/index.html

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85d3bea015ecf7904096e2df598e01d65fcc39f

commit d85d3bea015ecf7904096e2df598e01d65fcc39f
Author: Thanh Le <thanhdle@chromium.org>
Date: Mon Nov 06 20:21:29 2017

Make chrome://interventions-internals UI more mobile friendly.

Scale table column a bit better on desktop vs mobile. Make the
font-size smaller on mobile resolutions.

Desktop: https://drive.google.com/a/chromium.org/file/d/1Ik66kEJ3AqMMHdO-Kb8Botk9xCjvCJJq
Mobile:  https://drive.google.com/a/chromium.org/file/d/1FWdtOYyMy8PvbyqJp0430KzrtVWkdIsz
Mobile:  https://drive.google.com/a/chromium.org/file/d/1dqR80dKswo3gSvsLKjHltvVG0aaz0UaV
Tab UI:  https://drive.google.com/a/chromium.org/file/d/1_1DiJXjHKpFWpZl-S7IvqLocBmeGdwrM
Tab UI:  https://drive.google.com/a/chromium.org/file/d/1uGICJ9sDv_6ypxohZFmTuEzDuXb8kZhW   

Bug:  764419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I589b7e484beddb0131505a23e047cc64c5ae7158
Reviewed-on: https://chromium-review.googlesource.com/754271
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514228}
[modify] https://crrev.com/d85d3bea015ecf7904096e2df598e01d65fcc39f/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/d85d3bea015ecf7904096e2df598e01d65fcc39f/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/d85d3bea015ecf7904096e2df598e01d65fcc39f/chrome/browser/resources/interventions_internals/index.js

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6862b54756978ed91665db50424d9c8c6551360

commit f6862b54756978ed91665db50424d9c8c6551360
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Nov 08 02:25:53 2017

Shorten URL in the log table in chrome://interventions-internals.

If the URL is too long, display a shorten version of it, and put a
hidden tooltip so that user can view the original URL.

Screenshot:
https://drive.google.com/a/chromium.org/file/d/1-CTu4MSna-WM3BKYbYPDV5j0GX0VfdHl

Bug:  764419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I59db9a36946ecea225a176e3895f282a1af4ff49
Reviewed-on: https://chromium-review.googlesource.com/757127
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514714}
[modify] https://crrev.com/f6862b54756978ed91665db50424d9c8c6551360/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/f6862b54756978ed91665db50424d9c8c6551360/chrome/browser/resources/interventions_internals/index.js

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411bf6ec25f3f16b24ff9e9c4e80ca9ddfe6a5a6

commit 411bf6ec25f3f16b24ff9e9c4e80ca9ddfe6a5a6
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Nov 08 20:53:42 2017

Changed button style on chrome://interventions-internals.

Moved "Clear Log" button to the right most side of the page to make it
less confusing with the filter search box.

Screenshot: https://drive.google.com/a/chromium.org/file/d/1G3smTzQk9pdqmhO-pS-Cd3hLPuk52Wly
Screenshot: https://drive.google.com/a/chromium.org/file/d/1vbNbPnoQpKHZvNuF3vUUeEAVMSevWAwj
Bug:  764419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If77a0f4bd761834ca4983420d17bf6c91cd9f89a
Reviewed-on: https://chromium-review.googlesource.com/758813
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514932}
[modify] https://crrev.com/411bf6ec25f3f16b24ff9e9c4e80ca9ddfe6a5a6/chrome/browser/resources/interventions_internals/index.css

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad919765458d7cfbc50b6fe9df480a3f9258ede4

commit ad919765458d7cfbc50b6fe9df480a3f9258ede4
Author: Thanh Le <thanhdle@chromium.org>
Date: Fri Nov 10 02:49:14 2017

Changed message discription of logs on chrome://interventions-internals.

Since the log type already indicate whether the message is a navigation
or a decision made, there is no need to put that in the description.

Bug:  764419 
Change-Id: I869173fb7c14a98de633bf006754819e350ebbc5
Reviewed-on: https://chromium-review.googlesource.com/762406
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515431}
[modify] https://crrev.com/ad919765458d7cfbc50b6fe9df480a3f9258ede4/components/previews/core/previews_logger.cc
[modify] https://crrev.com/ad919765458d7cfbc50b6fe9df480a3f9258ede4/components/previews/core/previews_logger_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee05e52e997b0f96047c78615e5e76056ff2b2fa

commit ee05e52e997b0f96047c78615e5e76056ff2b2fa
Author: Thanh Le <thanhdle@chromium.org>
Date: Mon Nov 13 18:12:44 2017

Edit table style of chrome://intervention-internals.

Change table headers' height and color, since the they look like buttons.

Change the "Notes" header back to "Description" since it makes much more sense.

Screenshot: https://drive.google.com/a/chromium.org/file/d/188W0j_izuPSxVt6SwskLEOdqUI8vcoCU

Bug:  764419 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If743172020754c50b6c234e3bb23f7f2d178cb36
Reviewed-on: https://chromium-review.googlesource.com/763669
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515982}
[modify] https://crrev.com/ee05e52e997b0f96047c78615e5e76056ff2b2fa/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/ee05e52e997b0f96047c78615e5e76056ff2b2fa/chrome/browser/resources/interventions_internals/index.html

Status: Fixed (was: Started)

Comment 13 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 14 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment