New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764418 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 773339
issue 752547
issue 773019
issue 774252



Sign in to add a comment

Publish Previews Event Log to chrome://interventions-internals

Project Member Reported by ryansturm@chromium.org, Sep 12 2017

Issue description

The previews event log (the history of previews navigation decisions and events) should be published to chrome://itnerventions. Ideally, this list would be searchable for specific strings.
 
Blocking: 752547
Components: Privacy
Blocking: 773019
Blocking: 773339
Status: Started (was: Assigned)
Summary: Publish Previews Event Log to chrome://interventions-internals (was: Publish Previews Event Log to chrome://interventions)
I'm not sure why the privacy component got added to this in comment 2.

This is an internals page that exposes some user action history, but only to the user (it's not synced; just local profile user action history). Is there a privacy concern here I am missing? Is there a privacy review needed on this?
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c52018d4a712ff7f74d920f2c5271947c4e80d22

commit c52018d4a712ff7f74d920f2c5271947c4e80d22
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Oct 11 20:16:46 2017

Posting Previews navigations to chrome://interventions-internals.

Screenshots of the basic ui:
https://drive.google.com/open?id=0B_MBksOU85S3R0R0ano1OVF0eXc
https://drive.google.com/open?id=0B_MBksOU85S3eW1vcUtYaW5LdzQ

Bug:  764418 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id7f79ef2295b9d22eccc12c8ea46812f09373eca
Reviewed-on: https://chromium-review.googlesource.com/698887
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508090}
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/previews/previews_service.cc
[add] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/BUILD.gn
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.h
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/chrome/test/data/webui/interventions_internals_browsertest.js
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/BUILD.gn
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_io_data.h
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_io_data_unittest.cc
[delete] https://crrev.com/bbe776a20641c354b23e9d79c14c7a2392ec86e1/components/previews/core/previews_log_unittest.cc
[rename] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_logger.cc
[rename] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_logger.h
[add] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_logger_observer.h
[add] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_logger_unittest.cc
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_ui_service.cc
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_ui_service.h
[modify] https://crrev.com/c52018d4a712ff7f74d920f2c5271947c4e80d22/components/previews/core/previews_ui_service_unittest.cc

Blocking: 774252
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9

commit 83cd4d8f539b619fbda2ae328ef8c25eb9b604e9
Author: Thanh Le <thanhdle@chromium.org>
Date: Mon Oct 16 23:04:56 2017

Post Previews decision made on chrome://interventions-internals.

Added method on previews_logger, previews_ui_service, and
previews_io_data to add MessageLog for a preview decision.

Removed PreviewNavigation struct in previews_logger.h, since that struct doesn't
seem to be used
anywhere else other than as a parameter.

Bug:  764418 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8b9093e7eedd421d386c9c63b424579050bfcbdc
Reviewed-on: https://chromium-review.googlesource.com/714197
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509189}
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_black_list.h
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_io_data.cc
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_io_data.h
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_io_data_unittest.cc
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_logger.cc
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_logger.h
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_logger_unittest.cc
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_ui_service.cc
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_ui_service.h
[modify] https://crrev.com/83cd4d8f539b619fbda2ae328ef8c25eb9b604e9/components/previews/core/previews_ui_service_unittest.cc

Status: Fixed (was: Started)

Comment 11 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 12 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment