This is happening more frequently recently - e.g., the last three builds on Win7 Tests 1 failed this way: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/71694

tapted@, can you take a look at this? bumping priority since this is causing a lot of sheriff pain

Sheriffs have been ignoring this for over a week... it's probably a misconfigured swarming bot or bots. I'm guessing that when a shard fails, it's always on a particular vm or 2.

I'm gonna bump this to a Windows person and +Infra, but I suspect this is a bot misconfiguration still. Someone may need to login to the VMs to try to repro.

The shard output has

[0905/055806.030:ERROR:always_on_top_window_killer_win.cc(67)] There is an always on top window on the desktop before running the test. This may have been caused by a previous test and may cause this test to fail, class-name=ConsoleWindowClass process_id=1968 thread_id=1972


These failures go back to https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/71055 ( r499604 - not interesting). That change was 20 days ago (Sep 5, 2017).

I checked the 55 builds before that and they all succeeded. But maybe there's one earlier.

The most recent change to interactive_ui_tests before r499604 was r499487 "Disabling WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus due to failures.". in build 71017

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/71016 has 246+270 tests
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/71017 has 245+269 tests

VMs with failures - a pattern isn't emerging
 - vm83-m4 https://chromium-swarm.appspot.com/task?id=386aef260e7c6110&refresh=10 (build 71055)
 - vm80-m4 https://chromium-swarm.appspot.com/task?id=387cfabc4f8d4010&refresh=10 (build 71206)
 - vm1427-m4 https://chromium-swarm.appspot.com/task?id=389df248b97d7610&refresh=10 (build 71436)
 - vm1431-m4 https://chromium-swarm.appspot.com/task?id=38b2efdf701bac10&refresh=10&show_raw=1 (build 71560)
 - vm1425-m4 https://chromium-swarm.appspot.com/task?id=38c2a87964fa5410&refresh=10&show_raw=1 71692
 - vm1376-m4 https://chromium-swarm.appspot.com/task?id=38c2cfe3ea071d10&refresh=10&show_raw=1 71693
 - vm1393-m4 https://chromium-swarm.appspot.com/task?id=38c2f7c482ef9e10&refresh=10&show_raw=1 71694


There is a run of ~20 successful runs in https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29?numbuilds=200 so lowering priority.

could we bump the priority, seeing more failures:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29?numbuilds=200

Sheriff checking in, this is happening again

Could this be related to  http://crbug.com/523255  ?  +sky@.

The logged class name is "ConsoleWindowClass". Is this related to "#32770" from
https://cs.chromium.org/chromium/src/chrome/test/base/always_on_top_window_killer_win.cc?l=50
?

You are seeing logging that I added as part of 523255. We have screenshot code in chrome, maybe we should make the code create a screenshot and save it when this happens. That would hopefully identify what window is causing the problem.

Anyone know how we could have such a screenshot land somewhere accessible so that we don't have to log into the bot to find it?

ConsoleWindowClass the command prompt (according to Google Image search and spyxx.exe). Is it always spawned for the test? Could it gain WS_EX_TOPMOST somehow?

#9: the usual way is uploading it to cloud storage or to put it in the out directory which allow swarming to automatically archive the files. We have some plan to standardize how to store the archive files but it would take a while to get there.

+maruel@ can confirm the 2nd method.

Please save it to ${ISOLATED_OUTDIR}, a variable that is passed on the command line. This directory is already passed to the tests: this is the directory where output.json is stored.

Store it aside output.json and then you'll be able to browse the file via the web ui.

Please do not use cloud storage directly.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/522146e8024f81aff5a7c076f5a819aec719ed99

commit 522146e8024f81aff5a7c076f5a819aec719ed99
Author: Greg Thompson <grt@chromium.org>
Date: Thu Oct 05 00:02:06 2017

Deflake ui_controls::SendMouseMove on Windows.

On Windows, SendMouseMove must transform a point in screen coordinates
into the range (0..2^16-1) for consumption by SendInput. Windows then
converts this back to screen coordinates. This change rounds up rather
than down in the initial conversion so that Windows lands on the correct
point when it seemly truncates.

Previously, we'd see off-by-one errors from time to time. While this may
seem insignificant at first blush, it's problematic when SendMouseMove
is called to move the mouse to a point where it already resides. No
events are generated by SendInput in this case, so the hook proc will
never be called. This shouldn't be a problem since SendMouseMove detects
this case and short-circuits the request. With the ob1, however,
SendMouseMove thinks it needs to move the mouse by one point, yet the
bad math results in a call to SendInput to move the mouse to its current
position. This makes tests timeout and all of us sad.

BUG= 390564 , 639940 , 710436 , 726659 , 728488 , 764415 
R=mathp@chromium.org, sky@chromium.org

Change-Id: I1daebe8281db0a799ef7266c3c1765de65580f03
Reviewed-on: https://chromium-review.googlesource.com/686898
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506574}
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/autofill/autofill_interactive_uitest.cc
[add] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/ui/send_mouse_move_uitest_win.cc
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/test/BUILD.gn
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/ui/base/test/ui_controls_internal_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04ff7bf136a756c939eab5c162147b46c78f1866

commit 04ff7bf136a756c939eab5c162147b46c78f1866
Author: Greg Thompson <grt@chromium.org>
Date: Fri Oct 06 08:56:02 2017

Include the path to the process owning an on-top window when one is found.

BUG= 764415 
R=sky@chromium.org

Change-Id: Ia69475e3e567d2e1baa11579050309877fb9f38e
Reviewed-on: https://chromium-review.googlesource.com/702235
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507010}
[modify] https://crrev.com/04ff7bf136a756c939eab5c162147b46c78f1866/chrome/test/base/always_on_top_window_killer_win.cc

emso@ pointed me toward ${ISOLATED_OUTDIR}, which i think is all i needed for screenshots. i'm working on a CL to capture them for these always-on-top windows so we can see what's going on. i'm watching the bot to see if r507010 tells us anything.

[1006/061911.363:ERROR:always_on_top_window_killer_win.cc(85)] There is an always on top window on the desktop before running the test. This may have been caused by a previous test and may cause this test to fail, class-name=ConsoleWindowClass process_id=1888 thread_id=1892 process_path=C:\Windows\System32\cmd.exe

meh.

Maybe walking the process tree, including the paths to parents would help.

Anyway, making progress on the screenshot code. Maybe that'll help.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cea44ff0b7ca50f40b256eb55079737fdd61373b

commit cea44ff0b7ca50f40b256eb55079737fdd61373b
Author: Greg Thompson <grt@chromium.org>
Date: Wed Oct 11 12:22:53 2017

Save a snapshot of the screen when an always-on-top window is found if requested.

"interactive_ui_tests.exe --snapshot-output-dir=DIR" will cause a
snapshot named "ss_YYYYMMDDhhmmss_mmm.png" to be written to the
specified output directory.

BUG= 764415 
R=sky@chromium.org

Change-Id: I5a7645c22a996ae4a84ade2d9d42c302a9fd66d8
Reviewed-on: https://chromium-review.googlesource.com/707057
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507958}
[modify] https://crrev.com/cea44ff0b7ca50f40b256eb55079737fdd61373b/chrome/test/BUILD.gn
[modify] https://crrev.com/cea44ff0b7ca50f40b256eb55079737fdd61373b/chrome/test/DEPS
[modify] https://crrev.com/cea44ff0b7ca50f40b256eb55079737fdd61373b/chrome/test/base/always_on_top_window_killer_win.cc
[modify] https://crrev.com/cea44ff0b7ca50f40b256eb55079737fdd61373b/chrome/test/base/interactive_ui_tests_main.cc
[modify] https://crrev.com/cea44ff0b7ca50f40b256eb55079737fdd61373b/testing/buildbot/gn_isolate_map.pyl

Naturally, the first failure after landing r507958 didn't involve an always-on-top window. I'm still digging...

One failure shows that a binary that's called logging::SetShowErrorDialogs(true) hit a fatal failure:

https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=e7e35b5e333b758c4c1fbb9965eff5029b4ae7af&as=ss_20171026105357_825.png

We definitely shouldn't do that on the bots. InitChromeLogging and InitChromeWatcherLogging are the only two places that do that. I would say that CHROME_HEADLESS=1 should also suppress those dialogs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d548ffaf774d421879ceaf5fee3d72772385de33

commit d548ffaf774d421879ceaf5fee3d72772385de33
Author: Greg Thompson <grt@chromium.org>
Date: Tue Oct 31 08:25:05 2017

Do not show fatal errors in a dialog when CHROME_HEADLESS is set.

This makes handling of Chrome's own fatal messages consistent with
handling of system errors.

BUG= 764415 
R=siggi@chromium.org,sky@chromium.org

Change-Id: If60f3366d38d719741918982ce02265a766a3c08
Reviewed-on: https://chromium-review.googlesource.com/741232
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512778}
[modify] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/chrome/chrome_watcher/chrome_watcher_main.cc
[modify] https://crrev.com/d548ffaf774d421879ceaf5fee3d72772385de33/chrome/common/logging_chrome.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ced5430e46b1fa8cbcd75b10118ead4cff78acac

commit ced5430e46b1fa8cbcd75b10118ead4cff78acac
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 01 06:24:07 2017

Switch from callbacks to an observer for TestLauncher::LaunchChildGTestProcess.

Originally, LaunchChildGTestProcess took a single callback that was run
on the caller's thread when all processing was done for the child
process. Eventually, a second callback was added to give consumers a
chance to act immediately on process launch. This here change switches
from two callbacks to an observer interface in preparation for a third
observation point.

BUG= 764415 
R=sky@chromium.org,phajdan.jr@chromium.org

Change-Id: I38a8a99a78007d4598e650b85d9936beb1ef6a1e
Reviewed-on: https://chromium-review.googlesource.com/746682
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513089}
[modify] https://crrev.com/ced5430e46b1fa8cbcd75b10118ead4cff78acac/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/ced5430e46b1fa8cbcd75b10118ead4cff78acac/base/test/launcher/test_launcher.h
[modify] https://crrev.com/ced5430e46b1fa8cbcd75b10118ead4cff78acac/base/test/launcher/unit_test_launcher.cc
[modify] https://crrev.com/ced5430e46b1fa8cbcd75b10118ead4cff78acac/content/public/test/test_launcher.cc
[modify] https://crrev.com/ced5430e46b1fa8cbcd75b10118ead4cff78acac/content/public/test/test_launcher.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64c79760b3a2669b47c34424e2d4cea3e29fc50a

commit 64c79760b3a2669b47c34424e2d4cea3e29fc50a
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 01 06:42:35 2017

Add ProcessLifetimeObserver::OnTimedOut.

This allows consumers of TestLauncher and content::LaunchTests to take
action on child process timeout before the process is terminated.

BUG= 764415 
R=phajdan.jr@chromium.org,sky@chromium.org

Change-Id: Iccb359273c464f1e660a079af92edfc7feed817f
Reviewed-on: https://chromium-review.googlesource.com/746701
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513091}
[modify] https://crrev.com/64c79760b3a2669b47c34424e2d4cea3e29fc50a/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/64c79760b3a2669b47c34424e2d4cea3e29fc50a/base/test/launcher/test_launcher.h
[modify] https://crrev.com/64c79760b3a2669b47c34424e2d4cea3e29fc50a/content/public/test/test_launcher.cc
[modify] https://crrev.com/64c79760b3a2669b47c34424e2d4cea3e29fc50a/content/public/test/test_launcher.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01da0dd9546c88c518e0eb582b86f1efebb3522

commit d01da0dd9546c88c518e0eb582b86f1efebb3522
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 01 07:32:51 2017

Revise on-top window data collection for interative_ui_tests.

Tests in the interative_ui_tests fixture are known to timeout if there's
an always-on-top window on the desktop. This change introduces a few
improvements to the existing data collection strategy to help diagnose
the provenance of these always-on-top windows.

- Checks for always-on-top windows are moved out of the test child
  processes and up to the parent test proc. This is a more reliable
  place to log any info, as such log messages are more likely to make it
  into the main swarming log output. This is a result of the way
  GetTestOutputSnippet pulls what it thinks is the only relevant test
  output -- it drops messages emitted outside of the test body.

- Scans for always-on-top windows now take place before running any test
  in the shard and after any test that times out.

- A screen snapshot is saved if any always-on-top window is found, even
  in the case of dialogs that will be closed.

- An attempt is made to find and emit the command lines for all
  processes in the process hierarchy of the proc owning an always-on-top
  window.

- All details are emitted in a single log message. For example:

There is an always on top window on the desktop after this test timed out. This may have been caused by this test or a previous test and may cause flakes; window class name: ConsoleWindowClass; subprocess command line: "".\interactive_ui_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=AutofillInteractiveTest.AutofillViaClick --single_process --snapshot-output-dir="e:\b\s\w\iomhwbd8" --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\results6396_26680\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iomhwbd8\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\d6396_27306""; owning process lineage: (process_id: 2000, command_line: "C:\Windows\system32\cmd.exe /c ""C:\Users\chrome-bot\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\run_swarm_bot.bat" ""), (process_id: 1496, command_line: "C:\Windows\Explorer.EXE"); screen snapshot saved to file: "e:\b\s\w\iomhwbd8\ss_20171030114011_636.png";

BUG= 764415 
R=sky@chromium.org

Change-Id: I1aed3a41542680b197c7856e1f5d9ec9af6e3774
Reviewed-on: https://chromium-review.googlesource.com/737641
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513095}
[modify] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/BUILD.gn
[modify] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/always_on_top_window_killer_win.cc
[modify] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/always_on_top_window_killer_win.h
[modify] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/interactive_ui_tests_main.cc
[add] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/process_inspector_win.cc
[add] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/process_inspector_win.h
[add] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/save_desktop_snapshot_win.cc
[add] https://crrev.com/d01da0dd9546c88c518e0eb582b86f1efebb3522/chrome/test/base/save_desktop_snapshot_win.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63e53866bc20c8ba59107daaf90a7f205e39d90b

commit 63e53866bc20c8ba59107daaf90a7f205e39d90b
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 09 00:01:46 2017

Fix ui_controlsui_controls::internal::SendMouseMoveImpl on HiDPI.

Windows needs the location in screen coordinates rather than DIP.

Also:

- Added a timeout to ui_controls::internal::SendMouseMoveImpl so that an
  error message is logged and the callback is run after
  TestTimeout::action_timeout(). This helps protect against cases where
  another window is on top of the test window, or the mouse is moved
  into la la land where Windows doesn't call the test's hook proc.

- New logging in the guts of ui_controls_internal_win.cc will emit error
  messages when the mouse ends up in the wrong place following a call to
  ui_controls::internal::SendMouseMoveImpl.

- SendMouseMoveUITest.Probe has been added to interactive_ui_tests to
  verify some simple calls to controls::SendMouseMoveNotifyWhenDone.

BUG= 764415 
R=sky@chromium.org

Change-Id: I27d6ffad59635913b28ae41e1410f4d6461d3355
Reviewed-on: https://chromium-review.googlesource.com/753905
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515015}
[modify] https://crrev.com/63e53866bc20c8ba59107daaf90a7f205e39d90b/chrome/browser/ui/send_mouse_move_uitest_win.cc
[modify] https://crrev.com/63e53866bc20c8ba59107daaf90a7f205e39d90b/ui/base/BUILD.gn
[modify] https://crrev.com/63e53866bc20c8ba59107daaf90a7f205e39d90b/ui/base/test/ui_controls.h
[modify] https://crrev.com/63e53866bc20c8ba59107daaf90a7f205e39d90b/ui/base/test/ui_controls_internal_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f93c59e1a147f9914bb00a7dce9f34a29b4e1456

commit f93c59e1a147f9914bb00a7dce9f34a29b4e1456
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 09 10:17:02 2017

Add list_top_windows function to discover the class names of topmost windows.

BUG= 764415 , 781267 
R=maruel@chromium.org

Change-Id: I3279ca01a169635c9f5c770e887782c5ced79991
Reviewed-on: https://chromium-review.googlesource.com/756700
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/f93c59e1a147f9914bb00a7dce9f34a29b4e1456/appengine/swarming/swarming_bot/api/platforms/win.py
[modify] https://crrev.com/f93c59e1a147f9914bb00a7dce9f34a29b4e1456/appengine/swarming/swarming_bot/api/platforms/win_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd4e3a9b4d6469e2e191747bb00c3779d9d46e10

commit bd4e3a9b4d6469e2e191747bb00c3779d9d46e10
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 09 10:47:48 2017

Fix ui_controls::SendMouseEventsNotifyWhenDone.

r515015 broke ui_controls::internal::SendMouseEventsImpl such that the
callback was being run when any mouse event was seen by the hook rather
than when the one event of interest was seen.

This change also ensures that the new timeout added in r515015 only
fires for mouse move events and not for other types of mouse events.

BUG= 764415 
TBR=sky@chromium.org

Change-Id: I093fd3fe4037e86f5fe1905df9ec15589ce262a4
Reviewed-on: https://chromium-review.googlesource.com/758768
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515133}
[modify] https://crrev.com/bd4e3a9b4d6469e2e191747bb00c3779d9d46e10/ui/base/test/ui_controls_internal_win.cc

This is happening very often now and also blocks some CLs on CQ.

E.g. waterfall:
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/30942
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/30940

E.g. CQ:
https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/41881
https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/41840
https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/41884

Copying my comment from crbug.com/774959, which seems like the same issue:

This problem is an urgent issue, but the only people that are really looking at it at this point AFAICT are grt@ plus sheriffs, who don't have anything actionable to do. grt@ has clearly been putting in heroic effort, but maybe we need to get more resources on the challenge to supplement that effort?

blundell@, in fairness I've been working on this Thursday/Friday, pushed new swarming code explicitly to list all new top level windows and started gather data off thread. That's pure overhead for me.

See:
https://paste.googleplex.com/4816129943928832
https://paste.googleplex.com/5093152650166272
https://chrome-internal-review.googlesource.com/500952
https://chrome-internal-review.googlesource.com/500894

Apologies maruel@! My comment wasn't meant to reflect badly on the effort of anyone contributing and could have been better phrased as "Do we need to escalate this issue beyond individual volunteer contributions?"

Blocking a related bug on this one since this one seems to have the most investigation to date.

grt@, maruel@, do you need help on this?

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/?limit=200 is failing ~50% of builds right now and the associated tryserver's failing jobs often as noted above:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/?limit=200

Deleted: Screen Shot 2017-11-13 at 4.04.02 PM.png 809 KB

	Screen Shot 2017-11-13 at 4.04.02 PM.png 809 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55bc8681df27414e459c972affd317944156178

commit f55bc8681df27414e459c972affd317944156178
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 15 19:04:08 2017

Strip the topmost style from and minimize always-on-top windows.

Such windows lead to failures in interactive_ui_tests since
mouse events end up going to the wrong window.

BUG= 764415 

Change-Id: I2a74fcb3e448bf86d82b7f287c7129b6b2eba1ab
Reviewed-on: https://chromium-review.googlesource.com/771330
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516772}
[modify] https://crrev.com/f55bc8681df27414e459c972affd317944156178/chrome/test/base/always_on_top_window_killer_win.cc

Victory! Here are two runs after r516772 that passed after the CL above did its thing:

- Win7 Tests (1): https://chromium-swarm.appspot.com/task?id=39dabd6147eeb710&refresh=10&show_raw=1
- Win 7 Tests x64 (1): https://chromium-swarm.appspot.com/task?id=39da47a63ea47710&refresh=10&show_raw=1

The log output looks like this:

[1115/125448.960:ERROR:always_on_top_window_killer_win.cc(251)] There is an always on top window on the desktop. This may have been caused by a previous test and may cause this test to fail; window class name: ConsoleWindowClass; owning process lineage: (process_id: 2932, command_line: "C:\Windows\system32\cmd.exe /c ""C:\Users\chrome-bot\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\run_swarm_bot.bat" ""), (process_id: 1508, command_line: "C:\Windows\Explorer.EXE"); screen snapshot saved to file: "e:\b\swarm_slave\w\ioh4e0pn\ss_20171115125448_180.png";
[1115/125448.960:ERROR:always_on_top_window_killer_win.cc(258)] Stripped WS_EX_TOPMOST.
[1115/125449.219:ERROR:always_on_top_window_killer_win.cc(263)] Minimized window.

Excellent! I still think it's worth figuring out which test is triggering this. It would be very bad if we had some real code changing the top-most bit of a random window!

Agreed. I wonder if it's something specific to the way certain bots were set up? In one failure screenshot I looked at, it appeared that interactive_ui_tests was the first task post-reboot.

Ultimately, I think it would be good for the bot runner to use https://chromium.googlesource.com/infra/luci/luci-py.git/+/f93c59e1a147f9914bb00a7dce9f34a29b4e1456 before and after each task and self-ignite in cases where new topmost windows appear. I've filed issue 786112 as a feature request for the infra team to do something along these lines.

Awesome work Greg tracking down and fixing (or at least reliably working around) the source of this flakiness! Agree 100% with adding more infrastructure to catch these sorts of bugs in tests earlier.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420aa00b86f48a73f4de759049fec08a73f04d59

commit 420aa00b86f48a73f4de759049fec08a73f04d59
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 22 11:25:10 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 248683 , 764415 
This CL was uploaded by git cl split.

R=treib@chromium.org

Change-Id: Ib5788e422101becf2c7c834c9d83df1c0a4e4551
Reviewed-on: https://chromium-review.googlesource.com/785012
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518607}
[modify] https://crrev.com/420aa00b86f48a73f4de759049fec08a73f04d59/chrome/browser/ui/search/instant_extended_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad9e8df04eeb520cba3caae93b6fde9e1f77c99f

commit ad9e8df04eeb520cba3caae93b6fde9e1f77c99f
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 22 13:21:08 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 639072 , 764415 
This CL was uploaded by git cl split.

R=finnur@chromium.org

Change-Id: Ia165545395e8b1a2826508e759e11ce6777b7f1e
Reviewed-on: https://chromium-review.googlesource.com/784939
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518621}
[modify] https://crrev.com/ad9e8df04eeb520cba3caae93b6fde9e1f77c99f/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de3ca1335e0136092256b81cd3da9800c6d9c664

commit de3ca1335e0136092256b81cd3da9800c6d9c664
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 22 16:28:35 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 638692 , 764415 
This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Change-Id: I6990772d1394cdb57545d818bd1c54af19f80c61
Reviewed-on: https://chromium-review.googlesource.com/784935
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518652}
[modify] https://crrev.com/de3ca1335e0136092256b81cd3da9800c6d9c664/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9ff92d24501a9b03e86649c6d68b254d8fead93

commit f9ff92d24501a9b03e86649c6d68b254d8fead93
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Nov 22 19:33:06 2017

Revert "Enable interactive_ui_tests on Windows that now run mostly reliably."

This reverts commit de3ca1335e0136092256b81cd3da9800c6d9c664.

Reason for revert: Still flaking, https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64778

Original change's description:
> Enable interactive_ui_tests on Windows that now run mostly reliably.
> 
> r516772 was the last of many commits that resolved a number of problems
> that made this test suite flaky on Windows. This CL enables tests that
> had been disabled over time due to flakes, yet now seem to run okay.
> 
> BUG= 638692 , 764415 
> This CL was uploaded by git cl split.
> 
> R=​rdevlin.cronin@chromium.org
> 
> Change-Id: I6990772d1394cdb57545d818bd1c54af19f80c61
> Reviewed-on: https://chromium-review.googlesource.com/784935
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518652}

TBR=rdevlin.cronin@chromium.org,grt@chromium.org

Change-Id: I8bce2de5ecd0c7a60cc383b447970a95423b3c96
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  638692 ,  764415 
Reviewed-on: https://chromium-review.googlesource.com/786450
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518709}
[modify] https://crrev.com/f9ff92d24501a9b03e86649c6d68b254d8fead93/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c40e261b17bb39c3b892a3a9e18da42e3fcd766

commit 2c40e261b17bb39c3b892a3a9e18da42e3fcd766
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 13:30:34 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 152938 ,330735, 401226 , 764415 
This CL was uploaded by git cl split.

R=pkasting@chromium.org

Change-Id: I87b38ec262e7ada41a3ebbcb6c246660ff030371
Reviewed-on: https://chromium-review.googlesource.com/784970
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518914}
[modify] https://crrev.com/2c40e261b17bb39c3b892a3a9e18da42e3fcd766/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] https://crrev.com/2c40e261b17bb39c3b892a3a9e18da42e3fcd766/chrome/browser/ui/views/menu_view_drag_and_drop_test.cc
[modify] https://crrev.com/2c40e261b17bb39c3b892a3a9e18da42e3fcd766/chrome/browser/ui/views/status_icons/status_tray_state_changer_interactive_uitest_win.cc
[modify] https://crrev.com/2c40e261b17bb39c3b892a3a9e18da42e3fcd766/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd56789ee1a5921ba7e03f0016a78c0087679344

commit cd56789ee1a5921ba7e03f0016a78c0087679344
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 13:42:14 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 404081 , 764415 
This CL was uploaded by git cl split.

R=benwells@chromium.org

Change-Id: I6f56e0ee9188bcb1010139affaa460fc09a75932
Reviewed-on: https://chromium-review.googlesource.com/785014
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518915}
[modify] https://crrev.com/cd56789ee1a5921ba7e03f0016a78c0087679344/chrome/browser/apps/app_window_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f10757f5713ddc59a5984483d9e84cd2f48ecbb5

commit f10757f5713ddc59a5984483d9e84cd2f48ecbb5
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 13:47:39 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 523255 , 764415 
This CL was uploaded by git cl split.

R=vasilii@chromium.org

Change-Id: I3719b484665392cd463718ad6c96ba9a43bdffea
Reviewed-on: https://chromium-review.googlesource.com/784852
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518918}
[modify] https://crrev.com/f10757f5713ddc59a5984483d9e84cd2f48ecbb5/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34630cd2bb480673e895c9e8165f345e59ead397

commit 34630cd2bb480673e895c9e8165f345e59ead397
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 14:01:19 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 154081 , 179063 , 171080 , 764415 
This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Change-Id: I6a6ac9f113640b052335264d4480051f5214092b
Reviewed-on: https://chromium-review.googlesource.com/784940
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518920}
[modify] https://crrev.com/34630cd2bb480673e895c9e8165f345e59ead397/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b171f0812568242be1e624c59606af5516e5f0

commit e3b171f0812568242be1e624c59606af5516e5f0
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 14:13:29 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 428813 , 764415 
This CL was uploaded by git cl split.

R=rockot@chromium.org

Change-Id: If33418b22d554550ed735ee2a74eab2505cdeec5
Reviewed-on: https://chromium-review.googlesource.com/785011
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518924}
[modify] https://crrev.com/e3b171f0812568242be1e624c59606af5516e5f0/chrome/browser/extensions/extension_commands_global_registry_apitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f55e04aa736d5d248dc5110d446839c8bf1ab81

commit 2f55e04aa736d5d248dc5110d446839c8bf1ab81
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 14:16:05 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 69034 , 169414 , 764415 
This CL was uploaded by git cl split.

R=bsep@chromium.org

Change-Id: I59cd5076561cc9a606d42af649bfa879824afab6
Reviewed-on: https://chromium-review.googlesource.com/784972
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518925}
[modify] https://crrev.com/2f55e04aa736d5d248dc5110d446839c8bf1ab81/chrome/browser/ui/views/frame/browser_view_focus_uitest.cc
[modify] https://crrev.com/2f55e04aa736d5d248dc5110d446839c8bf1ab81/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d001a8e3559ecf04ba551c959cc1ca3c8c4d37

commit 43d001a8e3559ecf04ba551c959cc1ca3c8c4d37
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 23 14:39:26 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG=704994, 764415 
This CL was uploaded by git cl split.

R=creis@chromium.org

Change-Id: I698b49d69eabe7eaa2b1c14882d329699b037600
Reviewed-on: https://chromium-review.googlesource.com/785017
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518934}
[modify] https://crrev.com/43d001a8e3559ecf04ba551c959cc1ca3c8c4d37/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25dd42daf3cf68126cab769ff445922867bfb54

commit f25dd42daf3cf68126cab769ff445922867bfb54
Author: Greg Thompson <grt@chromium.org>
Date: Mon Nov 27 09:14:48 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG=515717, 639130 , 764415 
This CL was uploaded by git cl split.

R=jyasskin@chromium.org

Change-Id: I76dc53552364b7f12fb2890663c3e680461b6b7e
Reviewed-on: https://chromium-review.googlesource.com/784938
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519249}
[modify] https://crrev.com/f25dd42daf3cf68126cab769ff445922867bfb54/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/358f5e461f4cc41ecba17328de6fec21e2fdbb81

commit 358f5e461f4cc41ecba17328de6fec21e2fdbb81
Author: Greg Thompson <grt@chromium.org>
Date: Mon Nov 27 09:37:11 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG=50025, 62538 , 62539 , 62542 , 69034 , 764415 
This CL was uploaded by git cl split.

R=tapted@chromium.org

Change-Id: I4a0fe6caa509e478ace54180b2872c625208039b
Reviewed-on: https://chromium-review.googlesource.com/785010
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519253}
[modify] https://crrev.com/358f5e461f4cc41ecba17328de6fec21e2fdbb81/chrome/browser/ui/browser_focus_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b6453f3bb36e3e267748ad0c80428a4de952ce

commit 41b6453f3bb36e3e267748ad0c80428a4de952ce
Author: Greg Thompson <grt@chromium.org>
Date: Tue Nov 28 07:58:32 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 270341 , 764415 
This CL was uploaded by git cl split.

R=estade@chromium.org

Change-Id: Icae952c0dc3b19b48bbe7add14b84d5d4710b256
Reviewed-on: https://chromium-review.googlesource.com/784971
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519602}
[modify] https://crrev.com/41b6453f3bb36e3e267748ad0c80428a4de952ce/chrome/browser/autofill/autofill_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4113a5c37315e331c50c97929444ce19916a8439

commit 4113a5c37315e331c50c97929444ce19916a8439
Author: Greg Thompson <grt@chromium.org>
Date: Tue Nov 28 08:29:57 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 638692 , 764415 , 788112 
This CL was uploaded by git cl split.

Change-Id: I241701b1e72a6bbddb1051181235cd43e566393f
Reviewed-on: https://chromium-review.googlesource.com/787230
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519608}
[modify] https://crrev.com/4113a5c37315e331c50c97929444ce19916a8439/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07da32342ed9fad2edae65bbb9bf09751c063261

commit 07da32342ed9fad2edae65bbb9bf09751c063261
Author: Greg Thompson <grt@chromium.org>
Date: Tue Nov 28 08:32:13 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 581131 , 764415 
This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Change-Id: I8021f3269bad9ae31380fee984dea4804733dafd
Reviewed-on: https://chromium-review.googlesource.com/785016
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519609}
[modify] https://crrev.com/07da32342ed9fad2edae65bbb9bf09751c063261/extensions/browser/app_window/app_window_interactive_uitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c84f006611ce46d7c719cdab6a0494c0347d63

commit f2c84f006611ce46d7c719cdab6a0494c0347d63
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 29 01:15:35 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 504054 , 764415 
This CL was uploaded by git cl split.

R=lazyboy@chromium.org

Change-Id: Ibcd290d03dbfb923077ee542c24b06fdb9f21e2b
Reviewed-on: https://chromium-review.googlesource.com/784851
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519942}
[modify] https://crrev.com/f2c84f006611ce46d7c719cdab6a0494c0347d63/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abae8b0a785a7edfd52a26023738c3aaabc18dfe

commit abae8b0a785a7edfd52a26023738c3aaabc18dfe
Author: Greg Thompson <grt@chromium.org>
Date: Wed Nov 29 13:41:35 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

https://crrev.com/516772 was the last of many commits that resolved a
number of problems that made this test suite flaky on Windows. This CL
enables tests that had been disabled over time due to flakes, yet now
seem to run okay.

BUG= 135115 , 137486 , 146006 , 146666 , 158762 , 159000 , 764415 
This CL was uploaded by git cl split.

R=scheib@chromium.org

Change-Id: I0521ac36ad13c41a0700aa9ffd061e3a606dc0fb
Reviewed-on: https://chromium-review.googlesource.com/785015
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520095}
[modify] https://crrev.com/abae8b0a785a7edfd52a26023738c3aaabc18dfe/chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
[modify] https://crrev.com/abae8b0a785a7edfd52a26023738c3aaabc18dfe/chrome/browser/ui/exclusive_access/fullscreen_controller_state_interactive_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e782b7e85f9cf3d98dfed9c7286c06ee10fdfa6

commit 6e782b7e85f9cf3d98dfed9c7286c06ee10fdfa6
Author: Greg Thompson <grt@chromium.org>
Date: Mon Dec 04 16:27:42 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 421116 , 764415 
This CL was uploaded by git cl split.

R=aleventhal@chromium.org

Change-Id: I4a673a21eaab43d7dbce3bc121bd7cb8a704b3ba
Reviewed-on: https://chromium-review.googlesource.com/785013
Commit-Queue: Greg Thompson <grt@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521361}
[modify] https://crrev.com/6e782b7e85f9cf3d98dfed9c7286c06ee10fdfa6/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9d9d359af190d26ce47164e72bb9413d80fe1e2

commit b9d9d359af190d26ce47164e72bb9413d80fe1e2
Author: Greg Thompson <grt@chromium.org>
Date: Mon Dec 04 19:47:37 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG=499858, 764415 
This CL was uploaded by git cl split.

R=sky@chromium.org

Change-Id: Ic884babd5f4814fdf173a18fe91c6e71ce828f92
Reviewed-on: https://chromium-review.googlesource.com/785018
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521414}
[modify] https://crrev.com/b9d9d359af190d26ce47164e72bb9413d80fe1e2/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27a829dfbd71ab52e4f8f5baf256200e69a5c5b0

commit 27a829dfbd71ab52e4f8f5baf256200e69a5c5b0
Author: Greg Thompson <grt@chromium.org>
Date: Mon Dec 04 19:47:56 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG=69475, 129235 , 147579 ,419468, 764415 
This CL was uploaded by git cl split.

R=sky@chromium.org

Change-Id: I99053d0c38c27a0ad91b426214bff6365c3b4a5e
Reviewed-on: https://chromium-review.googlesource.com/784934
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521415}
[modify] https://crrev.com/27a829dfbd71ab52e4f8f5baf256200e69a5c5b0/chrome/browser/browser_keyevents_browsertest.cc
[modify] https://crrev.com/27a829dfbd71ab52e4f8f5baf256200e69a5c5b0/chrome/browser/mouseleave_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1ccd58125c75660a7790724ea5faed78a055d0c

commit e1ccd58125c75660a7790724ea5faed78a055d0c
Author: Greg Thompson <grt@chromium.org>
Date: Mon Dec 04 19:49:53 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 133341 ,751031, 751543 , 764415 , 789913 
This CL was uploaded by git cl split.

R=sky@chromium.org

Change-Id: I753c741a9194f489f072cd86d72407a1294150c3
Reviewed-on: https://chromium-review.googlesource.com/784937
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521416}
[modify] https://crrev.com/e1ccd58125c75660a7790724ea5faed78a055d0c/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ac914c0806c5885ef112f621b5ae62d13fdbf3

commit 16ac914c0806c5885ef112f621b5ae62d13fdbf3
Author: Greg Thompson <grt@chromium.org>
Date: Tue Dec 05 10:24:50 2017

Revert "Enable interactive_ui_tests on Windows that now run mostly reliably."

This reverts commit e1ccd58125c75660a7790724ea5faed78a055d0c.

Reason for revert: Widespread "Check failed: false. Observers can only be added once!" failures.

Original change's description:
> Enable interactive_ui_tests on Windows that now run mostly reliably.
> 
> r516772 was the last of many commits that resolved a number of problems
> that made this test suite flaky on Windows. This CL enables tests that
> had been disabled over time due to flakes, yet now seem to run okay.
> 
> BUG= 133341 ,751031, 751543 , 764415 , 789913 
> This CL was uploaded by git cl split.
> 
> R=​sky@chromium.org
> 
> Change-Id: I753c741a9194f489f072cd86d72407a1294150c3
> Reviewed-on: https://chromium-review.googlesource.com/784937
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521416}

TBR=sky@chromium.org,grt@chromium.org

Change-Id: I33b192c628fdfebe9cfd93b71abd3b394faad9e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  133341 , 751031,  751543 ,  764415 ,  789913 
Reviewed-on: https://chromium-review.googlesource.com/808204
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521652}
[modify] https://crrev.com/16ac914c0806c5885ef112f621b5ae62d13fdbf3/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc