New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764413 link

Starred by 2 users
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 752547



Sign in to add a comment

Track which features are enabled on chrome://interventions

Project Member Reported by ryansturm@chromium.org, Sep 12 2017 
The various intervention features and parameters that are set for the chrome session should be exposed on chrome://interventions. Ideally, the source of why a feature is enabled would be exposed as well (field trial vs flag), but this is impossible in some cases.

Comment 1 by ryansturm@chromium.org, Sep 12 2017

Blockedon: 752547

Comment 2 by ryansturm@chromium.org, Sep 12 2017

Blocking: 752547

Comment 3 by ryansturm@chromium.org, Sep 12 2017

Blockedon: -752547
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c

commit bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c
Author: Thanh Le <thanhdle@chromium.org>
Date: Fri Sep 22 21:38:36 2017

Use mojo to communicate between Javascript and C++.

Displays basic previews status on chrome://interventions-internals. Right now it
is only displaying Offline Previews' status. Functionalities and tests for C++ code will be
in future CLs.

Added tests for the basic JavaScript method for displaying previews'
enabled/disabled status.

Bug:  764413 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id943304b28cd6fb64f0e1ed72a12e392d7cfda8e
Reviewed-on: https://chromium-review.googlesource.com/671499
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503862}
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/BUILD.gn
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/resources/interventions_internals/index.html
[add] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/BUILD.gn
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/OWNERS
[add] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[add] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[add] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.h
[modify] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/bbaa6e52b6185a4aa7abe8a3ef76bacc0ec8ac1c/chrome/test/data/webui/interventions_internals_browsertest.js
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4731f0a33247230fc9ef47a6a08ed362d24d3691

commit 4731f0a33247230fc9ef47a6a08ed362d24d3691
Author: Thanh Le <thanhdle@chromium.org>
Date: Fri Sep 29 02:43:38 2017

Displaying different Previews modes enabled/disabled statuses on chrome://interventions-internals.

Bug:  764413 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I37d9046c98e3c94030a87484249f6de20687eda1
Reviewed-on: https://chromium-review.googlesource.com/679743
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505265}
[modify] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[modify] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[add] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/test/BUILD.gn
[modify] https://crrev.com/4731f0a33247230fc9ef47a6a08ed362d24d3691/chrome/test/data/webui/interventions_internals_browsertest.js

Comment 6 by thanhdle@chromium.org, Sep 29 2017

Cc: ryansturm@chromium.org
Status: Fixed (was: Assigned)

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment