New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 752547



Sign in to add a comment

Add A ChromePreviewsLog Object and record events from previews/

Project Member Reported by ryansturm@chromium.org, Sep 12 2017

Issue description

A ChromePreviewsLog object that should be accessible throughout the Previews code as PreviewsLog. This Log will track various events and changes to the blacklist. This log will be the source of information for chrome://interventions.
 
Blocking: 752547

Comment 2 by bengr@chromium.org, Sep 14 2017

Labels: -Pri-2 Pri-3
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fcc2833e80d07d8cc7bb1da734323204527ca56

commit 1fcc2833e80d07d8cc7bb1da734323204527ca56
Author: Thanh Le <thanhdle@chromium.org>
Date: Tue Oct 03 14:10:06 2017

Create PreviewsLog object that will be used to post log messages on chrome://interventions-internals.

Bug:  764409 
Change-Id: I6ad2181cb389c67dc39220340d136cf13996cc7c
Reviewed-on: https://chromium-review.googlesource.com/687974
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506023}
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/BUILD.gn
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_black_list.cc
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_black_list.h
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_io_data.cc
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_io_data.h
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_io_data_unittest.cc
[add] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_log.cc
[add] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_log.h
[add] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_log_unittest.cc
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_ui_service.cc
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_ui_service.h
[modify] https://crrev.com/1fcc2833e80d07d8cc7bb1da734323204527ca56/components/previews/core/previews_ui_service_unittest.cc

Status: Fixed (was: Assigned)

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment