New issue
Advanced search Search tips

Issue 764401 link

Starred by 1 user
Status: Fixed
Owner:
smcgruer@chromium.org
Closed: Oct 2017
Cc:
majidvp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

cc::ElementAnimations - remove needs_push_properties_

Project Member Reported by smcgruer@chromium.org, Sep 12 2017 
cc::ElementAnimations tracks two booleans, needs_push_properties_  and needs_update_impl_client_state_. However, the latter being true implies the former (since SetNeedsUpdateImplClientState() calls SetNeedsPushProperties()), and only when both are true does ElementAnimations::PushPropertiesTo actually do anything.

Therefore, we could simplify this logic as follows:

1. Remove needs_push_properties_
2. Get rid of calls to ElementAnimations::SetNeedsPushProperties and remove the method.
3. Have ElementAnimations::PushPropertiesTo only check needs_update_impl_client_state_
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab2a46aeaf0537d90136b2604245a01923347c27

commit ab2a46aeaf0537d90136b2604245a01923347c27
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Oct 03 20:08:28 2017

Fix usage of needs_push_properties_ in cc::ElementAnimations

Before this patch needs_update_impl_client_state_ implied
needs_push_properties_, and PushPropertiesTo only had effect if
needs_update_impl_client_state_ was set. This meant that the
needs_push_properties_ boolean bit had no actual effect.

To fix this, the old needs_push_properties_ was removed. The
needs_update_impl_client_state_ bit was renamed to
needs_push_properties_ in its place.

Bug:  764401 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I29cc02a81b91096cdb90f57dbe059d52cc98ba37
Reviewed-on: https://chromium-review.googlesource.com/664097
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506151}
[modify] https://crrev.com/ab2a46aeaf0537d90136b2604245a01923347c27/cc/animation/animation_player.cc
[modify] https://crrev.com/ab2a46aeaf0537d90136b2604245a01923347c27/cc/animation/animation_ticker.cc
[modify] https://crrev.com/ab2a46aeaf0537d90136b2604245a01923347c27/cc/animation/element_animations.cc
[modify] https://crrev.com/ab2a46aeaf0537d90136b2604245a01923347c27/cc/animation/element_animations.h
[modify] https://crrev.com/ab2a46aeaf0537d90136b2604245a01923347c27/cc/test/animation_timelines_test_common.cc

Comment 2 by smcgruer@chromium.org, Oct 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment