New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 764398 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Panic in audit app due to error while unmarshaling gerrit response

Project Member Reported by robert...@chromium.org, Sep 12 2017 
Some rule panicked while auditing c1dd5bd181b2f3ff26bba13ffabc357de7bc9a9f with message: failed to decode Gerrit response into *gerrit.Change: json: cannot unmarshal object into Go struct field Change.reviewers of type []gerrit.AccountInfo
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/69e80424a538b02f7843d6b9c42dacf79186e287

commit 69e80424a538b02f7843d6b9c42dacf79186e287
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Sep 12 23:12:27 2017

gerrit api: Fix bad assumption about reviewers format.

It turns out that the reviewers field is not a list of accounts, but a
map that maps reviewer type (CC/REVIEWER/REMOVED) to a list of accounts.

R=tandrii,iannucci
BUG= 764398 

Change-Id: I5b5f353e87ef8d77f1a0fd2ebb0c44ac2c56dbb9
Reviewed-on: https://chromium-review.googlesource.com/663213
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/69e80424a538b02f7843d6b9c42dacf79186e287/common/api/gerrit/gerrit.go
[modify] https://crrev.com/69e80424a538b02f7843d6b9c42dacf79186e287/common/api/gerrit/gerrit_test.go

Comment 2 by robert...@chromium.org, Sep 12 2017

Status: Started (was: Untriaged)

Comment 3 by robert...@chromium.org, Sep 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment