New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 764386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add support for filtering by Pixel phones only

Project Member Reported by khorimoto@chromium.org, Sep 12 2017

Issue description

This will be needed by workaround flows for Android-side Bluetooth issues.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e761dc6d0ba00a758d387aebe24377a1d18560

commit 70e761dc6d0ba00a758d387aebe24377a1d18560
Author: Kyle Horimoto <khorimoto@google.com>
Date: Tue Sep 12 22:04:34 2017

[CrOS Tether] Add support for filtering by Pixel-only phones.

This will be used to work around Android Bluetooth bugs.

Bug:  764386 , 672263
Change-Id: I0e13a94c50c9c91e9f6957917f595ed30a76b7d1
Reviewed-on: https://chromium-review.googlesource.com/663206
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501421}
[modify] https://crrev.com/70e761dc6d0ba00a758d387aebe24377a1d18560/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/70e761dc6d0ba00a758d387aebe24377a1d18560/components/cryptauth/cryptauth_device_manager.h
[modify] https://crrev.com/70e761dc6d0ba00a758d387aebe24377a1d18560/components/cryptauth/cryptauth_device_manager_unittest.cc
[modify] https://crrev.com/70e761dc6d0ba00a758d387aebe24377a1d18560/components/cryptauth/proto/cryptauth_api.proto

Labels: Merge-Request-61 Merge-Request-62
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 12 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ketakid@google.com, Sep 13 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.

Comment 5 by ketakid@google.com, Sep 13 2017

Labels: -Merge-Request-62 Merge-Approved-62
Approving merge to M62.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 13 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31fa3a302edf8b89009ddafc20a8a1d9ac939faa

commit 31fa3a302edf8b89009ddafc20a8a1d9ac939faa
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Sep 13 01:39:35 2017

[CrOS Tether] Add support for filtering by Pixel-only phones.

This will be used to work around Android Bluetooth bugs.

TBR=khorimoto@google.com

(cherry picked from commit 70e761dc6d0ba00a758d387aebe24377a1d18560)

Bug:  764386 , 672263
Change-Id: I0e13a94c50c9c91e9f6957917f595ed30a76b7d1
Reviewed-on: https://chromium-review.googlesource.com/663206
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501421}
Reviewed-on: https://chromium-review.googlesource.com/663304
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#191}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/31fa3a302edf8b89009ddafc20a8a1d9ac939faa/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/31fa3a302edf8b89009ddafc20a8a1d9ac939faa/components/cryptauth/cryptauth_device_manager.h
[modify] https://crrev.com/31fa3a302edf8b89009ddafc20a8a1d9ac939faa/components/cryptauth/cryptauth_device_manager_unittest.cc
[modify] https://crrev.com/31fa3a302edf8b89009ddafc20a8a1d9ac939faa/components/cryptauth/proto/cryptauth_api.proto

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 13 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a53e1a5bad449bbbf44c867fcf58615f758c3ce4

commit a53e1a5bad449bbbf44c867fcf58615f758c3ce4
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Sep 13 01:41:58 2017

[CrOS Tether] Add support for filtering by Pixel-only phones.

This will be used to work around Android Bluetooth bugs.

TBR=khorimoto@google.com

(cherry picked from commit 70e761dc6d0ba00a758d387aebe24377a1d18560)

Bug:  764386 , 672263
Change-Id: I0e13a94c50c9c91e9f6957917f595ed30a76b7d1
Reviewed-on: https://chromium-review.googlesource.com/663206
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501421}
Reviewed-on: https://chromium-review.googlesource.com/663979
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1181}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/a53e1a5bad449bbbf44c867fcf58615f758c3ce4/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/a53e1a5bad449bbbf44c867fcf58615f758c3ce4/components/cryptauth/cryptauth_device_manager.h
[modify] https://crrev.com/a53e1a5bad449bbbf44c867fcf58615f758c3ce4/components/cryptauth/cryptauth_device_manager_unittest.cc
[modify] https://crrev.com/a53e1a5bad449bbbf44c867fcf58615f758c3ce4/components/cryptauth/proto/cryptauth_api.proto

Status: Started (was: Fixed)
Need to land https://chromium-review.googlesource.com/c/chromium/src/+/669393 to finish this.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8ff8d0242f203aba0b2ab1100b92e13c452a1b

commit fb8ff8d0242f203aba0b2ab1100b92e13c452a1b
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Sep 16 03:13:18 2017

[CrOS Tether] Add new device properties to chrome://proximity-auth.

This CL adds the 'supportsArcPlusPlus' and 'isPixelPhone' properties to
devices displayed in the ProximityAuth debug page.

Bug:  764386 , 672263
Change-Id: Ia8a12438fcffdb9c6daabbea13a59ece3927e101
Reviewed-on: https://chromium-review.googlesource.com/669393
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502480}
[modify] https://crrev.com/fb8ff8d0242f203aba0b2ab1100b92e13c452a1b/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/fb8ff8d0242f203aba0b2ab1100b92e13c452a1b/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/fb8ff8d0242f203aba0b2ab1100b92e13c452a1b/components/proximity_auth/webui/resources/proximity_auth.html
[modify] https://crrev.com/fb8ff8d0242f203aba0b2ab1100b92e13c452a1b/components/proximity_auth/webui/resources/proximity_auth.js

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c19196205415afd191b9d90cf1e80ea553b1d00e

commit c19196205415afd191b9d90cf1e80ea553b1d00e
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Sep 16 03:51:31 2017

[CrOS Tether] Add new device properties to chrome://proximity-auth.

This CL adds the 'supportsArcPlusPlus' and 'isPixelPhone' properties to
devices displayed in the ProximityAuth debug page.

TBR=khorimoto@google.com

(cherry picked from commit fb8ff8d0242f203aba0b2ab1100b92e13c452a1b)

Bug:  764386 , 672263
Change-Id: Ia8a12438fcffdb9c6daabbea13a59ece3927e101
Reviewed-on: https://chromium-review.googlesource.com/669393
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502480}
Reviewed-on: https://chromium-review.googlesource.com/669703
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#273}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/c19196205415afd191b9d90cf1e80ea553b1d00e/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/c19196205415afd191b9d90cf1e80ea553b1d00e/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/c19196205415afd191b9d90cf1e80ea553b1d00e/components/proximity_auth/webui/resources/proximity_auth.html
[modify] https://crrev.com/c19196205415afd191b9d90cf1e80ea553b1d00e/components/proximity_auth/webui/resources/proximity_auth.js

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e38484443351006b052d2e1900b79fa27ffddd11

commit e38484443351006b052d2e1900b79fa27ffddd11
Author: Kyle Horimoto <khorimoto@google.com>
Date: Sat Sep 16 03:53:21 2017

[CrOS Tether] Add new device properties to chrome://proximity-auth.

This CL adds the 'supportsArcPlusPlus' and 'isPixelPhone' properties to
devices displayed in the ProximityAuth debug page.

TBR=khorimoto@google.com

(cherry picked from commit fb8ff8d0242f203aba0b2ab1100b92e13c452a1b)

Bug:  764386 , 672263
Change-Id: Ia8a12438fcffdb9c6daabbea13a59ece3927e101
Reviewed-on: https://chromium-review.googlesource.com/669393
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502480}
Reviewed-on: https://chromium-review.googlesource.com/670159
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1217}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e38484443351006b052d2e1900b79fa27ffddd11/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/e38484443351006b052d2e1900b79fa27ffddd11/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/e38484443351006b052d2e1900b79fa27ffddd11/components/proximity_auth/webui/resources/proximity_auth.html
[modify] https://crrev.com/e38484443351006b052d2e1900b79fa27ffddd11/components/proximity_auth/webui/resources/proximity_auth.js

Status: Fixed (was: Started)

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 15 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment