New issue
Advanced search Search tips

Issue 764382 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 763906


Show other hotlists

Hotlists containing this issue:
Payment-Conversion


Sign in to add a comment

[Payments] Address fields should be [non-]required according to libaddressinput

Project Member Reported by ma...@chromium.org, Sep 12 2017

Issue description

On Desktop and iOS, most fields are marked as required. libaddressinput provides a way to know which fields should be required or not. 

See https://cs.chromium.org/chromium/src/third_party/libaddressinput/src/cpp/include/libaddressinput/address_metadata.h?rcl=4d18a0d4be9add0dc479e7b939ed8d39f6ec0d73&l=28
 
Incidentally, we're already doing the right thing in other places--PaymentsProfileComparator uses HasAllRequiredFields under the hood, so everything should work correctly on the lists. I think this is just an editors bug.

Comment 4 by ma...@chromium.org, Sep 14 2017

Labels: Merge-Request-62
Requesting merge for the desktop part that landed.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3377188173fb5bdbe64751f70f34353acc3b3d82

commit 3377188173fb5bdbe64751f70f34353acc3b3d82
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Thu Sep 14 14:16:08 2017

[Payment Request] Correctly marks the required fields in the address editor

Bug:  764382 
Change-Id: I9f4c5ddb86409e6ac36d85813a105ca365ba7baa
Reviewed-on: https://chromium-review.googlesource.com/666078
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501943}
[modify] https://crrev.com/3377188173fb5bdbe64751f70f34353acc3b3d82/ios/chrome/browser/ui/payments/address_edit_mediator.mm

Project Member

Comment 6 by sheriffbot@chromium.org, Sep 14 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Less than 29 days to go before AppStore submit on M62
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Has this already been verified and confirmed in Canary? 

Comment 8 by ma...@chromium.org, Sep 14 2017

Yes this is verified, here's the screenshot showing "CEDEX" as a non-required field in Canary.
addresseditor.png
22.1 KB View Download
Labels: -Merge-Review-62 Merge-Approved-62
Approving merge to M62. Branch:3202
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 18 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2f7c285073b49c0a7c25ac2dbdcccaab996ec7

commit 7e2f7c285073b49c0a7c25ac2dbdcccaab996ec7
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Sep 18 13:04:24 2017

[Payments] Mark fields as required/non-required properly in shipping editor

TBR=mathp@chromium.org

(cherry picked from commit aabe10c125cb3a348b159196a6cfe909318d7ca7)

Bug:  764382 
Change-Id: Ife477677e89c55257ba0cf537dedb0000e8c7d54
Reviewed-on: https://chromium-review.googlesource.com/663559
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501387}
Reviewed-on: https://chromium-review.googlesource.com/670983
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#282}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/7e2f7c285073b49c0a7c25ac2dbdcccaab996ec7/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/7e2f7c285073b49c0a7c25ac2dbdcccaab996ec7/components/autofill/core/browser/address_i18n.cc
[modify] https://crrev.com/7e2f7c285073b49c0a7c25ac2dbdcccaab996ec7/components/autofill/core/browser/address_i18n.h
[modify] https://crrev.com/7e2f7c285073b49c0a7c25ac2dbdcccaab996ec7/components/autofill/core/browser/address_i18n_unittest.cc

Comment 11 by ma...@chromium.org, Sep 18 2017

Status: Fixed (was: Started)
This is verified on iOS Dev 63.0.3219.0. Here's the screenshot showing "CEDEX" as a non-required field.

ios.jpg
119 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d2b2131f037bb1067fd65afe85f5f2653e0e62

commit d2d2b2131f037bb1067fd65afe85f5f2653e0e62
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Wed Sep 20 19:14:22 2017

[Payment Request] Correctly marks the required fields in the address editor

Bug:  764382 
Change-Id: I9f4c5ddb86409e6ac36d85813a105ca365ba7baa
Reviewed-on: https://chromium-review.googlesource.com/666078
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501943}(cherry picked from commit 3377188173fb5bdbe64751f70f34353acc3b3d82)
Reviewed-on: https://chromium-review.googlesource.com/676103
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#361}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/d2d2b2131f037bb1067fd65afe85f5f2653e0e62/ios/chrome/browser/ui/payments/address_edit_mediator.mm

Issue 763906 has been merged into this issue.
Verified in 62.0.3202.35 in iPad Air(iOS11) and iPhone 7 plus(iOS 10.3.3)

The CEDEX field exist in the form and is shown as a non-required field

Link to Screenshot:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8aVgxMHRzUS1LMm8/view?usp=sharing

Labels: TE-Verified-62.0.3202.38 TE-Verified-M62
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using Chrome beta version #62.0.3202.38 as per the merged issue: 763906
Attaching screen shot for reference.
Observed that "CEDEX" is shown as a non-required field.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
cedex.jpg
222 KB View Download
Status: Verified (was: Fixed)

Sign in to add a comment