New issue
Advanced search Search tips

Issue 764380 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Scrub more logs collected from the crash_reporter for potentially sensitive data

Project Member Reported by ddavenp...@chromium.org, Sep 12 2017

Issue description

Kernel logs are already scrubbed. Refactor the scrubbing code such that the log collected through GetLogContents also gets scrubbed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d

commit 1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d
Author: Drew Davenport <ddavenport@chromium.org>
Date: Sat Sep 16 04:25:41 2017

crash: Scrub logs for some sensitive data

Move StripSensitiveData into CrashCollector class and pass
logs collected via CrashCollector::GetLogContents through it.

TEST=FEATURES=test emerge-snappy crash-reporter
TEST=induce a crash on DUT and verify log exists
BUG= chromium:764380 

Change-Id: Idb6ddded099d17514cc5b38ad1c96142a6b74e1b
Reviewed-on: https://chromium-review.googlesource.com/663205
Commit-Ready: Drew Davenport <ddavenport@chromium.org>
Tested-by: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/crash_reporter_logs.conf
[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/kernel_collector.cc
[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/kernel_collector.h
[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/crash_collector_test.cc
[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/kernel_collector_test.cc
[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/crash_collector.cc
[modify] https://crrev.com/1b6f9d13533b0983625e09b1a5c6c3e57a47bd9d/crash-reporter/crash_collector.h

Status: Fixed (was: Assigned)

Sign in to add a comment