New issue
Advanced search Search tips

Issue 764368 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Make Blink Python style consistent with Chromium

Project Member Reported by qyears...@chromium.org, Sep 12 2017

Issue description

Context: https://crrev.com/c/660978

With Blink C++ style merging with Chromium style, and with the code move to third_party/blink, it's probably also a good time to get rid of the Blink-specific style rules for Python.

As noted in: https://www.chromium.org/blink/coding-style

[Blink Python style] differs from Chromium coding style in three respects:
 - line length limit is larger (132 chars, unlike PEP-8)
 - uses 4 space indent (like PEP-8)
 - uses function_name, method_name rather than FunctionName, MethodName (like PEP-8).

As a compromise, we could potentially switch to 80-column width and 2-space indent, but allow a mix of snake_case and CamelCase.

Note about reformatting: While autopep8 (used by format-webkitpy) gets us most of the way there, it doesn't do comment text re-flow and doesn't handle all long line reformatting. It might be convenient use another tool like yapf for the cases that autopep8 doesn't handle.
 

Comment 1 by foolip@chromium.org, Dec 17 2017

Labels: -Pri-2 Pri-3

Comment 2 by ojan@chromium.org, Dec 17 2017

Cc: -ojan@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 18

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment