Issue metadata
Sign in to add a comment
|
ChromeVox extension crashes Chrome on right-clicks or opening options menu
Reported by
n...@emetric.net,
Sep 12 2017
|
||||||||||||||||||||||||
Issue description
Chrome Version : 61.0.3163.79
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5: N/A
Firefox 4.x: N/A
IE 7/8/9: N/A
What steps will reproduce the problem?
1. Install and enable the ChromeVox extension
2. Open Chrome and right-click anywhere multiple times or open the options menu (triple dots) multiple times
3.
What is the expected result?
Browser usage should continue as usual
What happens instead of that?
The browser will immediately close (i.e. crash).
Please provide any additional information below. Attach a screenshot if
possible.
A discussion on a nearly identical issue is here: https://productforums.google.com/forum/#!topic/chrome/KhDcnfbCnVQ
However, I can confirm that I don't have any anti-virus running.
ChromeVox version 53.0.2784.5
UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36
,
Sep 12 2017
,
Sep 12 2017
Please find the closest bisect which I can get for this bug : bisect range : You are probably looking for a change made after 61.0.3163.72 (known good), but no later than 61.0.3163.73 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/61.0.3163.72..61.0.3163.73?pretty=full Suspecting Cl : https://chromium.googlesource.com/chromium/src/+/107fb0be3669e6f024cae6c016c75faf0acc154a or https://chromium.googlesource.com/chromium/src/+/d3d54df24c0859b0b2356055f65359d97d1b98c8 Note : Both are w.r.t ChromeOS and I have no clue what is the relation.
,
Sep 12 2017
,
Sep 12 2017
URGENT - PTAL. This bug is currently marked as Stable Blocker for M61 Desktop Stable respin. Pls make sure to land the fix and get it merged into the release branch ASAP. Note: We're planning to cut M61 Desktop Stable RC tomorrow.
,
Sep 12 2017
Issue 764349 has been merged into this issue.
,
Sep 12 2017
If this doesn't reproduce on m62, then I'm pretty certain the fix is: https://chromium-review.googlesource.com/636024
,
Sep 12 2017
I wasn't able to reproduce this issue on Windows 7,10 and Ubuntu with Chrome dev i.e., 62.0.3202.18
,
Sep 12 2017
+amineer@ not sure how Accessibility testing is performed on Android and this could be applicable to Android or not. Adding Chrome OS might be broken there as well (Note: Prudhvi only tested on Desktop).
,
Sep 13 2017
If the issue only surfaces in Non-CrOS platforms, then it's absolutely unimaginable that this CrOS change could break anything: https://chromium.googlesource.com/chromium/src/+/d3d54df24c0859b0b2356055f65359d97d1b98c8
,
Sep 13 2017
Please see c8. I was able to get a stack trace and all indications are a regression in the Aura accessibility support which gets used by ChromeVox the extension for views. I would like to merge the change referenced in c8.
,
Sep 13 2017
,
Sep 13 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13 2017
Approving merge for cl listed at #8 to M61 branch 3163 based on comments #8, #9, #12 and per offline chat with dtseng@.
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4e02a38f1a18d2ec0a83ffdc5eb9799347bce1e commit a4e02a38f1a18d2ec0a83ffdc5eb9799347bce1e Author: David Tseng <dtseng@chromium.org> Date: Wed Sep 13 02:23:27 2017 Merge to m61: Cleanup: unify window observer handling - both AXAuraObjWrapper and AXWindowObjWrapper serve as WindowObservers; make it so only the latter does (thereby hitting the same observer methods) - removes fragile code that forgets to unobserve focus changes - makes things less stateful TBR=dtseng@chromium.org (cherry picked from commit a8015785c4bd541d310acee1f7d457de7a4dc71a) Bug: 764360 Change-Id: I54f505fb8c4772fd65a1a1ae5499c51a3562e304 Reviewed-on: https://chromium-review.googlesource.com/636024 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497662} Reviewed-on: https://chromium-review.googlesource.com/664479 Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1184} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/a4e02a38f1a18d2ec0a83ffdc5eb9799347bce1e/ui/views/accessibility/ax_aura_obj_cache.cc [modify] https://crrev.com/a4e02a38f1a18d2ec0a83ffdc5eb9799347bce1e/ui/views/accessibility/ax_aura_obj_cache.h [modify] https://crrev.com/a4e02a38f1a18d2ec0a83ffdc5eb9799347bce1e/ui/views/accessibility/ax_window_obj_wrapper.cc
,
Sep 13 2017
Looks like bisect is already updated in C#3 and fix landed. Hence removing the Needs-Bisect label from this.
,
Sep 13 2017
Looks like the fix was merged to 61 16 hours ago. Can we close this?
,
Sep 13 2017
,
Sep 14 2017
Verified the issue on windows 7 , ubuntu 14.04 using M61 #61.0.3163.91 and issue seems fixed. No crash is observed on right-clicks or opening menus item after adding ChromeVox extension. Attached screencast for reference. Adding TE-Verified labels. Thanks!
,
Sep 14 2017
This patch is now pushing out to stable channel in version 61.0.3163.91 for Desktop (Win,Mac & Linux).
,
Sep 14 2017
Thank you for fixing the bug. Requesting postmortem for this please see go/chrome-postmortems for the process to follow. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pbomm...@chromium.org
, Sep 12 2017Components: UI>Accessibility
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable Needs-Bisect M-61 OS-Linux Pri-1 Type-Bug-Regression
Status: Available (was: Unconfirmed)