Issue metadata
Sign in to add a comment
|
Chrome Home: cannot move accessibility focus to omnibox suggestions |
||||||||||||||||||||||||
Issue descriptionThis reproes on any version with Chrome Home enabled. Steps to reproduce: (1) Make sure Chrome Home is enabled. (2) Make sure that TalkBack is enabled. (3) Launch Chrome, and go to Omnibox. (4) Swipe from left to right to go to the next focusable node, and get to the clear input button. (5) Keep swiping from left to right until you can get to the suggestions below omnibox. Expected result: Focus the suggestions below omnibox. Actual result: Chrome Home bottom panel gets focus before getting to the suggestions. Ted, could you triage this? Thanks.
,
Sep 12 2017
I suspect that this would be fixed by having the suggestions exist as sheet content. Otherwise it looks like we would have to use an AccessibilityDelegate. I'll take a look.
,
Sep 15 2017
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12940865d67dd508968ed1042dc5add3e3d84eff commit 12940865d67dd508968ed1042dc5add3e3d84eff Author: Matthew Jones <mdjones@chromium.org> Date: Wed Sep 20 20:22:28 2017 [Home] Convert omnibox suggestions to be BottomSheetContent Omnibox suggestions are now a BottomSheetContent. This allows the suggestions to take advantage of the BottomSheet's frame work including animation/transitions and scroll handling. Any suggestions specific code has been removed from the bottom sheet. Special logic has been added to the BottomSheetController to determine what content should show after the suggestions are hidden (omnibox unfocused) so that the home sheet does not flash in during transition. This change also replaces the content type 'TYPE_PLACEHOLDER' with 'TYPE_AUXILIARY' for non-primary content. BUG= 764353 , 731128 Change-Id: Id9dc714b23cd40103f231cfc3e21b21875210576 Reviewed-on: https://chromium-review.googlesource.com/665166 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#503232} [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/res/layout/bottom_control_container.xml [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsSheetVisibilityChangeObserver.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/PlaceholderSheetContent.java [modify] https://crrev.com/12940865d67dd508968ed1042dc5add3e3d84eff/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsSheetVisibilityChangeObserverTest.java
,
Sep 20 2017
,
Sep 26 2017
I have tested this on M63: 63.0.3212.0 - accessibility focus jump directly from Omnibox clear input button to Chrome home bottom navigation bar. On latest build M63: 63.0.3223.7 - accessibility focus points to Omnibox suggestions. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tedc...@chromium.org
, Sep 12 2017Owner: mdjones@chromium.org
Status: Assigned (was: Untriaged)